From: Steven Rostedt <rostedt@goodmis.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
Andrew Morton <akpm@osdl.org>,
arjan@linux.intel.com, linux-kernel@vger.kernel.org
Subject: Re: [patch, -rc5-mm3] fix irqpoll some more
Date: Tue, 06 Jun 2006 11:32:45 -0400 [thread overview]
Message-ID: <1149607965.4558.4.camel@localhost.localdomain> (raw)
In-Reply-To: <20060606145915.GA627@elte.hu>
On Tue, 2006-06-06 at 16:59 +0200, Ingo Molnar wrote:
> *
>
> ouch. Then this problem is more urgent than i thought. We definitely
> need the disable_irq_handler(irq, handler) infrastructure and it should
> be used in the most common drivers affected (vortex/3c59x, forcedeth and
> IDE basically).
>
Ingo, did you take a look at my alternative? It postpones the unmasking
of the interrupt till the enable_irq is done. It also doesn't have the
need to update 300+ calls to disable/enable_irq.
Also, the disable_irq_handler doesn't solve the case if the misrouted
irq came from the device that its driver called the disable_irq_handler.
This doesn't affect irqpoll, but for those cases that have broken irq
setups needing irqfixup this can still allow an irq storm.
-- Steve
prev parent reply other threads:[~2006-06-06 15:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200606050600.k5560GdU002338@shell0.pdx.osdl.net>
[not found] ` <1149497459.23209.39.camel@localhost.localdomain>
2006-06-05 8:49 ` [patch, -rc5-mm3] fix irqpoll some more Ingo Molnar
2006-06-05 13:05 ` Alan Cox
2006-06-05 12:52 ` Ingo Molnar
2006-06-06 13:25 ` Steven Rostedt
2006-06-06 13:53 ` Ingo Molnar
2006-06-06 14:40 ` Steven Rostedt
2006-06-06 14:59 ` Ingo Molnar
2006-06-06 15:32 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1149607965.4558.4.camel@localhost.localdomain \
--to=rostedt@goodmis.org \
--cc=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=arjan@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.