All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Hugh Dickins <hugh@veritas.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	Andrew Morton <akpm@osdl.org>,
	David Howells <dhowells@redhat.com>,
	Christoph Lameter <christoph@lameter.com>,
	Martin Bligh <mbligh@google.com>, Nick Piggin <npiggin@suse.de>,
	Linus Torvalds <torvalds@osdl.org>
Subject: Re: [PATCH] mm: tracking dirty pages -v6
Date: Thu, 08 Jun 2006 15:02:02 +0200	[thread overview]
Message-ID: <1149771723.20886.10.camel@lappy> (raw)
In-Reply-To: <1149770654.4408.71.camel@lappy>

If this one still has some problems there is on more thing we could try
before going back to the old way of doing things.

I found this 'gem' in the drm code:

        vma->vm_page_prot =
            __pgprot(pte_val
                     (pte_wrprotect
                      (__pte(pgprot_val(vma->vm_page_prot)))));

which does exactly what is needed.

OTOH, my alternate version of the mprotect fix leaves dirty pages
writable, which saves a few faults.

Peter


WARNING: multiple messages have this Message-ID (diff)
From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Hugh Dickins <hugh@veritas.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	Andrew Morton <akpm@osdl.org>,
	David Howells <dhowells@redhat.com>,
	Christoph Lameter <christoph@lameter.com>,
	Martin Bligh <mbligh@google.com>, Nick Piggin <npiggin@suse.de>,
	Linus Torvalds <torvalds@osdl.org>
Subject: Re: [PATCH] mm: tracking dirty pages -v6
Date: Thu, 08 Jun 2006 15:02:02 +0200	[thread overview]
Message-ID: <1149771723.20886.10.camel@lappy> (raw)
In-Reply-To: <1149770654.4408.71.camel@lappy>

If this one still has some problems there is on more thing we could try
before going back to the old way of doing things.

I found this 'gem' in the drm code:

        vma->vm_page_prot =
            __pgprot(pte_val
                     (pte_wrprotect
                      (__pte(pgprot_val(vma->vm_page_prot)))));

which does exactly what is needed.

OTOH, my alternate version of the mprotect fix leaves dirty pages
writable, which saves a few faults.

Peter

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2006-06-08 13:02 UTC|newest]

Thread overview: 61+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-05-25 13:55 [PATCH 0/3] mm: tracking dirty pages -v5 Peter Zijlstra
2006-05-25 13:55 ` Peter Zijlstra
2006-05-25 13:55 ` [PATCH -1/3] mm: page_mkwrite Peter Zijlstra
2006-05-25 13:55   ` Peter Zijlstra
2006-05-25 13:55 ` [PATCH 1/3] mm: tracking shared dirty pages Peter Zijlstra
2006-05-25 13:55   ` Peter Zijlstra
2006-05-25 16:21   ` Christoph Lameter
2006-05-25 16:21     ` Christoph Lameter
2006-05-25 17:00     ` Peter Zijlstra
2006-05-25 17:00       ` Peter Zijlstra
2006-05-25 17:03       ` Christoph Lameter
2006-05-25 17:03         ` Christoph Lameter
2006-05-25 16:27   ` Christoph Lameter
2006-05-25 16:27     ` Christoph Lameter
2006-05-25 17:03     ` Peter Zijlstra
2006-05-25 17:03       ` Peter Zijlstra
2006-05-25 17:06       ` Christoph Lameter
2006-05-25 17:06         ` Christoph Lameter
2006-05-26  2:28     ` Jeff Anderson-Lee
2006-05-26  2:28       ` Jeff Anderson-Lee
2006-05-26  2:33       ` Christoph Lameter
2006-05-26 14:33     ` David Howells
2006-05-26 14:33       ` David Howells
2006-05-26 15:39       ` Christoph Lameter
2006-05-26 15:39         ` Christoph Lameter
2006-05-30  8:00         ` David Howells
2006-05-30  8:00           ` David Howells
2006-05-30 15:38           ` Christoph Lameter
2006-05-30 15:38             ` Christoph Lameter
2006-05-30 16:26             ` David Howells
2006-05-30 16:26               ` David Howells
2006-05-30 17:02               ` Christoph Lameter
2006-05-30 17:02                 ` Christoph Lameter
2006-05-30 17:25                 ` Hugh Dickins
2006-05-30 17:25                   ` Hugh Dickins
2006-05-30 17:30                   ` Christoph Lameter
2006-05-30 17:30                     ` Christoph Lameter
2006-05-30 17:41                     ` Hugh Dickins
2006-05-30 17:41                       ` Hugh Dickins
2006-05-30 17:56                 ` David Howells
2006-05-30 17:56                   ` David Howells
2006-05-30 20:21                   ` Christoph Lameter
2006-05-30 20:21                     ` Christoph Lameter
2006-05-25 13:56 ` [PATCH 2/3] mm: balance " Peter Zijlstra
2006-05-25 13:56   ` Peter Zijlstra
2006-05-25 13:56 ` [PATCH 3/3] mm: msync cleanup Peter Zijlstra
2006-05-25 13:56   ` Peter Zijlstra
2006-06-06 20:06 ` [PATCH 0/3] mm: tracking dirty pages -v5 Hugh Dickins
2006-06-06 20:06   ` Hugh Dickins
2006-06-07 18:08   ` Peter Zijlstra
2006-06-07 18:08     ` Peter Zijlstra
2006-06-08 12:44   ` [PATCH] mm: tracking dirty pages -v6 Peter Zijlstra
2006-06-08 12:44     ` Peter Zijlstra
2006-06-08 13:02     ` Peter Zijlstra [this message]
2006-06-08 13:02       ` Peter Zijlstra
2006-06-08 16:53     ` Christoph Lameter
2006-06-08 16:53       ` Christoph Lameter
2006-06-08 20:10     ` Nate Diller
2006-06-08 20:10       ` Nate Diller
2006-06-08 20:20       ` Linus Torvalds
2006-06-08 20:20         ` Linus Torvalds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1149771723.20886.10.camel@lappy \
    --to=a.p.zijlstra@chello.nl \
    --cc=akpm@osdl.org \
    --cc=christoph@lameter.com \
    --cc=dhowells@redhat.com \
    --cc=hugh@veritas.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mbligh@google.com \
    --cc=npiggin@suse.de \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.