From: James Antill <jantill@redhat.com>
To: Eric Paris <eparis@parisplace.org>
Cc: selinux@tycho.nsa.gov
Subject: Re: [PATCH] libselinux: 2/2 Convert functions to use new get,set procattrcon
Date: Fri, 23 Jun 2006 21:09:05 -0400 [thread overview]
Message-ID: <1151111346.21635.131.camel@code.and.org> (raw)
In-Reply-To: <1151094771.21012.94.camel@localhost.localdomain>
[-- Attachment #1: Type: text/plain, Size: 866 bytes --]
On Fri, 2006-06-23 at 16:32 -0400, Eric Paris wrote:
> The below patch will convert
>
> -{get,set}fscreatecon()
> -{get,set}execcon()
> -{get,set}con()
> -getpidcon()
> -getprevcon()
>
> to use the new {get,set}procattrcon() generic functions. The only two
> caveats are
>
> both getprevcon_raw() and getcon_raw() had callers elsewhere in
> libselinux. So the raw version of these functions were left and now
> call directly into the raw version of the generic functions.
I see you removed a bunch of *_raw() functions, you've changed the ABI
of the library and broken at least secon (in policycoreutils) and
gnome-vfs2. Is that intentional?
The hidden_def() doesn't make them library local functions, just
creates the hidden version as an alias ... so ignore that part of my
previous email.
--
James Antill <jantill@redhat.com>
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2006-06-24 1:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-23 20:32 [PATCH] libselinux: 2/2 Convert functions to use new get,set procattrcon Eric Paris
2006-06-24 1:09 ` James Antill [this message]
2006-06-24 6:27 ` Eric Paris
2006-06-26 12:23 ` Daniel J Walsh
-- strict thread matches above, loose matches on Subject: below --
2006-06-26 16:48 Eric Paris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1151111346.21635.131.camel@code.and.org \
--to=jantill@redhat.com \
--cc=eparis@parisplace.org \
--cc=selinux@tycho.nsa.gov \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.