Re: [PATCH] libselinux: 2/2 Convert functions to use new get,set procattrcon

[Daniel J Walsh <dwalsh@redhat.com>]

Eric Paris wrote:
> On Fri, 2006-06-23 at 21:09 -0400, James Antill wrote:
>   
>> On Fri, 2006-06-23 at 16:32 -0400, Eric Paris wrote:
>>     
>>> The below patch will convert
>>>
>>> -{get,set}fscreatecon()
>>> -{get,set}execcon()
>>> -{get,set}con()
>>> -getpidcon()
>>> -getprevcon()
>>>
>>> to use the new {get,set}procattrcon() generic functions.  The only two
>>> caveats are
>>>
>>> both getprevcon_raw() and getcon_raw() had callers elsewhere in
>>> libselinux.  So the raw version of these functions were left and now
>>> call directly into the raw version of the generic functions.
>>>       
>>  I see you removed a bunch of *_raw() functions, you've changed the ABI
>> of the library and broken at least secon (in policycoreutils) and
>> gnome-vfs2. Is that intentional?
>>
>>  The hidden_def() doesn't make them library local functions, just
>> creates the hidden version as an alias ... so ignore that part of my
>> previous email.
>>     
>
> Obviously I wasn't intending to break other things.   I thought the
> hidden portion was actually making them library local and so I just
> checked to make sure there were no other users in the library, that and
> my machine didn't die a horrible death when I started using it.  They
> are very simple to add back and I will post a patch that returns the
> _raw functions and so doesn't change the abi at all on Monday.
>
> -Eric
>
>   
The raw functions are for applications that do not want translations.  
Actually any
application that does not display the data to users should use the _raw.
> --
> This message was distributed to subscribers of the selinux mailing list.
> If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
> the words "unsubscribe selinux" without quotes as the message.
>   



--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.