Re: [PATCH REPOST 1/2] Network Event Notifier Mechanism.

[Steve Wise <swise@opengridcomputing.com>]

On Fri, 2006-06-23 at 13:26 -0700, David Miller wrote:
> From: Steve Wise <swise@opengridcomputing.com>
> Date: Fri, 23 Jun 2006 15:19:28 -0500
> 
> > +struct netevent_route_change {
> > +        int event;
> > +        struct fib_info *fib_info;
> > +};
> 
> It's not generic if you're putting ipv4 FIB route objects
> in the datastructure.
> 

True. 

I guess what I think we should do is pass the fib_info * when its a IPv4
route add/del, and a rt6_info * when its a IPv6 add/del.  This avoids
having to create some new family independent struct.  What I'll have to
do, however, is have specific notifier event enums for each: 

NETEVENT_IPV4_ROUTE_ADD
NETEVENT_IPV4_ROUTE_DEL
NETEVENT_IPV6_ROUTE_ADD
NETEVENT_IPV6_ROUTE_DEL

This keeps it simple IMO...

Does that sound reasonable to you?

Steve.