Re: [PATCH REPOST 1/2] Network Event Notifier Mechanism.

[Steve Wise <swise@opengridcomputing.com>]

On Mon, 2006-06-26 at 10:43 -0700, David Miller wrote:
> From: Steve Wise <swise@opengridcomputing.com>
> Date: Mon, 26 Jun 2006 10:26:11 -0500
> 
> > I guess what I think we should do is pass the fib_info * when its a IPv4
> > route add/del, and a rt6_info * when its a IPv6 add/del.  This avoids
> > having to create some new family independent struct.  What I'll have to
> > do, however, is have specific notifier event enums for each: 
> > 
> > NETEVENT_IPV4_ROUTE_ADD
> > NETEVENT_IPV4_ROUTE_DEL
> > NETEVENT_IPV6_ROUTE_ADD
> > NETEVENT_IPV6_ROUTE_DEL
> > 
> > This keeps it simple IMO...
> > 
> > Does that sound reasonable to you?
> 
> You can avoid creating an event per address family by defining your
> data as:
> 
> 	struct netevent_route_info {
> 		u16 family;
> 		void *data;
> 	};
> 
> and passing that through the notifier.
> 
> Then you just need NETEVENT_ROUTE_{ADD,DEL}
> 
> Just an idea...

Seems reasonable.   

Thanks,

Steve.