All of lore.kernel.org
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Olaf Hering <olh@suse.de>
Cc: linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: crash in aty128_set_lcd_enable on PowerBook
Date: Sun, 16 Jul 2006 15:19:09 -0400	[thread overview]
Message-ID: <1153077550.5905.33.camel@localhost.localdomain> (raw)
In-Reply-To: <20060716165004.GA16369@suse.de>

On Sun, 2006-07-16 at 18:50 +0200, Olaf Hering wrote:
>  On Sun, Jul 16, Olaf Hering wrote:
> 
> > 
> > Current Linus tree crashes in aty128_set_lcd_enable() because par->pdev
> > is NULL. This happens since at least a week. Call trace is:
> > 
> > aty128_set_lcd_enable
> > aty128fb_set_par
> > fbcon_init
> > visual_init
> > take_over_console
> > fbcon_takeover
> > notifier_call_chain
> > blocking_notifier_call_chain
> > register_framebuffer
> > aty128fb_probe
> 
> aty128_init calls register_framebuffer() before it assigns pdev.

Yeah, that looks like some serious bogosity in that code. Care to send a
patch ?

>    2028         if (register_framebuffer(info) < 0)
>    2029                 return 0;
>    2030 
>    2031         par->pm_reg = pci_find_capability(pdev, PCI_CAP_ID_PM);
>    2032         par->pdev = pdev;
>    2033         par->asleep = 0;
>    2034         par->lock_blank = 0;
> 
> 
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev

WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Olaf Hering <olh@suse.de>
Cc: linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org
Subject: Re: crash in aty128_set_lcd_enable on PowerBook
Date: Sun, 16 Jul 2006 15:19:09 -0400	[thread overview]
Message-ID: <1153077550.5905.33.camel@localhost.localdomain> (raw)
In-Reply-To: <20060716165004.GA16369@suse.de>

On Sun, 2006-07-16 at 18:50 +0200, Olaf Hering wrote:
>  On Sun, Jul 16, Olaf Hering wrote:
> 
> > 
> > Current Linus tree crashes in aty128_set_lcd_enable() because par->pdev
> > is NULL. This happens since at least a week. Call trace is:
> > 
> > aty128_set_lcd_enable
> > aty128fb_set_par
> > fbcon_init
> > visual_init
> > take_over_console
> > fbcon_takeover
> > notifier_call_chain
> > blocking_notifier_call_chain
> > register_framebuffer
> > aty128fb_probe
> 
> aty128_init calls register_framebuffer() before it assigns pdev.

Yeah, that looks like some serious bogosity in that code. Care to send a
patch ?

>    2028         if (register_framebuffer(info) < 0)
>    2029                 return 0;
>    2030 
>    2031         par->pm_reg = pci_find_capability(pdev, PCI_CAP_ID_PM);
>    2032         par->pdev = pdev;
>    2033         par->asleep = 0;
>    2034         par->lock_blank = 0;
> 
> 
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev


  reply	other threads:[~2006-07-16 19:19 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-07-16 16:37 crash in aty128_set_lcd_enable on PowerBook Olaf Hering
2006-07-16 16:50 ` Olaf Hering
2006-07-16 19:19   ` Benjamin Herrenschmidt [this message]
2006-07-16 19:19     ` Benjamin Herrenschmidt
2006-07-16 19:25     ` Benjamin Herrenschmidt
2006-07-16 19:25       ` Benjamin Herrenschmidt
2006-07-16 19:27       ` Olaf Hering
2006-07-16 19:27         ` Olaf Hering
2006-07-16 19:43         ` Benjamin Herrenschmidt
2006-07-16 19:43           ` Benjamin Herrenschmidt
2006-07-16 19:50           ` Olaf Hering
2006-07-16 19:50             ` Olaf Hering
2006-07-31 18:50 ` [PATCH] " Olaf Hering
2006-07-31 23:50   ` Antonino A. Daplas
2006-07-31 23:50     ` Antonino A. Daplas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1153077550.5905.33.camel@localhost.localdomain \
    --to=benh@kernel.crashing.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=olh@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.