* [PATCH][QEMU] Add IA64-specific code for new qemu.
@ 2006-07-25 2:09 Zhang, Xiantao
2006-07-26 11:24 ` Akio Takebe
2006-07-26 12:41 ` Christian Limpach
0 siblings, 2 replies; 7+ messages in thread
From: Zhang, Xiantao @ 2006-07-25 2:09 UTC (permalink / raw)
To: xen-devel; +Cc: xen-ia64-devel
[-- Attachment #1: Type: text/plain, Size: 305 bytes --]
This patch adds the ia64-specific code for new Qemu .
In addition, some ia64 patches aren't checked into xen-unstable.hg, so I
reversed the related logic temporarily. Once sync with
xen-ia64-unstable.hg, the logic will regain automatically.
Thanks & Best Regards
-Xiantao
OTC,Intel Corporation
[-- Attachment #2: ia64_specific_code_for_qemu.patch --]
[-- Type: application/octet-stream, Size: 15980 bytes --]
IA64-specific code for new Qemu
Due to some ia64 patches aren't checked into xen-unstable.hg.
I reversed related logic.
Signed-off-by :Zhang xiantao <xiantao.zhang@intel.com>
diff -r a70c4f9657cc tools/ioemu/ia64_intrinsic.h
--- /dev/null Thu Jan 01 00:00:00 1970 +0000
+++ b/tools/ioemu/ia64_intrinsic.h Thu Jul 13 14:12:42 2006 -0600
@@ -0,0 +1,276 @@
+#ifndef IA64_INTRINSIC_H
+#define IA64_INTRINSIC_H
+
+/*
+ * Compiler-dependent Intrinsics
+ *
+ * Copyright (C) 2002,2003 Jun Nakajima <jun.nakajima@intel.com>
+ * Copyright (C) 2002,2003 Suresh Siddha <suresh.b.siddha@intel.com>
+ *
+ */
+extern long ia64_cmpxchg_called_with_bad_pointer (void);
+extern void ia64_bad_param_for_getreg (void);
+#define ia64_cmpxchg(sem,ptr,o,n,s) ({ \
+ uint64_t _o, _r; \
+ switch(s) { \
+ case 1: _o = (uint8_t)(long)(o); break; \
+ case 2: _o = (uint16_t)(long)(o); break; \
+ case 4: _o = (uint32_t)(long)(o); break; \
+ case 8: _o = (uint64_t)(long)(o); break; \
+ default: break; \
+ } \
+ switch(s) { \
+ case 1: \
+ _r = ia64_cmpxchg1_##sem((uint8_t*)ptr,n,_o); break; \
+ case 2: \
+ _r = ia64_cmpxchg2_##sem((uint16_t*)ptr,n,_o); break; \
+ case 4: \
+ _r = ia64_cmpxchg4_##sem((uint32_t*)ptr,n,_o); break; \
+ case 8: \
+ _r = ia64_cmpxchg8_##sem((uint64_t*)ptr,n,_o); break; \
+ default: \
+ _r = ia64_cmpxchg_called_with_bad_pointer(); break; \
+ } \
+ (__typeof__(o)) _r; \
+})
+
+#define cmpxchg_acq(ptr,o,n) ia64_cmpxchg(acq,ptr,o,n,sizeof(*ptr))
+#define cmpxchg_rel(ptr,o,n) ia64_cmpxchg(rel,ptr,o,n,sizeof(*ptr))
+
+/*
+ * Register Names for getreg() and setreg().
+ *
+ * The "magic" numbers happen to match the values used by the Intel compiler's
+ * getreg()/setreg() intrinsics.
+ */
+
+/* Special Registers */
+
+#define _IA64_REG_IP 1016 /* getreg only */
+#define _IA64_REG_PSR 1019
+#define _IA64_REG_PSR_L 1019
+
+/* General Integer Registers */
+
+#define _IA64_REG_GP 1025 /* R1 */
+#define _IA64_REG_R8 1032 /* R8 */
+#define _IA64_REG_R9 1033 /* R9 */
+#define _IA64_REG_SP 1036 /* R12 */
+#define _IA64_REG_TP 1037 /* R13 */
+
+/* Application Registers */
+
+#define _IA64_REG_AR_KR0 3072
+#define _IA64_REG_AR_KR1 3073
+#define _IA64_REG_AR_KR2 3074
+#define _IA64_REG_AR_KR3 3075
+#define _IA64_REG_AR_KR4 3076
+#define _IA64_REG_AR_KR5 3077
+#define _IA64_REG_AR_KR6 3078
+#define _IA64_REG_AR_KR7 3079
+#define _IA64_REG_AR_RSC 3088
+#define _IA64_REG_AR_BSP 3089
+#define _IA64_REG_AR_BSPSTORE 3090
+#define _IA64_REG_AR_RNAT 3091
+#define _IA64_REG_AR_FCR 3093
+#define _IA64_REG_AR_EFLAG 3096
+#define _IA64_REG_AR_CSD 3097
+#define _IA64_REG_AR_SSD 3098
+#define _IA64_REG_AR_CFLAG 3099
+#define _IA64_REG_AR_FSR 3100
+#define _IA64_REG_AR_FIR 3101
+#define _IA64_REG_AR_FDR 3102
+#define _IA64_REG_AR_CCV 3104
+#define _IA64_REG_AR_UNAT 3108
+#define _IA64_REG_AR_FPSR 3112
+#define _IA64_REG_AR_ITC 3116
+#define _IA64_REG_AR_PFS 3136
+#define _IA64_REG_AR_LC 3137
+#define _IA64_REG_AR_EC 3138
+
+/* Control Registers */
+
+#define _IA64_REG_CR_DCR 4096
+#define _IA64_REG_CR_ITM 4097
+#define _IA64_REG_CR_IVA 4098
+#define _IA64_REG_CR_PTA 4104
+#define _IA64_REG_CR_IPSR 4112
+#define _IA64_REG_CR_ISR 4113
+#define _IA64_REG_CR_IIP 4115
+#define _IA64_REG_CR_IFA 4116
+#define _IA64_REG_CR_ITIR 4117
+#define _IA64_REG_CR_IIPA 4118
+#define _IA64_REG_CR_IFS 4119
+#define _IA64_REG_CR_IIM 4120
+#define _IA64_REG_CR_IHA 4121
+#define _IA64_REG_CR_LID 4160
+#define _IA64_REG_CR_IVR 4161 /* getreg only */
+#define _IA64_REG_CR_TPR 4162
+#define _IA64_REG_CR_EOI 4163
+#define _IA64_REG_CR_IRR0 4164 /* getreg only */
+#define _IA64_REG_CR_IRR1 4165 /* getreg only */
+#define _IA64_REG_CR_IRR2 4166 /* getreg only */
+#define _IA64_REG_CR_IRR3 4167 /* getreg only */
+#define _IA64_REG_CR_ITV 4168
+#define _IA64_REG_CR_PMV 4169
+#define _IA64_REG_CR_CMCV 4170
+#define _IA64_REG_CR_LRR0 4176
+#define _IA64_REG_CR_LRR1 4177
+
+/* Indirect Registers for getindreg() and setindreg() */
+
+#define _IA64_REG_INDR_CPUID 9000 /* getindreg only */
+#define _IA64_REG_INDR_DBR 9001
+#define _IA64_REG_INDR_IBR 9002
+#define _IA64_REG_INDR_PKR 9003
+#define _IA64_REG_INDR_PMC 9004
+#define _IA64_REG_INDR_PMD 9005
+#define _IA64_REG_INDR_RR 9006
+
+#ifdef __INTEL_COMPILER
+void __fc(uint64_t *addr);
+void __synci(void);
+void __isrlz(void);
+void __dsrlz(void);
+uint64_t __getReg(const int whichReg);
+uint64_t _InterlockedCompareExchange8_rel(volatile uint8_t *dest, uint64_t xchg, uint64_t comp);
+uint64_t _InterlockedCompareExchange8_acq(volatile uint8_t *dest, uint64_t xchg, uint64_t comp);
+uint64_t _InterlockedCompareExchange16_rel(volatile uint16_t *dest, uint64_t xchg, uint64_t comp);
+uint64_t _InterlockedCompareExchange16_acq(volatile uint16_t *dest, uint64_t xchg, uint64_t comp);
+uint64_t _InterlockedCompareExchange_rel(volatile uint32_t *dest, uint64_t xchg, uint64_t comp);
+uint64_t _InterlockedCompareExchange_acq(volatile uint32_t *dest, uint64_t xchg, uint64_t comp);
+uint64_t _InterlockedCompareExchange64_rel(volatile uint64_t *dest, uint64_t xchg, uint64_t comp);
+u64_t _InterlockedCompareExchange64_acq(volatile uint64_t *dest, uint64_t xchg, uint64_t comp);
+
+#define ia64_cmpxchg1_rel _InterlockedCompareExchange8_rel
+#define ia64_cmpxchg1_acq _InterlockedCompareExchange8_acq
+#define ia64_cmpxchg2_rel _InterlockedCompareExchange16_rel
+#define ia64_cmpxchg2_acq _InterlockedCompareExchange16_acq
+#define ia64_cmpxchg4_rel _InterlockedCompareExchange_rel
+#define ia64_cmpxchg4_acq _InterlockedCompareExchange_acq
+#define ia64_cmpxchg8_rel _InterlockedCompareExchange64_rel
+#define ia64_cmpxchg8_acq _InterlockedCompareExchange64_acq
+
+#define ia64_srlz_d __dsrlz
+#define ia64_srlz_i __isrlz
+#define __ia64_fc __fc
+#define ia64_sync_i __synci
+#define __ia64_getreg __getReg
+#else /* __INTEL_COMPILER */
+#define ia64_cmpxchg1_acq(ptr, new, old) \
+({ \
+ uint64_t ia64_intri_res; \
+ asm volatile ("mov ar.ccv=%0;;" :: "rO"(old)); \
+ asm volatile ("cmpxchg1.acq %0=[%1],%2,ar.ccv": \
+ "=r"(ia64_intri_res) : "r"(ptr), "r"(new) : "memory"); \
+ ia64_intri_res; \
+})
+
+#define ia64_cmpxchg1_rel(ptr, new, old) \
+({ \
+ uint64_t ia64_intri_res; \
+ asm volatile ("mov ar.ccv=%0;;" :: "rO"(old)); \
+ asm volatile ("cmpxchg1.rel %0=[%1],%2,ar.ccv": \
+ "=r"(ia64_intri_res) : "r"(ptr), "r"(new) : "memory"); \
+ ia64_intri_res; \
+})
+
+#define ia64_cmpxchg2_acq(ptr, new, old) \
+({ \
+ uint64_t ia64_intri_res; \
+ asm volatile ("mov ar.ccv=%0;;" :: "rO"(old)); \
+ asm volatile ("cmpxchg2.acq %0=[%1],%2,ar.ccv": \
+ "=r"(ia64_intri_res) : "r"(ptr), "r"(new) : "memory"); \
+ ia64_intri_res; \
+})
+
+#define ia64_cmpxchg2_rel(ptr, new, old) \
+({ \
+ uint64_t ia64_intri_res; \
+ asm volatile ("mov ar.ccv=%0;;" :: "rO"(old)); \
+ \
+ asm volatile ("cmpxchg2.rel %0=[%1],%2,ar.ccv": \
+ "=r"(ia64_intri_res) : "r"(ptr), "r"(new) : "memory"); \
+ ia64_intri_res; \
+})
+
+#define ia64_cmpxchg4_acq(ptr, new, old) \
+({ \
+ uint64_t ia64_intri_res; \
+ asm volatile ("mov ar.ccv=%0;;" :: "rO"(old)); \
+ asm volatile ("cmpxchg4.acq %0=[%1],%2,ar.ccv": \
+ "=r"(ia64_intri_res) : "r"(ptr), "r"(new) : "memory"); \
+ ia64_intri_res; \
+})
+
+#define ia64_cmpxchg4_rel(ptr, new, old) \
+({ \
+ uint64_t ia64_intri_res; \
+ asm volatile ("mov ar.ccv=%0;;" :: "rO"(old)); \
+ asm volatile ("cmpxchg4.rel %0=[%1],%2,ar.ccv": \
+ "=r"(ia64_intri_res) : "r"(ptr), "r"(new) : "memory"); \
+ ia64_intri_res; \
+})
+
+#define ia64_cmpxchg8_acq(ptr, new, old) \
+({ \
+ uint64_t ia64_intri_res; \
+ asm volatile ("mov ar.ccv=%0;;" :: "rO"(old)); \
+ asm volatile ("cmpxchg8.acq %0=[%1],%2,ar.ccv": \
+ "=r"(ia64_intri_res) : "r"(ptr), "r"(new) : "memory"); \
+ ia64_intri_res; \
+})
+
+#define ia64_cmpxchg8_rel(ptr, new, old) \
+({ \
+ uint64_t ia64_intri_res; \
+ asm volatile ("mov ar.ccv=%0;;" :: "rO"(old)); \
+ \
+ asm volatile ("cmpxchg8.rel %0=[%1],%2,ar.ccv": \
+ "=r"(ia64_intri_res) : "r"(ptr), "r"(new) : "memory"); \
+ ia64_intri_res; \
+})
+
+#define ia64_srlz_i() asm volatile (";; srlz.i ;;" ::: "memory")
+#define ia64_srlz_d() asm volatile (";; srlz.d" ::: "memory");
+#define __ia64_fc(addr) asm volatile ("fc %0" :: "r"(addr) : "memory")
+#define ia64_sync_i() asm volatile (";; sync.i" ::: "memory")
+
+register unsigned long ia64_r13 asm ("r13") __attribute_used__;
+#define __ia64_getreg(regnum) \
+({ \
+ uint64_t ia64_intri_res; \
+ \
+ switch (regnum) { \
+ case _IA64_REG_GP: \
+ asm volatile ("mov %0=gp" : "=r"(ia64_intri_res)); \
+ break; \
+ case _IA64_REG_IP: \
+ asm volatile ("mov %0=ip" : "=r"(ia64_intri_res)); \
+ break; \
+ case _IA64_REG_PSR: \
+ asm volatile ("mov %0=psr" : "=r"(ia64_intri_res)); \
+ break; \
+ case _IA64_REG_TP: /* for current() */ \
+ ia64_intri_res = ia64_r13; \
+ break; \
+ case _IA64_REG_AR_KR0 ... _IA64_REG_AR_EC: \
+ asm volatile ("mov %0=ar%1" : "=r" (ia64_intri_res) \
+ : "i"(regnum - _IA64_REG_AR_KR0)); \
+ break; \
+ case _IA64_REG_CR_DCR ... _IA64_REG_CR_LRR1: \
+ asm volatile ("mov %0=cr%1" : "=r" (ia64_intri_res) \
+ : "i" (regnum - _IA64_REG_CR_DCR)); \
+ break; \
+ case _IA64_REG_SP: \
+ asm volatile ("mov %0=sp" : "=r" (ia64_intri_res)); \
+ break; \
+ default: \
+ ia64_bad_param_for_getreg(); \
+ break; \
+ } \
+ ia64_intri_res; \
+})
+
+#endif /* __INTEL_COMPILER */
+#endif /* IA64_INTRINSIC_H */
diff -r bbabdebc54ad tools/ioemu/cpu-all.h
--- a/tools/ioemu/cpu-all.h Wed Jul 19 21:13:36 2006 +0100
+++ b/tools/ioemu/cpu-all.h Tue Jul 25 09:30:05 2006 +0800
@@ -835,6 +835,31 @@ static __inline__ void atomic_clear_bit(
:"=m" (*(volatile long *)addr)
:"dIr" (nr));
}
+#elif defined(__ia64__)
+#include "ia64_intrinsic.h"
+#define atomic_set_bit(nr, addr) ({ \
+ typeof(*addr) bit, old, new; \
+ volatile typeof(*addr) *m; \
+ \
+ m = (volatile typeof(*addr)*)(addr + nr / (8*sizeof(*addr))); \
+ bit = 1 << (nr % (8*sizeof(*addr))); \
+ do { \
+ old = *m; \
+ new = old | bit; \
+ } while (cmpxchg_acq(m, old, new) != old); \
+})
+
+#define atomic_clear_bit(nr, addr) ({ \
+ typeof(*addr) bit, old, new; \
+ volatile typeof(*addr) *m; \
+ \
+ m = (volatile typeof(*addr)*)(addr + nr / (8*sizeof(*addr))); \
+ bit = ~(1 << (nr % (8*sizeof(*addr)))); \
+ do { \
+ old = *m; \
+ new = old & bit; \
+ } while (cmpxchg_acq(m, old, new) != old); \
+})
#endif
/* memory API */
diff -r bbabdebc54ad tools/ioemu/exec-all.h
--- a/tools/ioemu/exec-all.h Wed Jul 19 21:13:36 2006 +0100
+++ b/tools/ioemu/exec-all.h Tue Jul 25 09:30:05 2006 +0800
@@ -391,6 +391,15 @@ static inline int testandset (int *p)
}
#endif
+#ifdef __ia64__
+#include "ia64_intrinsic.h"
+static inline int testandset (int *p)
+{
+ uint32_t o = 0, n = 1;
+ return (int)cmpxchg_acq(p, o, n);
+}
+#endif
+
#ifdef __s390__
static inline int testandset (int *p)
{
diff -r bbabdebc54ad tools/ioemu/hw/iommu.c
--- a/tools/ioemu/hw/iommu.c Wed Jul 19 21:13:36 2006 +0100
+++ b/tools/ioemu/hw/iommu.c Tue Jul 25 09:30:05 2006 +0800
@@ -82,7 +82,11 @@ do { printf("IOMMU: " fmt , ##args); } w
#define IOPTE_VALID 0x00000002 /* IOPTE is valid */
#define IOPTE_WAZ 0x00000001 /* Write as zeros */
+#if defined(__i386__) || defined(__x86_64__)
#define PAGE_SHIFT 12
+#elif defined(__ia64__)
+#define PAGE_SHIFT 14
+#endif
#define PAGE_SIZE (1 << PAGE_SHIFT)
#define PAGE_MASK (PAGE_SIZE - 1)
diff -r bbabdebc54ad tools/ioemu/target-i386-dm/cpu.h
--- a/tools/ioemu/target-i386-dm/cpu.h Wed Jul 19 21:13:36 2006 +0100
+++ b/tools/ioemu/target-i386-dm/cpu.h Tue Jul 25 09:30:05 2006 +0800
@@ -80,7 +80,11 @@ int cpu_x86_inl(CPUX86State *env, int ad
/* helper2.c */
int main_loop(void);
+#if defined(__i386__) || defined(__x86_64__)
#define TARGET_PAGE_BITS 12
+#elif defined(__ia64__)
+#define TARGET_PAGE_BITS 14
+#endif
#include "cpu-all.h"
#endif /* CPU_I386_H */
diff -r bbabdebc54ad tools/ioemu/target-i386-dm/exec-dm.c
--- a/tools/ioemu/target-i386-dm/exec-dm.c Wed Jul 19 21:13:36 2006 +0100
+++ b/tools/ioemu/target-i386-dm/exec-dm.c Tue Jul 25 09:30:05 2006 +0800
@@ -339,6 +339,23 @@ CPUReadMemoryFunc **cpu_get_io_memory_re
{
return io_mem_read[io_index >> IO_MEM_SHIFT];
}
+
+#ifdef __ia64__
+/* IA64 has seperate I/D cache, with coherence maintained by DMA controller.
+ * So to emulate right behavior that guest OS is assumed, we need to flush
+ * I/D cache here.
+ */
+static void sync_icache(unsigned long address, int len)
+{
+ int l;
+
+ for(l = 0; l < (len + 32); l += 32)
+ __ia64_fc(address + l);
+
+ ia64_sync_i();
+ ia64_srlz_i();
+}
+#endif
/* physical memory access (slow version, mainly for debug) */
#if defined(CONFIG_USER_ONLY)
@@ -455,6 +472,9 @@ void cpu_physical_memory_rw(target_phys_
ptr = phys_ram_base + (pd & TARGET_PAGE_MASK) +
(addr & ~TARGET_PAGE_MASK);
memcpy(buf, ptr, l);
+#ifdef __ia64__
+ sync_icache((unsigned long)ptr, l);
+#endif
}
}
len -= l;
diff -r bbabdebc54ad tools/ioemu/target-i386/cpu.h
--- a/tools/ioemu/target-i386/cpu.h Wed Jul 19 21:13:36 2006 +0100
+++ b/tools/ioemu/target-i386/cpu.h Tue Jul 25 09:30:05 2006 +0800
@@ -647,7 +647,11 @@ static inline int cpu_get_time_fast(void
}
#endif
+#if defined(__i386__) || defined(__x86_64__)
#define TARGET_PAGE_BITS 12
+#elif defined(__ia64__)
+#define TARGET_PAGE_BITS 14
+#endif
#include "cpu-all.h"
#endif /* CPU_I386_H */
diff -r bbabdebc54ad tools/ioemu/vl.c
--- a/tools/ioemu/vl.c Wed Jul 19 21:13:36 2006 +0100
+++ b/tools/ioemu/vl.c Tue Jul 25 09:30:05 2006 +0800
@@ -5754,6 +5754,7 @@ int main(int argc, char **argv)
exit(-1);
}
+#if defined(__i386__) || defined(__x86_64__)
if (xc_get_pfn_list(xc_handle, domid, page_array, nr_pages) != nr_pages) {
fprintf(logfile, "xc_get_pfn_list returned error %d\n", errno);
exit(-1);
@@ -5774,6 +5775,34 @@ int main(int argc, char **argv)
fprintf(logfile, "shared page at pfn:%lx, mfn: %"PRIx64"\n", nr_pages - 1,
(uint64_t)(page_array[nr_pages - 1]));
+#elif defined(__ia64__)
+ if (xc_ia64_get_pfn_list(xc_handle, domid,
+ page_array, 0, nr_pages) != nr_pages) {
+ fprintf(logfile, "xc_ia64_get_pfn_list returned error %d\n", errno);
+ exit(-1);
+ }
+
+ phys_ram_base = xc_map_foreign_batch(xc_handle, domid,
+ PROT_READ|PROT_WRITE,
+ page_array, nr_pages);
+ if (phys_ram_base == 0) {
+ fprintf(logfile, "xc_map_foreign_batch returned error %d\n", errno);
+ exit(-1);
+ }
+
+ if (xc_ia64_get_pfn_list(xc_handle, domid, page_array,
+ nr_pages + (GFW_SIZE >> PAGE_SHIFT), 1)!= 1){
+ fprintf(logfile, "xc_ia64_get_pfn_list returned error %d\n", errno);
+ exit(-1);
+ }
+
+ shared_page = xc_map_foreign_range(xc_handle, domid, PAGE_SIZE,
+ PROT_READ|PROT_WRITE,
+ page_array[0]);
+
+ fprintf(logfile, "shared page at pfn:%lx, mfn: %l016x\n",
+ IO_PAGE_START >> PAGE_SHIFT, page_array[0]);
+#endif
#else /* !CONFIG_DM */
#ifdef CONFIG_SOFTMMU
[-- Attachment #3: Type: text/plain, Size: 138 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH][QEMU] Add IA64-specific code for new qemu.
2006-07-25 2:09 [PATCH][QEMU] Add IA64-specific code for new qemu Zhang, Xiantao
@ 2006-07-26 11:24 ` Akio Takebe
2006-07-26 12:41 ` Re: [Xen-ia64-devel] " Christian Limpach
2006-07-26 12:41 ` Christian Limpach
1 sibling, 1 reply; 7+ messages in thread
From: Akio Takebe @ 2006-07-26 11:24 UTC (permalink / raw)
To: Zhang, Xiantao, xen-devel; +Cc: xen-ia64-devel
Hi, Xiantao
Is the following testandset redefine?
diff -r bbabdebc54ad tools/ioemu/exec-all.h
--- a/tools/ioemu/exec-all.h Wed Jul 19 21:13:36 2006 +0100
+++ b/tools/ioemu/exec-all.h Tue Jul 25 09:30:05 2006 +0800
@@ -391,6 +391,15 @@ static inline int testandset (int *p)
}
#endif
+#ifdef __ia64__
+#include "ia64_intrinsic.h"
+static inline int testandset (int *p)
+{
+ uint32_t o = 0, n = 1;
+ return (int)cmpxchg_acq(p, o, n);
+}
+#endif
+
#ifdef __s390__
static inline int testandset (int *p)
{
Best Regards,
Akio Takebe
>This patch adds the ia64-specific code for new Qemu .
>In addition, some ia64 patches aren't checked into xen-unstable.hg, so I
>reversed the related logic temporarily. Once sync with
>xen-ia64-unstable.hg, the logic will regain automatically.
>Thanks & Best Regards
>-Xiantao
>
>OTC,Intel Corporation
>
>
>-------------------------------text/plain-------------------------------
>_______________________________________________
>Xen-ia64-devel mailing list
>Xen-ia64-devel@lists.xensource.com
>http://lists.xensource.com/xen-ia64-devel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH][QEMU] Add IA64-specific code for new qemu.
2006-07-25 2:09 [PATCH][QEMU] Add IA64-specific code for new qemu Zhang, Xiantao
2006-07-26 11:24 ` Akio Takebe
@ 2006-07-26 12:41 ` Christian Limpach
1 sibling, 0 replies; 7+ messages in thread
From: Christian Limpach @ 2006-07-26 12:41 UTC (permalink / raw)
To: Zhang, Xiantao; +Cc: xen-devel, xen-ia64-devel
On 7/25/06, Zhang, Xiantao <xiantao.zhang@intel.com> wrote:
> This patch adds the ia64-specific code for new Qemu .
> In addition, some ia64 patches aren't checked into xen-unstable.hg, so I
> reversed the related logic temporarily. Once sync with
> xen-ia64-unstable.hg, the logic will regain automatically.
> Thanks & Best Regards
> -Xiantao
>
> OTC,Intel Corporation
Applied, thanks!
christian
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Re: [Xen-ia64-devel] [PATCH][QEMU] Add IA64-specific code for new qemu.
2006-07-26 11:24 ` Akio Takebe
@ 2006-07-26 12:41 ` Christian Limpach
2006-07-26 17:20 ` Alex Williamson
0 siblings, 1 reply; 7+ messages in thread
From: Christian Limpach @ 2006-07-26 12:41 UTC (permalink / raw)
To: Akio Takebe; +Cc: xen-devel, Zhang, Xiantao, xen-ia64-devel
On 7/26/06, Akio Takebe <takebe_akio@jp.fujitsu.com> wrote:
> Hi, Xiantao
>
> Is the following testandset redefine?
>
> diff -r bbabdebc54ad tools/ioemu/exec-all.h
> --- a/tools/ioemu/exec-all.h Wed Jul 19 21:13:36 2006 +0100
> +++ b/tools/ioemu/exec-all.h Tue Jul 25 09:30:05 2006 +0800
> @@ -391,6 +391,15 @@ static inline int testandset (int *p)
> }
> #endif
>
> +#ifdef __ia64__
> +#include "ia64_intrinsic.h"
> +static inline int testandset (int *p)
> +{
> + uint32_t o = 0, n = 1;
> + return (int)cmpxchg_acq(p, o, n);
> +}
> +#endif
> +
> #ifdef __s390__
> static inline int testandset (int *p)
> {
I've merged it with the existing __ia64 case.
christian
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Re: [Xen-ia64-devel] [PATCH][QEMU] Add IA64-specific code for new qemu.
2006-07-26 12:41 ` Re: [Xen-ia64-devel] " Christian Limpach
@ 2006-07-26 17:20 ` Alex Williamson
2006-07-26 18:34 ` Alex Williamson
2006-07-26 20:14 ` Christian Limpach
0 siblings, 2 replies; 7+ messages in thread
From: Alex Williamson @ 2006-07-26 17:20 UTC (permalink / raw)
To: Christian.Limpach; +Cc: xen-devel, Akio Takebe, Zhang, Xiantao, xen-ia64-devel
On Wed, 2006-07-26 at 13:41 +0100, Christian Limpach wrote:
> On 7/26/06, Akio Takebe <takebe_akio@jp.fujitsu.com> wrote:
> > Hi, Xiantao
> >
> > Is the following testandset redefine?
> >
> > diff -r bbabdebc54ad tools/ioemu/exec-all.h
> > --- a/tools/ioemu/exec-all.h Wed Jul 19 21:13:36 2006 +0100
> > +++ b/tools/ioemu/exec-all.h Tue Jul 25 09:30:05 2006 +0800
> > @@ -391,6 +391,15 @@ static inline int testandset (int *p)
> > }
> > #endif
> >
> > +#ifdef __ia64__
> > +#include "ia64_intrinsic.h"
> > +static inline int testandset (int *p)
>
> I've merged it with the existing __ia64 case.
Hi Christian,
Looks like we still ended up with both copies. Can you please apply
the patch below. Thanks,
Signed-off-by: Alex Williamson <alex.williamson@hp.com>
---
diff -r 21918b22746e tools/ioemu/exec-all.h
--- a/tools/ioemu/exec-all.h Wed Jul 26 10:49:32 2006 -0600
+++ b/tools/ioemu/exec-all.h Wed Jul 26 11:16:28 2006 -0600
@@ -391,15 +391,6 @@ static inline int testandset (int *p)
}
#endif
-#ifdef __ia64__
-#include "ia64_intrinsic.h"
-static inline int testandset (int *p)
-{
- uint32_t o = 0, n = 1;
- return (int)cmpxchg_acq(p, o, n);
-}
-#endif
-
#ifdef __s390__
static inline int testandset (int *p)
{
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Re: [Xen-ia64-devel] [PATCH][QEMU] Add IA64-specific code for new qemu.
2006-07-26 17:20 ` Alex Williamson
@ 2006-07-26 18:34 ` Alex Williamson
2006-07-26 20:14 ` Christian Limpach
1 sibling, 0 replies; 7+ messages in thread
From: Alex Williamson @ 2006-07-26 18:34 UTC (permalink / raw)
To: Christian.Limpach; +Cc: xen-devel, xen-ia64-devel
On Wed, 2006-07-26 at 11:20 -0600, Alex Williamson wrote:
> Looks like we still ended up with both copies. Can you please apply
> the patch below. Thanks,
Testing my quilt-foo based on your previous description, here's a
patch that should do the whole thing. Thanks,
Alex
Signed-off-by: Alex Williamson <alex.williamson@hp.com>
---
diff -r 21918b22746e tools/ioemu/exec-all.h
--- a/tools/ioemu/exec-all.h Wed Jul 26 10:49:32 2006 -0600
+++ b/tools/ioemu/exec-all.h Wed Jul 26 12:30:21 2006 -0600
@@ -391,15 +391,6 @@ static inline int testandset (int *p)
}
#endif
-#ifdef __ia64__
-#include "ia64_intrinsic.h"
-static inline int testandset (int *p)
-{
- uint32_t o = 0, n = 1;
- return (int)cmpxchg_acq(p, o, n);
-}
-#endif
-
#ifdef __s390__
static inline int testandset (int *p)
{
diff -r 21918b22746e tools/ioemu/patches/ioemu-ia64
--- a/tools/ioemu/patches/ioemu-ia64 Wed Jul 26 10:49:32 2006 -0600
+++ b/tools/ioemu/patches/ioemu-ia64 Wed Jul 26 12:30:21 2006 -0600
@@ -1,7 +1,7 @@ Index: ioemu/hw/iommu.c
Index: ioemu/hw/iommu.c
===================================================================
---- ioemu.orig/hw/iommu.c 2006-07-14 13:43:45.000000000 +0100
-+++ ioemu/hw/iommu.c 2006-07-26 13:34:50.039997837 +0100
+--- ioemu.orig/hw/iommu.c 2006-07-26 12:17:13.000000000 -0600
++++ ioemu/hw/iommu.c 2006-07-26 12:17:53.000000000 -0600
@@ -82,7 +82,11 @@
#define IOPTE_VALID 0x00000002 /* IOPTE is valid */
#define IOPTE_WAZ 0x00000001 /* Write as zeros */
@@ -16,8 +16,8 @@ Index: ioemu/hw/iommu.c
Index: ioemu/cpu-all.h
===================================================================
---- ioemu.orig/cpu-all.h 2006-07-26 13:33:45.946834283 +0100
-+++ ioemu/cpu-all.h 2006-07-26 13:34:50.038997944 +0100
+--- ioemu.orig/cpu-all.h 2006-07-26 12:17:53.000000000 -0600
++++ ioemu/cpu-all.h 2006-07-26 12:17:53.000000000 -0600
@@ -835,6 +835,31 @@
:"=m" (*(volatile long *)addr)
:"dIr" (nr));
@@ -52,8 +52,8 @@ Index: ioemu/cpu-all.h
/* memory API */
Index: ioemu/vl.c
===================================================================
---- ioemu.orig/vl.c 2006-07-26 13:33:45.996828953 +0100
-+++ ioemu/vl.c 2006-07-26 13:34:50.044997304 +0100
+--- ioemu.orig/vl.c 2006-07-26 12:17:53.000000000 -0600
++++ ioemu/vl.c 2006-07-26 12:26:38.000000000 -0600
@@ -5577,6 +5577,7 @@
exit(-1);
}
@@ -99,8 +99,8 @@ Index: ioemu/vl.c
#ifdef CONFIG_SOFTMMU
Index: ioemu/target-i386-dm/exec-dm.c
===================================================================
---- ioemu.orig/target-i386-dm/exec-dm.c 2006-07-26 13:33:45.882841107 +0100
-+++ ioemu/target-i386-dm/exec-dm.c 2006-07-26 13:34:50.040997731 +0100
+--- ioemu.orig/target-i386-dm/exec-dm.c 2006-07-26 12:17:53.000000000 -0600
++++ ioemu/target-i386-dm/exec-dm.c 2006-07-26 12:17:53.000000000 -0600
@@ -340,6 +340,23 @@
return io_mem_read[io_index >> IO_MEM_SHIFT];
}
@@ -137,25 +137,9 @@ Index: ioemu/target-i386-dm/exec-dm.c
len -= l;
Index: ioemu/exec-all.h
===================================================================
---- ioemu.orig/exec-all.h 2006-07-26 13:33:45.861843346 +0100
-+++ ioemu/exec-all.h 2006-07-26 13:38:30.096491388 +0100
-@@ -391,6 +391,15 @@
- }
- #endif
-
-+#ifdef __ia64__
-+#include "ia64_intrinsic.h"
-+static inline int testandset (int *p)
-+{
-+ uint32_t o = 0, n = 1;
-+ return (int)cmpxchg_acq(p, o, n);
-+}
-+#endif
-+
- #ifdef __s390__
- static inline int testandset (int *p)
- {
-@@ -462,12 +471,13 @@
+--- ioemu.orig/exec-all.h 2006-07-26 12:17:53.000000000 -0600
++++ ioemu/exec-all.h 2006-07-26 12:26:59.000000000 -0600
+@@ -462,12 +462,13 @@
}
#endif
@@ -174,8 +158,8 @@ Index: ioemu/exec-all.h
Index: ioemu/target-i386-dm/cpu.h
===================================================================
---- ioemu.orig/target-i386-dm/cpu.h 2006-07-26 13:33:45.882841107 +0100
-+++ ioemu/target-i386-dm/cpu.h 2006-07-26 13:34:50.040997731 +0100
+--- ioemu.orig/target-i386-dm/cpu.h 2006-07-26 12:17:53.000000000 -0600
++++ ioemu/target-i386-dm/cpu.h 2006-07-26 12:17:53.000000000 -0600
@@ -80,7 +80,11 @@
/* helper2.c */
int main_loop(void);
@@ -191,7 +175,7 @@ Index: ioemu/ia64_intrinsic.h
Index: ioemu/ia64_intrinsic.h
===================================================================
--- /dev/null 1970-01-01 00:00:00.000000000 +0000
-+++ ioemu/ia64_intrinsic.h 2006-07-26 13:34:50.038997944 +0100
++++ ioemu/ia64_intrinsic.h 2006-07-26 12:17:53.000000000 -0600
@@ -0,0 +1,276 @@
+#ifndef IA64_INTRINSIC_H
+#define IA64_INTRINSIC_H
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Re: [Xen-ia64-devel] [PATCH][QEMU] Add IA64-specific code for new qemu.
2006-07-26 17:20 ` Alex Williamson
2006-07-26 18:34 ` Alex Williamson
@ 2006-07-26 20:14 ` Christian Limpach
1 sibling, 0 replies; 7+ messages in thread
From: Christian Limpach @ 2006-07-26 20:14 UTC (permalink / raw)
To: Alex Williamson; +Cc: xen-devel, Akio Takebe, Zhang, Xiantao, xen-ia64-devel
On 7/26/06, Alex Williamson <alex.williamson@hp.com> wrote:
> On Wed, 2006-07-26 at 13:41 +0100, Christian Limpach wrote:
> > On 7/26/06, Akio Takebe <takebe_akio@jp.fujitsu.com> wrote:
> > > Hi, Xiantao
> > >
> > > Is the following testandset redefine?
> > >
> > > diff -r bbabdebc54ad tools/ioemu/exec-all.h
> > > --- a/tools/ioemu/exec-all.h Wed Jul 19 21:13:36 2006 +0100
> > > +++ b/tools/ioemu/exec-all.h Tue Jul 25 09:30:05 2006 +0800
> > > @@ -391,6 +391,15 @@ static inline int testandset (int *p)
> > > }
> > > #endif
> > >
> > > +#ifdef __ia64__
> > > +#include "ia64_intrinsic.h"
> > > +static inline int testandset (int *p)
> >
> > I've merged it with the existing __ia64 case.
>
> Hi Christian,
>
> Looks like we still ended up with both copies. Can you please apply
> the patch below. Thanks,
Oops yeah, looks like I forgot to remove the added copy after changing
the other one to match.
christian
>
> Signed-off-by: Alex Williamson <alex.williamson@hp.com>
> ---
>
> diff -r 21918b22746e tools/ioemu/exec-all.h
> --- a/tools/ioemu/exec-all.h Wed Jul 26 10:49:32 2006 -0600
> +++ b/tools/ioemu/exec-all.h Wed Jul 26 11:16:28 2006 -0600
> @@ -391,15 +391,6 @@ static inline int testandset (int *p)
> }
> #endif
>
> -#ifdef __ia64__
> -#include "ia64_intrinsic.h"
> -static inline int testandset (int *p)
> -{
> - uint32_t o = 0, n = 1;
> - return (int)cmpxchg_acq(p, o, n);
> -}
> -#endif
> -
> #ifdef __s390__
> static inline int testandset (int *p)
> {
>
>
>
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2006-07-26 20:14 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-07-25 2:09 [PATCH][QEMU] Add IA64-specific code for new qemu Zhang, Xiantao
2006-07-26 11:24 ` Akio Takebe
2006-07-26 12:41 ` Re: [Xen-ia64-devel] " Christian Limpach
2006-07-26 17:20 ` Alex Williamson
2006-07-26 18:34 ` Alex Williamson
2006-07-26 20:14 ` Christian Limpach
2006-07-26 12:41 ` Christian Limpach
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.