From: Rusty Russell <rusty@rustcorp.com.au>
To: Andi Kleen <ak@suse.de>
Cc: Andrew Morton <akpm@osdl.org>,
Xen-devel <xen-devel@lists.xensource.com>,
virtualization@lists.osdl.org,
Linux Kernel <linux-kernel@vger.kernel.org>,
Chris Wright <chrisw@sous-sol.org>,
Ian Pratt <ian.pratt@xensource.com>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Christoph Lameter <clameter@sgi.com>
Subject: Re: [Xen-devel] Re: [PATCH 8 of 13] Add a bootparameter to reserve high linear address space for hypervisors
Date: Wed, 02 Aug 2006 15:20:57 +1000 [thread overview]
Message-ID: <1154496058.2570.57.camel@localhost.localdomain> (raw)
In-Reply-To: <200608020636.58133.ak@suse.de>
On Wed, 2006-08-02 at 06:36 +0200, Andi Kleen wrote:
> Please just make a proper patch - either add a call to it to all setup_archs,
> or add a call to before setup_arch in init/main.c. While such ifdefs
> for specific architecture hacks are more popular lately it doesn't mean they are a good idea.
It's been around for two years, but if you fix x86_64 to use
early_param(), and I'll patch the other setup_archs to call
parse_early_param and remove the init/main.c call 8)
> I hope there aren't any existing architectures that use it in the middle
> of setup_arch or rely on it being after setup_arch.
setup_arch is responsible for grabbing the command line, so that has to
happen first. Even on x86, functions later in setup_arch rely on
cmdline parsing having happened. So for the moment setup_arch has to
call parse_early_param.
Maybe one day we can create a new "char *arch_get_cmdline()", implement
that everywhere, then call it and parse_early_param from core code. But
baby steps...
Rusty.
--
Help! Save Australia from the worst of the DMCA: http://linux.org.au/law
WARNING: multiple messages have this Message-ID (diff)
From: Rusty Russell <rusty@rustcorp.com.au>
To: Andi Kleen <ak@suse.de>
Cc: Andrew Morton <akpm@osdl.org>,
Xen-devel <xen-devel@lists.xensource.com>,
Ian Pratt <ian.pratt@xensource.com>,
Linux Kernel <linux-kernel@vger.kernel.org>,
Chris Wright <chrisw@sous-sol.org>,
virtualization@lists.osdl.org,
"Eric W. Biederman" <ebiederm@xmission.com>,
Christoph Lameter <clameter@sgi.com>
Subject: Re: Re: [PATCH 8 of 13] Add a bootparameter to reserve high linear address space for hypervisors
Date: Wed, 02 Aug 2006 15:20:57 +1000 [thread overview]
Message-ID: <1154496058.2570.57.camel@localhost.localdomain> (raw)
In-Reply-To: <200608020636.58133.ak@suse.de>
On Wed, 2006-08-02 at 06:36 +0200, Andi Kleen wrote:
> Please just make a proper patch - either add a call to it to all setup_archs,
> or add a call to before setup_arch in init/main.c. While such ifdefs
> for specific architecture hacks are more popular lately it doesn't mean they are a good idea.
It's been around for two years, but if you fix x86_64 to use
early_param(), and I'll patch the other setup_archs to call
parse_early_param and remove the init/main.c call 8)
> I hope there aren't any existing architectures that use it in the middle
> of setup_arch or rely on it being after setup_arch.
setup_arch is responsible for grabbing the command line, so that has to
happen first. Even on x86, functions later in setup_arch rely on
cmdline parsing having happened. So for the moment setup_arch has to
call parse_early_param.
Maybe one day we can create a new "char *arch_get_cmdline()", implement
that everywhere, then call it and parse_early_param from core code. But
baby steps...
Rusty.
--
Help! Save Australia from the worst of the DMCA: http://linux.org.au/law
next prev parent reply other threads:[~2006-08-02 5:21 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-01 20:00 [PATCH 0 of 13] Basic infrastructure patches for a paravirtualized kernel Jeremy Fitzhardinge
2006-08-01 20:00 ` [PATCH 1 of 13] Add apply_to_page_range() which applies a function to a pte range Jeremy Fitzhardinge
2006-08-01 20:00 ` [PATCH 2 of 13] Remove locally-defined ldt structure in favour of standard type Jeremy Fitzhardinge
2006-08-01 20:00 ` [PATCH 3 of 13] Implement always-locked bit ops, for memory shared with an SMP hypervisor Jeremy Fitzhardinge
2006-08-01 20:00 ` [PATCH 4 of 13] Allow a kernel to not be in ring 0 Jeremy Fitzhardinge
2006-08-01 20:00 ` [PATCH 5 of 13] Replace sensitive instructions with macros Jeremy Fitzhardinge
2006-08-01 20:00 ` [PATCH 6 of 13] Roll all the cpuid asm into one __cpuid call Jeremy Fitzhardinge
2006-08-01 20:00 ` [PATCH 7 of 13] Make __FIXADDR_TOP variable to allow it to make space for a hypervisor Jeremy Fitzhardinge
2006-08-01 20:00 ` [PATCH 8 of 13] Add a bootparameter to reserve high linear address space for hypervisors Jeremy Fitzhardinge
2006-08-01 21:47 ` Andi Kleen
2006-08-01 21:47 ` Andi Kleen
2006-08-02 0:48 ` Rusty Russell
2006-08-02 2:59 ` Andi Kleen
2006-08-02 2:59 ` Andi Kleen
2006-08-02 3:54 ` [Xen-devel] " Rusty Russell
2006-08-02 3:54 ` Rusty Russell
2006-08-02 4:21 ` [Xen-devel] " Andi Kleen
2006-08-02 4:33 ` Rusty Russell
2006-08-02 4:33 ` Rusty Russell
2006-08-02 4:36 ` [Xen-devel] " Andi Kleen
2006-08-02 4:36 ` Andi Kleen
2006-08-02 5:20 ` Rusty Russell [this message]
2006-08-02 5:20 ` Rusty Russell
2006-08-02 5:24 ` [Xen-devel] " Andi Kleen
2006-08-02 5:24 ` Andi Kleen
2006-08-02 9:06 ` [PATCH 1/2] Allow early_param and identical __setup to exist Rusty Russell
2006-08-02 9:06 ` Rusty Russell
2006-08-02 9:08 ` [PATCH 2/2] Replace i386 open-coded cmdline parsing with early_param/parse_early_param Rusty Russell
2006-08-02 9:08 ` Rusty Russell
2006-08-02 9:24 ` Andi Kleen
2006-08-01 20:00 ` [PATCH 9 of 13] Remove the read hazard from the COW path in copy_one_pte Jeremy Fitzhardinge
2006-08-01 20:00 ` [PATCH 10 of 13] Change pte_clear_full to a more appropriately named pte_clear_not_present, Jeremy Fitzhardinge
2006-08-01 21:48 ` Andi Kleen
2006-08-01 20:00 ` [PATCH 11 of 13] Implement lazy MMU update hooks which are SMP safe for both direct and Jeremy Fitzhardinge
2006-08-01 20:00 ` [PATCH 12 of 13] Pass the mm struct into the pgd_free code so the mm is available here Jeremy Fitzhardinge
2006-08-02 3:14 ` Andi Kleen
2006-08-02 3:14 ` Andi Kleen
2006-08-02 6:25 ` [Xen-devel] " Zachary Amsden
2006-08-02 7:13 ` Chris Wright
2006-08-02 7:13 ` Chris Wright
2006-08-01 20:00 ` [PATCH 13 of 13] Put .note.* sections into a PT_NOTE segment in vmlinux Jeremy Fitzhardinge
2006-08-22 11:14 ` [PATCH 1 of 1] x86_43: " Ian Campbell
2006-08-22 11:14 ` Ian Campbell
2006-08-22 11:33 ` Andi Kleen
2006-08-22 11:33 ` Andi Kleen
2006-08-22 11:43 ` Ian Campbell
2006-08-22 11:43 ` Ian Campbell
2006-08-02 3:18 ` [PATCH 0 of 13] Basic infrastructure patches for a paravirtualized kernel Andi Kleen
2006-08-02 3:18 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1154496058.2570.57.camel@localhost.localdomain \
--to=rusty@rustcorp.com.au \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=chrisw@sous-sol.org \
--cc=clameter@sgi.com \
--cc=ebiederm@xmission.com \
--cc=ian.pratt@xensource.com \
--cc=linux-kernel@vger.kernel.org \
--cc=virtualization@lists.osdl.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.