Is as_ops.c releasepage patch still needed?

Is as_ops.c releasepage patch still needed?

[Jonathan Briggs]

[-- Attachment #1: Type: text/plain, Size: 1077 bytes --]

The following patch was posted to the Reiser4 list August 3 by zam.  Is
it still needed?  It solved many problems for me, making my systems able
to actually complete full Beagle indexing.

But I have not seen this patch show up in the last two mm kernel
releases.  Did something else fix it or is this patch still needed?


Index: linux-2.6-git/fs/reiser4/as_ops.c
===================================================================
--- linux-2.6-git.orig/fs/reiser4/as_ops.c
+++ linux-2.6-git/fs/reiser4/as_ops.c
@@ -350,6 +350,11 @@ int reiser4_releasepage(struct page *pag
        if (PageDirty(page))
                return 0;

+       /* extra page reference is used by reiser4 to protect
+        * jnode<->page link from this ->releasepage(). */
+       if (page_count(page) > 3)
+               return 0;
+
        /* releasable() needs jnode lock, because it looks at the jnode fields
         * and we need jload_lock here to avoid races with jload(). */
        spin_lock_jnode(node);

-- 
Jonathan Briggs <jbriggs@esoft.com>
eSoft, Inc.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

Re: Is as_ops.c releasepage patch still needed?

[Alexander Zarochentsev]

Hi,

On 21 August 2006 22:49, Jonathan Briggs wrote:
> The following patch was posted to the Reiser4 list August 3 by zam. 
> Is it still needed?  It solved many problems for me, making my
> systems able to actually complete full Beagle indexing.

the patch submitted already and will be included into the next -mm 
kernel (after 2.6.18-rc4-mm3).

>
> But I have not seen this patch show up in the last two mm kernel
> releases.  Did something else fix it or is this patch still needed?
>
>
> Index: linux-2.6-git/fs/reiser4/as_ops.c
> ===================================================================
> --- linux-2.6-git.orig/fs/reiser4/as_ops.c
> +++ linux-2.6-git/fs/reiser4/as_ops.c
> @@ -350,6 +350,11 @@ int reiser4_releasepage(struct page *pag
>         if (PageDirty(page))
>                 return 0;
>
> +       /* extra page reference is used by reiser4 to protect
> +        * jnode<->page link from this ->releasepage(). */
> +       if (page_count(page) > 3)
> +               return 0;
> +
>         /* releasable() needs jnode lock, because it looks at the
> jnode fields * and we need jload_lock here to avoid races with
> jload(). */ spin_lock_jnode(node);

-- 
Alex.