* [PATCH] gitweb: all bold lists are "list_bold" style
@ 2006-08-22 8:57 Luben Tuikov
2006-08-22 9:30 ` Jakub Narebski
2006-08-22 10:38 ` [PATCH] gitweb: Replace some presentational HTML by CSS Jakub Narebski
0 siblings, 2 replies; 3+ messages in thread
From: Luben Tuikov @ 2006-08-22 8:57 UTC (permalink / raw)
To: git
[-- Attachment #1: Type: text/plain, Size: 140 bytes --]
Signed-off-by: Luben Tuikov <ltuikov@yahoo.com>
---
gitweb/gitweb.perl | 10 +++++-----
1 files changed, 5 insertions(+), 5 deletions(-)
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 1207600725-p1.txt --]
[-- Type: text/inline; name="p1.txt", Size: 2475 bytes --]
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 5237f25..4caf69e 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -1583,7 +1583,7 @@ sub git_tags_body {
print "<td><i>$tag{'age'}</i></td>\n" .
"<td>" .
$cgi->a({-href => href(action=>$tag{'reftype'}, hash=>$tag{'refid'}),
- -class => "list"}, "<b>" . esc_html($tag{'name'}) . "</b>") .
+ -class => "list_bold"}, esc_html($tag{'name'})) .
"</td>\n" .
"<td>";
if (defined $comment) {
@@ -1637,7 +1637,7 @@ sub git_heads_body {
print "<td><i>$tag{'age'}</i></td>\n" .
($tag{'id'} eq $head ? "<td class=\"current_head\">" : "<td>") .
$cgi->a({-href => href(action=>"shortlog", hash=>$tag{'name'}),
- -class => "list"}, "<b>" . esc_html($tag{'name'}) . "</b>") .
+ -class => "list_bold"}, esc_html($tag{'name'})) .
"</td>\n" .
"<td class=\"link\">" .
$cgi->a({-href => href(action=>"shortlog", hash=>$tag{'name'})}, "shortlog") . " | " .
@@ -2686,7 +2686,7 @@ sub git_search {
print "<td title=\"$co{'age_string_age'}\"><i>$co{'age_string_date'}</i></td>\n" .
"<td><i>" . esc_html(chop_str($co{'author_name'}, 15, 5)) . "</i></td>\n" .
"<td>" .
- $cgi->a({-href => href(action=>"commit", hash=>$co{'id'}) -class => "list"}, "<b>" . esc_html(chop_str($co{'title'}, 50)) . "</b><br/>");
+ $cgi->a({-href => href(action=>"commit", hash=>$co{'id'}) -class => "list_bold"}, esc_html(chop_str($co{'title'}, 50)) . "<br/>");
my $comment = $co{'comment'};
foreach my $line (@$comment) {
if ($line =~ m/^(.*)($searchtext)(.*)$/i) {
@@ -2739,8 +2739,8 @@ sub git_search {
print "<td title=\"$co{'age_string_age'}\"><i>$co{'age_string_date'}</i></td>\n" .
"<td><i>" . esc_html(chop_str($co{'author_name'}, 15, 5)) . "</i></td>\n" .
"<td>" .
- $cgi->a({-href => href(action=>"commit", hash=>$co{'id'}), -class => "list"}, "<b>" .
- esc_html(chop_str($co{'title'}, 50)) . "</b><br/>");
+ $cgi->a({-href => href(action=>"commit", hash=>$co{'id'}), -class => "list_bold"},
+ esc_html(chop_str($co{'title'}, 50)) . "<br/>");
while (my $setref = shift @files) {
my %set = %$setref;
print $cgi->a({-href => href(action=>"blob", hash=>$set{'id'}, hash_base=>$co{'id'}, file_name=>$set{'file'}), class => "list"},
--
1.4.2.g3851f
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] gitweb: all bold lists are "list_bold" style
2006-08-22 8:57 [PATCH] gitweb: all bold lists are "list_bold" style Luben Tuikov
@ 2006-08-22 9:30 ` Jakub Narebski
2006-08-22 10:38 ` [PATCH] gitweb: Replace some presentational HTML by CSS Jakub Narebski
1 sibling, 0 replies; 3+ messages in thread
From: Jakub Narebski @ 2006-08-22 9:30 UTC (permalink / raw)
To: git
This should be reply to
[PATCH] gitweb: bugfix: list regression
(or at least it should be mentioned that this patch is needed).
--
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] gitweb: Replace some presentational HTML by CSS
2006-08-22 8:57 [PATCH] gitweb: all bold lists are "list_bold" style Luben Tuikov
2006-08-22 9:30 ` Jakub Narebski
@ 2006-08-22 10:38 ` Jakub Narebski
1 sibling, 0 replies; 3+ messages in thread
From: Jakub Narebski @ 2006-08-22 10:38 UTC (permalink / raw)
To: git; +Cc: Luben Tuikov, Junio C Hamano, Jakub Narebski
From: Jakub Narebski <jnareb@gmail.com>
Signed-off-by: Jakub Narebski <jnareb@gmail.com>
---
Follows "gitweb: bugfix: a.list formatting regression" patch.
gitweb/gitweb.css | 3 ++-
gitweb/gitweb.perl | 19 ++++++++++---------
2 files changed, 12 insertions(+), 10 deletions(-)
diff --git a/gitweb/gitweb.css b/gitweb/gitweb.css
index 6c13d9e..4821022 100644
--- a/gitweb/gitweb.css
+++ b/gitweb/gitweb.css
@@ -42,6 +42,7 @@ div.page_nav a:visited {
div.page_path {
padding: 8px;
+ font-weight: bold;
border: solid #d9d8d1;
border-width: 0px 0px 1px;
}
@@ -120,7 +121,7 @@ a.list {
color: #000000;
}
-a.subject {
+a.subject, a.name {
font-weight: bold;
}
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 40c5177..607b8b7 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -1267,17 +1267,17 @@ sub git_print_page_path {
my $hb = shift;
if (!defined $name) {
- print "<div class=\"page_path\"><b>/</b></div>\n";
+ print "<div class=\"page_path\">/</div>\n";
} elsif (defined $type && $type eq 'blob') {
- print "<div class=\"page_path\"><b>";
+ print "<div class=\"page_path\">";
if (defined $hb) {
print $cgi->a({-href => href(action=>"blob_plain", hash_base=>$hb, file_name=>$file_name)}, esc_html($name));
} else {
print $cgi->a({-href => href(action=>"blob_plain", file_name=>$file_name)}, esc_html($name));
}
- print "</b><br/></div>\n";
+ print "<br/></div>\n";
} else {
- print "<div class=\"page_path\"><b>" . esc_html($name) . "</b><br/></div>\n";
+ print "<div class=\"page_path\">" . esc_html($name) . "<br/></div>\n";
}
}
@@ -1630,7 +1630,7 @@ sub git_tags_body {
print "<td><i>$tag{'age'}</i></td>\n" .
"<td>" .
$cgi->a({-href => href(action=>$tag{'reftype'}, hash=>$tag{'refid'}),
- -class => "list"}, "<b>" . esc_html($tag{'name'}) . "</b>") .
+ -class => "list name"}, esc_html($tag{'name'})) .
"</td>\n" .
"<td>";
if (defined $comment) {
@@ -1684,7 +1684,7 @@ sub git_heads_body {
print "<td><i>$tag{'age'}</i></td>\n" .
($tag{'id'} eq $head ? "<td class=\"current_head\">" : "<td>") .
$cgi->a({-href => href(action=>"shortlog", hash=>$tag{'name'}),
- -class => "list"}, "<b>" . esc_html($tag{'name'}) . "</b>") .
+ -class => "list name"},esc_html($tag{'name'})) .
"</td>\n" .
"<td class=\"link\">" .
$cgi->a({-href => href(action=>"shortlog", hash=>$tag{'name'})}, "shortlog") . " | " .
@@ -2774,7 +2774,8 @@ sub git_search {
print "<td title=\"$co{'age_string_age'}\"><i>$co{'age_string_date'}</i></td>\n" .
"<td><i>" . esc_html(chop_str($co{'author_name'}, 15, 5)) . "</i></td>\n" .
"<td>" .
- $cgi->a({-href => href(action=>"commit", hash=>$co{'id'}) -class => "list"}, "<b>" . esc_html(chop_str($co{'title'}, 50)) . "</b><br/>");
+ $cgi->a({-href => href(action=>"commit", hash=>$co{'id'}), -class => "list subject"},
+ esc_html(chop_str($co{'title'}, 50)) . "<br/>");
my $comment = $co{'comment'};
foreach my $line (@$comment) {
if ($line =~ m/^(.*)($searchtext)(.*)$/i) {
@@ -2827,8 +2828,8 @@ sub git_search {
print "<td title=\"$co{'age_string_age'}\"><i>$co{'age_string_date'}</i></td>\n" .
"<td><i>" . esc_html(chop_str($co{'author_name'}, 15, 5)) . "</i></td>\n" .
"<td>" .
- $cgi->a({-href => href(action=>"commit", hash=>$co{'id'}), -class => "list"}, "<b>" .
- esc_html(chop_str($co{'title'}, 50)) . "</b><br/>");
+ $cgi->a({-href => href(action=>"commit", hash=>$co{'id'}), -class => "list subject"},
+ esc_html(chop_str($co{'title'}, 50)) . "<br/>");
while (my $setref = shift @files) {
my %set = %$setref;
print $cgi->a({-href => href(action=>"blob", hash=>$set{'id'}, hash_base=>$co{'id'}, file_name=>$set{'file'}), class => "list"},
--
1.4.1.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2006-08-22 10:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-08-22 8:57 [PATCH] gitweb: all bold lists are "list_bold" style Luben Tuikov
2006-08-22 9:30 ` Jakub Narebski
2006-08-22 10:38 ` [PATCH] gitweb: Replace some presentational HTML by CSS Jakub Narebski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.