All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fernando Vazquez <fernando@oss.ntt.co.jp>
To: gregkh@suse.de
Cc: dev@openvz.org, xemul@openvz.org, davem@davemloft.net,
	linux-kernel@vger.kernel.org, stable@kernel.org, akpm@osdl.org,
	linux-ia64@vger.kernel.org, kamezawa.hiroyu@jp.fujitsu.com
Subject: [PATCH] Linux 2.6.17.11 - fix compilation error on IA64 (try #3)
Date: Fri, 25 Aug 2006 08:13:07 +0000	[thread overview]
Message-ID: <1156493587.2977.20.camel@localhost.localdomain> (raw)

Resending without Japanese characters in the mail header to avoid spam filters.
Sorry for the noise.

---

The commit 8833ebaa3f4325820fe3338ccf6fae04f6669254 introduced a change that broke 
IA64 compilation as shown below:

  gcc -Wp,-MD,arch/ia64/kernel/.entry.o.d  -nostdinc -isystem /usr/lib/gcc/ia64-linux-gnu/4.1.2/include -D__KERNEL__ -Iinclude  -include include/linux/autoconf.h -DHAVE_WORKING_TEXT_ALIGN -DHAVE_MODEL_SMALL_ATTRIBUTE -DHAVE_SERIALIZE_DIRECTIVE -D__ASSEMBLY__   -mconstant-gp -c -o arch/ia64/kernel/entry.o arch/ia64/kernel/entry.S
include/asm/mman.h: Assembler messages:
include/asm/mman.h:13: Error: Unknown opcode `int ia64_map_check_rgn(unsigned long addr,unsigned long len,'
include/asm/mman.h:14: Error: Unknown opcode `unsigned long flags)'
make[1]: *** [arch/ia64/kernel/entry.o] Error 1
make: *** [arch/ia64/kernel] Error 2

The reason is that "asm/mman.h" is being included from entry.S indirectly through
"asm/pgtable.h" (see code snips below).

* arch/ia64/kernel/entry.S:
...
#include <asm/pgtable.h>
...

* include/asm-ia64/pgtable.h:
...
#include <asm/mman.h>
...

* include/asm-ia64/mman.h
...
#ifdef __KERNEL__
#define arch_mmap_check ia64_map_check_rgn
int ia64_map_check_rgn(unsigned long addr, unsigned long len,
                unsigned long flags);
#endif
...

Signed-off-by: Fernando Vazquez <fernando@intellilink.co.jp>
---

diff -urNp linux-2.6.17.11/include/asm-ia64/mman.h linux-2.6.17.11-fix/include/asm-ia64/mman.h
--- linux-2.6.17.11/include/asm-ia64/mman.h	2006-08-25 11:36:09.000000000 +0900
+++ linux-2.6.17.11-fix/include/asm-ia64/mman.h	2006-08-25 11:39:16.000000000 +0900
@@ -9,10 +9,12 @@
  */
 
 #ifdef __KERNEL__
+#ifndef __ASSEMBLY__
 #define arch_mmap_check	ia64_map_check_rgn
 int ia64_map_check_rgn(unsigned long addr, unsigned long len,
 		unsigned long flags);
 #endif
+#endif
 
 #include <asm-generic/mman.h>
 



WARNING: multiple messages have this Message-ID (diff)
From: Fernando Vazquez <fernando@oss.ntt.co.jp>
To: gregkh@suse.de
Cc: dev@openvz.org, xemul@openvz.org, davem@davemloft.net,
	linux-kernel@vger.kernel.org, stable@kernel.org, akpm@osdl.org,
	linux-ia64@vger.kernel.org, kamezawa.hiroyu@jp.fujitsu.com
Subject: [PATCH] Linux 2.6.17.11 - fix compilation error on IA64 (try #3)
Date: Fri, 25 Aug 2006 17:13:07 +0900	[thread overview]
Message-ID: <1156493587.2977.20.camel@localhost.localdomain> (raw)

Resending without Japanese characters in the mail header to avoid spam filters.
Sorry for the noise.

---

The commit 8833ebaa3f4325820fe3338ccf6fae04f6669254 introduced a change that broke 
IA64 compilation as shown below:

  gcc -Wp,-MD,arch/ia64/kernel/.entry.o.d  -nostdinc -isystem /usr/lib/gcc/ia64-linux-gnu/4.1.2/include -D__KERNEL__ -Iinclude  -include include/linux/autoconf.h -DHAVE_WORKING_TEXT_ALIGN -DHAVE_MODEL_SMALL_ATTRIBUTE -DHAVE_SERIALIZE_DIRECTIVE -D__ASSEMBLY__   -mconstant-gp -c -o arch/ia64/kernel/entry.o arch/ia64/kernel/entry.S
include/asm/mman.h: Assembler messages:
include/asm/mman.h:13: Error: Unknown opcode `int ia64_map_check_rgn(unsigned long addr,unsigned long len,'
include/asm/mman.h:14: Error: Unknown opcode `unsigned long flags)'
make[1]: *** [arch/ia64/kernel/entry.o] Error 1
make: *** [arch/ia64/kernel] Error 2

The reason is that "asm/mman.h" is being included from entry.S indirectly through
"asm/pgtable.h" (see code snips below).

* arch/ia64/kernel/entry.S:
...
#include <asm/pgtable.h>
...

* include/asm-ia64/pgtable.h:
...
#include <asm/mman.h>
...

* include/asm-ia64/mman.h
...
#ifdef __KERNEL__
#define arch_mmap_check ia64_map_check_rgn
int ia64_map_check_rgn(unsigned long addr, unsigned long len,
                unsigned long flags);
#endif
...

Signed-off-by: Fernando Vazquez <fernando@intellilink.co.jp>
---

diff -urNp linux-2.6.17.11/include/asm-ia64/mman.h linux-2.6.17.11-fix/include/asm-ia64/mman.h
--- linux-2.6.17.11/include/asm-ia64/mman.h	2006-08-25 11:36:09.000000000 +0900
+++ linux-2.6.17.11-fix/include/asm-ia64/mman.h	2006-08-25 11:39:16.000000000 +0900
@@ -9,10 +9,12 @@
  */
 
 #ifdef __KERNEL__
+#ifndef __ASSEMBLY__
 #define arch_mmap_check	ia64_map_check_rgn
 int ia64_map_check_rgn(unsigned long addr, unsigned long len,
 		unsigned long flags);
 #endif
+#endif
 
 #include <asm-generic/mman.h>
 



             reply	other threads:[~2006-08-25  8:13 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-08-25  8:13 Fernando Vazquez [this message]
2006-08-25  8:13 ` [PATCH] Linux 2.6.17.11 - fix compilation error on IA64 (try #3) Fernando Vazquez
2006-08-25 22:07 ` [stable] " Greg KH
2006-08-25 22:07   ` Greg KH
2006-08-28 22:11 ` Luck, Tony
2006-08-28 22:11   ` Luck, Tony
2006-08-29  1:31   ` [stable] " Greg KH
2006-08-29  1:31     ` Greg KH
2006-08-29 12:24     ` [stable] [PATCH] Linux 2.6.17.11 - fix compilation error on IA64 Kirill Korotaev
2006-08-29 12:24       ` [stable] [PATCH] Linux 2.6.17.11 - fix compilation error on IA64 (try #3) Kirill Korotaev
2006-08-29 16:08       ` Greg KH
2006-08-29 16:08         ` Greg KH
2006-09-04 10:10         ` [stable] [PATCH] Linux 2.6.17.11 - fix compilation error on 
2006-09-04 10:10           ` [stable] [PATCH] Linux 2.6.17.11 - fix compilation error on IA64 (try #3) Fernando Luis Vázquez Cao
2006-09-04 10:30           ` [stable] [PATCH] Linux 2.6.17.11 - fix compilation error on IA64 Kirill Korotaev
2006-09-04 10:30             ` [stable] [PATCH] Linux 2.6.17.11 - fix compilation error on IA64 (try #3) Kirill Korotaev
2006-08-29 12:24     ` [stable] [PATCH] Linux 2.6.17.11 - fix compilation error on IA64 Kirill Korotaev
2006-08-29 12:24       ` [stable] [PATCH] Linux 2.6.17.11 - fix compilation error on IA64 (try #3) Kirill Korotaev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1156493587.2977.20.camel@localhost.localdomain \
    --to=fernando@oss.ntt.co.jp \
    --cc=akpm@osdl.org \
    --cc=davem@davemloft.net \
    --cc=dev@openvz.org \
    --cc=gregkh@suse.de \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=linux-ia64@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stable@kernel.org \
    --cc=xemul@openvz.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.