From: Trond Myklebust <trond.myklebust@fys.uio.no>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Andrew Morton <akpm@osdl.org>, Rik van Riel <riel@redhat.com>
Subject: Re: [PATCH 7/6] Lost bits - fix PG_writeback vs PG_private race in NFS
Date: Fri, 25 Aug 2006 16:11:27 -0400 [thread overview]
Message-ID: <1156536687.5927.25.camel@localhost> (raw)
In-Reply-To: <1156523815.16027.43.camel@taijtu>
On Fri, 2006-08-25 at 18:36 +0200, Peter Zijlstra wrote:
> Make sure we clear PG_writeback after we clear PG_private, otherwise
> weird and wonderfull stuff will happen.
>
NACK.
Look carefully at the case of unstable writes: your patch does nothing
to guarantee that PG_writeback is cleared after PG_private for that
case.
Anyhow, you don't explain exactly what is wrong with clearing
PG_writeback before PG_private.
Cheers,
Trond
WARNING: multiple messages have this Message-ID (diff)
From: Trond Myklebust <trond.myklebust@fys.uio.no>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Andrew Morton <akpm@osdl.org>, Rik van Riel <riel@redhat.com>
Subject: Re: [PATCH 7/6] Lost bits - fix PG_writeback vs PG_private race in NFS
Date: Fri, 25 Aug 2006 16:11:27 -0400 [thread overview]
Message-ID: <1156536687.5927.25.camel@localhost> (raw)
In-Reply-To: <1156523815.16027.43.camel@taijtu>
On Fri, 2006-08-25 at 18:36 +0200, Peter Zijlstra wrote:
> Make sure we clear PG_writeback after we clear PG_private, otherwise
> weird and wonderfull stuff will happen.
>
NACK.
Look carefully at the case of unstable writes: your patch does nothing
to guarantee that PG_writeback is cleared after PG_private for that
case.
Anyhow, you don't explain exactly what is wrong with clearing
PG_writeback before PG_private.
Cheers,
Trond
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2006-08-25 20:11 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-25 15:37 [PATCH 0/6] Swap over NFS Peter Zijlstra
2006-08-25 15:37 ` Peter Zijlstra
2006-08-25 15:37 ` [PATCH 1/6] mm: Generic swap file support Peter Zijlstra
2006-08-25 15:37 ` Peter Zijlstra
2006-08-25 15:37 ` [PATCH 2/6] mm: New page_file_* methods Peter Zijlstra
2006-08-25 15:37 ` Peter Zijlstra
2006-08-25 15:37 ` [PATCH 3/6] uml: arch/um remove_mapping() clash Peter Zijlstra
2006-08-25 15:37 ` Peter Zijlstra
2006-08-29 20:20 ` Jeff Dike
2006-08-29 20:20 ` Jeff Dike
2006-08-25 15:37 ` [PATCH 4/6] nfs: Teach NFS about swap cache pages Peter Zijlstra
2006-08-25 15:37 ` Peter Zijlstra
2006-08-25 20:03 ` Trond Myklebust
2006-08-25 20:03 ` Trond Myklebust
2006-08-25 20:20 ` Peter Zijlstra
2006-08-25 20:20 ` Peter Zijlstra
2006-08-25 20:37 ` Trond Myklebust
2006-08-25 20:37 ` Trond Myklebust
2006-08-25 15:38 ` [PATCH 5/6] nfs: Add comment on PG_private use of NFS Peter Zijlstra
2006-08-25 15:38 ` Peter Zijlstra
2006-08-25 15:38 ` [PATCH 6/6] nfs: Enable swap over NFS Peter Zijlstra
2006-08-25 15:38 ` Peter Zijlstra
2006-08-26 14:36 ` Pavel Machek
2006-08-26 14:36 ` Pavel Machek
2006-08-26 17:30 ` Peter Zijlstra
2006-08-26 17:30 ` Peter Zijlstra
2006-08-26 21:54 ` Rik van Riel
2006-08-26 21:54 ` Rik van Riel
2006-08-25 16:36 ` [PATCH 7/6] Lost bits - fix PG_writeback vs PG_private race in NFS Peter Zijlstra
2006-08-25 16:36 ` Peter Zijlstra
2006-08-25 20:11 ` Trond Myklebust [this message]
2006-08-25 20:11 ` Trond Myklebust
2006-08-25 20:44 ` Peter Zijlstra
2006-08-25 20:44 ` Peter Zijlstra
2006-08-25 21:19 ` Trond Myklebust
2006-08-25 21:19 ` Trond Myklebust
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1156536687.5927.25.camel@localhost \
--to=trond.myklebust@fys.uio.no \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.