From: Martin Schwidefsky <schwidefsky@de.ibm.com>
To: Dave Hansen <haveblue@us.ibm.com>
Cc: akpm@osdl.org, virtualization@lists.osdl.org,
frankeh@watson.ibm.com, rhim@cc.gateh.edu,
nickpiggin@yahoo.com.au, linux-kernel@vger.kernel.org
Subject: Re: [patch 8/9] Guest page hinting: discarded page list.
Date: Fri, 01 Sep 2006 17:40:19 +0200 [thread overview]
Message-ID: <1157125219.21733.24.camel@localhost> (raw)
In-Reply-To: <1157123836.28577.77.camel@localhost.localdomain>
On Fri, 2006-09-01 at 08:17 -0700, Dave Hansen wrote:
> > +#if defined(CONFIG_PAGE_DISCARD_LIST)
> > + if (page_host_discards() && unlikely(PageDiscarded(page))) {
> > + local_irq_disable();
> > + list_add_tail(&page->lru,
> > + &__get_cpu_var(page_discard_list));
> > + local_irq_enable();
> > + return;
> > + }
> > +#endif
>
> If PageDiscarded() was #ifdef'd in the header, you wouldn't need this in
> the .c file.
No, unfortunately not. There is a new variable page_discard_list that is
only defined if CONFG_PAGE_DISCARD_LIST is set. The compiler will
complain about the absence of the variable, even if the code is never
reached because PageDiscarded always returns 0.
--
blue skies,
Martin.
Martin Schwidefsky
Linux for zSeries Development & Services
IBM Deutschland Entwicklung GmbH
"Reality continues to ruin my life." - Calvin.
WARNING: multiple messages have this Message-ID (diff)
From: Martin Schwidefsky <schwidefsky@de.ibm.com>
To: Dave Hansen <haveblue@us.ibm.com>
Cc: linux-kernel@vger.kernel.org, virtualization@lists.osdl.org,
akpm@osdl.org, nickpiggin@yahoo.com.au, frankeh@watson.ibm.com,
rhim@cc.gateh.edu
Subject: Re: [patch 8/9] Guest page hinting: discarded page list.
Date: Fri, 01 Sep 2006 17:40:19 +0200 [thread overview]
Message-ID: <1157125219.21733.24.camel@localhost> (raw)
In-Reply-To: <1157123836.28577.77.camel@localhost.localdomain>
On Fri, 2006-09-01 at 08:17 -0700, Dave Hansen wrote:
> > +#if defined(CONFIG_PAGE_DISCARD_LIST)
> > + if (page_host_discards() && unlikely(PageDiscarded(page))) {
> > + local_irq_disable();
> > + list_add_tail(&page->lru,
> > + &__get_cpu_var(page_discard_list));
> > + local_irq_enable();
> > + return;
> > + }
> > +#endif
>
> If PageDiscarded() was #ifdef'd in the header, you wouldn't need this in
> the .c file.
No, unfortunately not. There is a new variable page_discard_list that is
only defined if CONFG_PAGE_DISCARD_LIST is set. The compiler will
complain about the absence of the variable, even if the code is never
reached because PageDiscarded always returns 0.
--
blue skies,
Martin.
Martin Schwidefsky
Linux for zSeries Development & Services
IBM Deutschland Entwicklung GmbH
"Reality continues to ruin my life." - Calvin.
next prev parent reply other threads:[~2006-09-01 15:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-01 11:11 [patch 8/9] Guest page hinting: discarded page list Martin Schwidefsky
2006-09-01 15:17 ` Dave Hansen
2006-09-01 15:17 ` Dave Hansen
2006-09-01 15:40 ` Martin Schwidefsky [this message]
2006-09-01 15:40 ` Martin Schwidefsky
2006-09-01 15:56 ` Dave Hansen
-- strict thread matches above, loose matches on Subject: below --
2006-08-24 14:31 Martin Schwidefsky, Martin Schwidefsky, Hubertus Franke, Himanshu Raj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1157125219.21733.24.camel@localhost \
--to=schwidefsky@de.ibm.com \
--cc=akpm@osdl.org \
--cc=frankeh@watson.ibm.com \
--cc=haveblue@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nickpiggin@yahoo.com.au \
--cc=rhim@cc.gateh.edu \
--cc=virtualization@lists.osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.