All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Hansen <haveblue@us.ibm.com>
To: Martin Waitz <tali@admingilde.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	linux-ia64@vger.kernel.org
Subject: Re: [RFC][PATCH 3/9] actual generic PAGE_SIZE infrastructure
Date: Tue, 05 Sep 2006 16:47:43 +0000	[thread overview]
Message-ID: <1157474863.3186.6.camel@localhost.localdomain> (raw)
In-Reply-To: <20060905112056.GJ17042@admingilde.org>

On Tue, 2006-09-05 at 13:20 +0200, Martin Waitz wrote:
> On Wed, Aug 30, 2006 at 03:16:06PM -0700, Dave Hansen wrote:
> > * Define ASM_CONST() macro to help using constants in both assembly
> >   and C code.  Several architectures have some form of this, and
> >   they will be consolidated around this one.
> 
> arm uses UL() for this and I think this is much more readable than
> ASM_CONST().  Can we please change the name of this macro?

I don't have any real problem with changing it, but I fear that the ppc
guys will want it the _other_ way. ;)

Do you really mind if we just keep it as it is?  If there is some
further disagreement on it, I'll change it.

-- Dave


WARNING: multiple messages have this Message-ID (diff)
From: Dave Hansen <haveblue@us.ibm.com>
To: Martin Waitz <tali@admingilde.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	linux-ia64@vger.kernel.org
Subject: Re: [RFC][PATCH 3/9] actual generic PAGE_SIZE infrastructure
Date: Tue, 05 Sep 2006 09:47:43 -0700	[thread overview]
Message-ID: <1157474863.3186.6.camel@localhost.localdomain> (raw)
In-Reply-To: <20060905112056.GJ17042@admingilde.org>

On Tue, 2006-09-05 at 13:20 +0200, Martin Waitz wrote:
> On Wed, Aug 30, 2006 at 03:16:06PM -0700, Dave Hansen wrote:
> > * Define ASM_CONST() macro to help using constants in both assembly
> >   and C code.  Several architectures have some form of this, and
> >   they will be consolidated around this one.
> 
> arm uses UL() for this and I think this is much more readable than
> ASM_CONST().  Can we please change the name of this macro?

I don't have any real problem with changing it, but I fear that the ppc
guys will want it the _other_ way. ;)

Do you really mind if we just keep it as it is?  If there is some
further disagreement on it, I'll change it.

-- Dave


WARNING: multiple messages have this Message-ID (diff)
From: Dave Hansen <haveblue@us.ibm.com>
To: Martin Waitz <tali@admingilde.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	linux-ia64@vger.kernel.org
Subject: Re: [RFC][PATCH 3/9] actual generic PAGE_SIZE infrastructure
Date: Tue, 05 Sep 2006 09:47:43 -0700	[thread overview]
Message-ID: <1157474863.3186.6.camel@localhost.localdomain> (raw)
In-Reply-To: <20060905112056.GJ17042@admingilde.org>

On Tue, 2006-09-05 at 13:20 +0200, Martin Waitz wrote:
> On Wed, Aug 30, 2006 at 03:16:06PM -0700, Dave Hansen wrote:
> > * Define ASM_CONST() macro to help using constants in both assembly
> >   and C code.  Several architectures have some form of this, and
> >   they will be consolidated around this one.
> 
> arm uses UL() for this and I think this is much more readable than
> ASM_CONST().  Can we please change the name of this macro?

I don't have any real problem with changing it, but I fear that the ppc
guys will want it the _other_ way. ;)

Do you really mind if we just keep it as it is?  If there is some
further disagreement on it, I'll change it.

-- Dave

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2006-09-05 16:47 UTC|newest]

Thread overview: 80+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-08-30 22:16 [RFC][PATCH 0/9] generic PAGE_SIZE infrastructure (v4) Dave Hansen
2006-08-30 22:16 ` Dave Hansen
2006-08-30 22:16 ` Dave Hansen
2006-08-30 22:16 ` [RFC][PATCH 2/9] conditionally define generic get_order() (ARCH_HAS_GET_ORDER) Dave Hansen
2006-08-30 22:16   ` Dave Hansen
2006-08-30 22:16   ` Dave Hansen
2006-08-31 18:41   ` Haavard Skinnemoen
2006-08-31 18:41     ` Haavard Skinnemoen
2006-08-31 18:41     ` Haavard Skinnemoen
2006-08-31 19:51     ` [RFC][PATCH 2/9] conditionally define generic get_order() Dave Hansen
2006-08-31 19:51       ` [RFC][PATCH 2/9] conditionally define generic get_order() (ARCH_HAS_GET_ORDER) Dave Hansen
2006-08-31 19:51       ` Dave Hansen
2006-08-30 22:16 ` [RFC][PATCH 1/9] put alignment macros in align.h Dave Hansen
2006-08-30 22:16   ` Dave Hansen
2006-08-30 22:16   ` Dave Hansen
2006-08-30 22:16 ` [RFC][PATCH 3/9] actual generic PAGE_SIZE infrastructure Dave Hansen
2006-08-30 22:16   ` Dave Hansen
2006-08-30 22:16   ` Dave Hansen
2006-08-31  0:08   ` Christoph Lameter
2006-08-31  0:08     ` Christoph Lameter
2006-08-31  0:08     ` Christoph Lameter
2006-08-31 17:57     ` Dave Hansen
2006-08-31 17:57       ` Dave Hansen
2006-08-31 17:57       ` Dave Hansen
2006-08-31 18:06       ` Christoph Lameter
2006-08-31 18:06         ` Christoph Lameter
2006-08-31 18:06         ` Christoph Lameter
2006-08-31 20:50     ` Dave Hansen
2006-08-31 20:50       ` Dave Hansen
2006-08-31 20:50       ` Dave Hansen
2006-09-05 11:20   ` Martin Waitz
2006-09-05 11:20     ` Martin Waitz
2006-09-05 16:47     ` Dave Hansen [this message]
2006-09-05 16:47       ` Dave Hansen
2006-09-05 16:47       ` Dave Hansen
2006-10-17  7:29   ` Qi Yong
2006-10-17  7:29     ` Qi Yong
2006-10-17  7:29     ` Qi Yong
2006-08-30 22:16 ` [RFC][PATCH 4/9] ia64 generic PAGE_SIZE Dave Hansen
2006-08-30 22:16   ` Dave Hansen
2006-08-30 22:16   ` Dave Hansen
2006-08-30 23:57   ` Christoph Lameter
2006-08-30 23:57     ` Christoph Lameter
2006-08-30 23:57     ` Christoph Lameter
2006-08-31 17:38     ` Dave Hansen
2006-08-31 17:38       ` Dave Hansen
2006-08-31 17:38       ` Dave Hansen
2006-08-31 17:39       ` Christoph Lameter
2006-08-31 17:39         ` Christoph Lameter
2006-08-31 17:39         ` Christoph Lameter
2006-08-30 22:16 ` [RFC][PATCH 5/9] sparc64 " Dave Hansen
2006-08-30 22:16   ` Dave Hansen
2006-08-30 22:16   ` Dave Hansen
2006-08-30 22:27   ` David Miller
2006-08-30 22:27     ` David Miller, Dave Hansen
2006-08-30 22:27     ` David Miller
2006-08-30 22:16 ` [RFC][PATCH 6/9] mips " Dave Hansen
2006-08-30 22:16   ` Dave Hansen
2006-08-30 22:16   ` Dave Hansen
2006-08-30 22:16 ` [RFC][PATCH 7/9] parisc " Dave Hansen
2006-08-30 22:16   ` Dave Hansen
2006-08-30 22:16   ` Dave Hansen
2006-08-30 22:40   ` Kyle McMartin
2006-08-30 22:40     ` Kyle McMartin
2006-08-30 22:40     ` Kyle McMartin
2006-08-30 22:48     ` Dave Hansen
2006-08-30 22:48       ` Dave Hansen
2006-08-30 22:48       ` Dave Hansen
2006-08-30 22:16 ` [RFC][PATCH 8/9] powerpc " Dave Hansen
2006-08-30 22:16   ` Dave Hansen
2006-08-30 22:16   ` Dave Hansen
2006-08-30 22:16 ` [RFC][PATCH 9/9] convert the "easy" architectures to " Dave Hansen
2006-08-30 22:16   ` Dave Hansen
2006-08-30 22:16   ` Dave Hansen
2006-08-31  0:33 ` [RFC][PATCH 0/9] generic PAGE_SIZE infrastructure (v4) Paul Mackerras
2006-08-31  0:33   ` Paul Mackerras
2006-08-31  0:33   ` Paul Mackerras
2006-08-31 21:03   ` Dave Hansen
2006-08-31 21:03     ` Dave Hansen
2006-08-31 21:03     ` Dave Hansen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1157474863.3186.6.camel@localhost.localdomain \
    --to=haveblue@us.ibm.com \
    --cc=linux-ia64@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=tali@admingilde.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.