From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Olaf Hering <olaf@aepfle.de>
Cc: linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Prevent legacy io access on pmac
Date: Tue, 12 Sep 2006 09:14:25 +1000 [thread overview]
Message-ID: <1158016465.15465.2.camel@localhost.localdomain> (raw)
In-Reply-To: <20060911115354.GA23884@aepfle.de>
On Mon, 2006-09-11 at 13:53 +0200, Olaf Hering wrote:
> The ppc32 common config runs also on PReP/CHRP, which uses PC style IO
> devices. The probing is bogus, it crashes or floods dmesg.
>
> ppc can boot one single binary on prep, chrp and pmac boards.
> ppc64 can boot one single binary on pseries and G5 boards.
> pmac has no legacy io, probing for PC style legacy hardware leads to a
> hard crash:
>
> * add check for parport_pc, exit on pmac.
> 32bit chrp has no ->check_legacy_ioport, the probe is always called.
> 64bit chrp has check_legacy_ioport, check for a "parallel" node
>
> * add check for isapnp, only PReP boards may have real ISA slots.
> 32bit PReP will have no ->check_legacy_ioport, the probe is always called.
>
> * update code in i8042_platform_init. Run ->check_legacy_ioport first, always
> call request_region. No functional change. Remove whitespace before i8042_reset init.
>
>
> Signed-off-by: Olaf Hering <olaf@aepfle.de>
Looks good to me.
Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Olaf Hering <olaf@aepfle.de>
Cc: linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] Prevent legacy io access on pmac
Date: Tue, 12 Sep 2006 09:14:25 +1000 [thread overview]
Message-ID: <1158016465.15465.2.camel@localhost.localdomain> (raw)
In-Reply-To: <20060911115354.GA23884@aepfle.de>
On Mon, 2006-09-11 at 13:53 +0200, Olaf Hering wrote:
> The ppc32 common config runs also on PReP/CHRP, which uses PC style IO
> devices. The probing is bogus, it crashes or floods dmesg.
>
> ppc can boot one single binary on prep, chrp and pmac boards.
> ppc64 can boot one single binary on pseries and G5 boards.
> pmac has no legacy io, probing for PC style legacy hardware leads to a
> hard crash:
>
> * add check for parport_pc, exit on pmac.
> 32bit chrp has no ->check_legacy_ioport, the probe is always called.
> 64bit chrp has check_legacy_ioport, check for a "parallel" node
>
> * add check for isapnp, only PReP boards may have real ISA slots.
> 32bit PReP will have no ->check_legacy_ioport, the probe is always called.
>
> * update code in i8042_platform_init. Run ->check_legacy_ioport first, always
> call request_region. No functional change. Remove whitespace before i8042_reset init.
>
>
> Signed-off-by: Olaf Hering <olaf@aepfle.de>
Looks good to me.
Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
next prev parent reply other threads:[~2006-09-11 23:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-11 11:53 [PATCH] Prevent legacy io access on pmac Olaf Hering
2006-09-11 15:17 ` Olaf Hering
2006-09-11 15:30 ` Segher Boessenkool
2006-09-11 15:30 ` Segher Boessenkool
2006-09-11 23:11 ` Benjamin Herrenschmidt
2006-09-11 23:11 ` Benjamin Herrenschmidt
2006-09-11 15:52 ` Olaf Hering
2006-09-11 23:14 ` Benjamin Herrenschmidt [this message]
2006-09-11 23:14 ` Benjamin Herrenschmidt
2006-09-12 19:29 ` Olaf Hering
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1158016465.15465.2.camel@localhost.localdomain \
--to=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=olaf@aepfle.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.