From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Luke Yang <luke.adi@gmail.com>
Cc: linux-kernel@vger.kernel.org, Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH 2/4] Blackfin: Serial driver for Blackfin arch on 2.6.18
Date: Thu, 21 Sep 2006 10:26:23 +0100 [thread overview]
Message-ID: <1158830784.11109.93.camel@localhost.localdomain> (raw)
In-Reply-To: <489ecd0c0609202033j4dd9a62fye81f99d61bff030d@mail.gmail.com>
Ar Iau, 2006-09-21 am 11:33 +0800, ysgrifennodd Luke Yang:
> Hi,
>
> This is the serial driver for Blackfin. It is designed for the serial
> core framework.
> +#define DMA_RX_XCOUNT TTY_FLIPBUF_SIZE
TTY_FLIPBUF_SIZE is going away. Just pick a value good for your hardware
and under PAGE_SIZE.
Other question - is your locking ok for low latency. In low latency mode
tty_flip_buffer_push() may directly end up calling your write methods.
Otherwise looks good
Alan
next prev parent reply other threads:[~2006-09-21 9:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-21 3:33 [PATCH 2/4] Blackfin: Serial driver for Blackfin arch on 2.6.18 Luke Yang
2006-09-21 5:28 ` Randy.Dunlap
[not found] ` <6d6a94c50609210020x5bb32474wa61fab5f9581a124@mail.gmail.com>
2006-09-21 8:28 ` Luke Yang
2006-09-21 9:01 ` Luke Yang
2006-09-21 10:28 ` Matti Aarnio
2006-09-21 9:26 ` Alan Cox [this message]
2006-09-21 9:23 ` Aubrey
2006-09-21 9:57 ` Luke Yang
2006-09-21 15:38 ` Randy.Dunlap
[not found] ` <489ecd0c0609210849r44a76be1h9ddbc308ba78d574@mail.gmail.com>
2006-09-21 16:00 ` Aubrey
2006-09-21 16:07 ` Randy.Dunlap
2006-09-22 2:03 ` Oleg Verych
2006-09-22 2:27 ` Aubrey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1158830784.11109.93.camel@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luke.adi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.