From: Oleg Verych <olecom@flower.upol.cz>
To: linux-kernel@vger.kernel.org
Cc: Luke Yang <luke.adi@gmail.com>
Subject: Re: [PATCH 2/4] Blackfin: Serial driver for Blackfin arch on 2.6.18
Date: Fri, 22 Sep 2006 04:03:17 +0200 [thread overview]
Message-ID: <45134465.8060703@flower.upol.cz> (raw)
In-Reply-To: <489ecd0c0609202033j4dd9a62fye81f99d61bff030d@mail.gmail.com>
Hallo, Luke Yang, who wrote:
> +static void bfin_serial_mctrl_check(struct bfin_serial_port *uart);
> +
> +/*
> + * interrupts disabled on entry
> + */
spelling error: _are_ disabled
please grep && sed all patches
> +static void bfin_serial_stop_tx(struct uart_port *port)
> +{
> + struct bfin_serial_port *uart = (struct bfin_serial_port *)port;
> + unsigned short ier;
> + ier = UART_GET_IER(uart);
> + ier &= ~ETBEI;
> + UART_PUT_IER(uart, ier);
> +#ifdef CONFIG_SERIAL_BFIN_DMA
> + disable_dma(uart->tx_dma_channel);
> +#endif
> +}
one blank line after local variables; you are using this in some functions, in
some you are not...
> +
> +static void bfin_serial_shutdown(struct uart_port *port)
> +{
> + struct bfin_serial_port *uart = (struct bfin_serial_port *)port;
> +
yes, one more space will be nicer
> + free_irq(uart->port.irq+1, uart);
here and the like
--
-o--=O`C
#oo'L O 5 years ago TT and WTC7 were assassinated
<___=E M learn more how (tm) <http://911research.com>
next prev parent reply other threads:[~2006-09-22 2:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-21 3:33 [PATCH 2/4] Blackfin: Serial driver for Blackfin arch on 2.6.18 Luke Yang
2006-09-21 5:28 ` Randy.Dunlap
[not found] ` <6d6a94c50609210020x5bb32474wa61fab5f9581a124@mail.gmail.com>
2006-09-21 8:28 ` Luke Yang
2006-09-21 9:01 ` Luke Yang
2006-09-21 10:28 ` Matti Aarnio
2006-09-21 9:26 ` Alan Cox
2006-09-21 9:23 ` Aubrey
2006-09-21 9:57 ` Luke Yang
2006-09-21 15:38 ` Randy.Dunlap
[not found] ` <489ecd0c0609210849r44a76be1h9ddbc308ba78d574@mail.gmail.com>
2006-09-21 16:00 ` Aubrey
2006-09-21 16:07 ` Randy.Dunlap
2006-09-22 2:03 ` Oleg Verych [this message]
2006-09-22 2:27 ` Aubrey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45134465.8060703@flower.upol.cz \
--to=olecom@flower.upol.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=luke.adi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.