[KJ] [PATCH] check_/request_region fixes: sound/oss/pss.c

[KJ] [PATCH] check_/request_region fixes: sound/oss/pss.c

[Kevin Lo]

[-- Attachment #1: Type: text/plain, Size: 91 bytes --]

Hi,

Attached patch is to get rid of check_region and replace with
request_region.

	Kevin

[-- Attachment #2: patch --]
[-- Type: text/plain, Size: 437 bytes --]

--- linux-2.6.18/sound/oss/pss.c.orig	2006-10-03 11:51:18.000000000 +0800
+++ linux-2.6.18/sound/oss/pss.c	2006-10-03 12:05:54.000000000 +0800
@@ -677,7 +677,7 @@ static void configure_nonsound_component
 	{
 		printk(KERN_INFO "PSS: CDROM port not enabled.\n");
 	}
-	else if(check_region(pss_cdrom_port, 2))
+	else if(!request_region(pss_cdrom_port, 2, "PSS cdrom port"))
 	{
 		printk(KERN_ERR "PSS: CDROM I/O port conflict.\n");
 	}

[-- Attachment #3: Type: text/plain, Size: 168 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [KJ] [PATCH] check_/request_region fixes: sound/oss/pss.c

[Dan Carpenter]

On 10/2/06, Kevin Lo <kevlo@kevlo.org> wrote:
> Hi,
>
> Attached patch is to get rid of check_region and replace with
> request_region.
>
>         Kevin
>

Nope.  This is wrong.  You have to replace both check_region() and
modify the call to request_region().  Look through the list for
examples on how to do it.

Also don't send the patch as an attachment, just include it in your
email.  But make sure the lines don't wrap and the tabs are preserved.

regards,
dan carpenter
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [KJ] [PATCH] check_/request_region fixes: sound/oss/pss.c

[Kevin Lo]

Kevin Lo wrote:
> Hi,
> 
> Attached patch is to get rid of check_region and replace with
> request_region.

Whoops, please ignore this patch since I sent the wrong one :-(

> 
> 	Kevin

	Kevin

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors