From: Len Brown <len.brown@intel.com>
To: linux-acpi@vger.kernel.org
Cc: Lebedev@vger.kernel.org,
Vladimir P <vladimir.p.lebedev@intel.com>,
Len Brown <len.brown@intel.com>
Subject: [PATCH 5/28] ACPI: sbs: check for NULL device pointer
Date: Sat, 14 Oct 2006 04:05:46 -0400
Date: Tue, 5 Sep 2006 19:49:13 +0400 [thread overview]
Message-ID: <1160813174246-git-send-email-len.brown@intel.com> (raw)
Message-ID: <963497c12acb4d43caa9751b9291b014eea51a1a.1160812999.git.len.brown@intel.com> (raw)
In-Reply-To: <11608131691346-git-send-email-len.brown@intel.com>
In-Reply-To: <288f3ad406460f03642a41bb945826891a7b866f.1160812999.git.len.brown@intel.com>
From: Lebedev, Vladimir P <vladimir.p.lebedev@intel.com>
Signed-off-by: Len Brown <len.brown@intel.com>
---
drivers/acpi/sbs.c | 10 ++++++++--
1 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/drivers/acpi/sbs.c b/drivers/acpi/sbs.c
index 62bef0b..79f38f0 100644
--- a/drivers/acpi/sbs.c
+++ b/drivers/acpi/sbs.c
@@ -1685,10 +1685,16 @@ static int acpi_sbs_add(struct acpi_devi
int acpi_sbs_remove(struct acpi_device *device, int type)
{
- struct acpi_sbs *sbs = (struct acpi_sbs *)acpi_driver_data(device);
+ struct acpi_sbs *sbs = NULL;
int id;
- if (!device || !sbs) {
+ if (!device) {
+ return -EINVAL;
+ }
+
+ sbs = (struct acpi_sbs *)acpi_driver_data(device);
+
+ if (!sbs) {
return -EINVAL;
}
--
1.4.3.rc2.g23bed-dirty
next prev parent reply other threads:[~2006-10-14 8:02 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-14 8:05 ACPI patches pushed to linux-2.6.19-rc2 Len Brown
2006-10-14 8:05 ` [PATCH 1/28] ACPI: asus_acpi: W3000 support Len Brown
2006-10-14 8:05 ` Len Brown
2006-10-14 8:05 ` [PATCH 2/28] ACPI: ibm_acpi: Remove experimental status for brightness and volume Len Brown
2006-10-14 8:05 ` Len Brown
2006-10-14 8:05 ` [PATCH 3/28] ACPI: ibm_acpi: Update documentation " Len Brown
2006-10-14 8:05 ` Len Brown
2006-10-14 8:05 ` [PATCH 4/28] ACPI: ibm_acpi: Documentation the wan feature Len Brown
2006-10-14 8:05 ` Len Brown
2006-10-14 8:05 ` Len Brown [this message]
2006-10-14 8:05 ` [PATCH 5/28] ACPI: sbs: check for NULL device pointer Len Brown
2006-10-14 8:05 ` [PATCH 6/28] ACPI: sbs: fix module_param() initializers Len Brown
2006-10-14 8:05 ` Len Brown
2006-10-14 8:05 ` [PATCH 7/28] ACPI: Processor native C-states using MWAIT Len Brown
2006-10-14 8:05 ` Len Brown
2006-10-14 8:05 ` [PATCH 8/28] ACPI: consolidate functions in acpi ec driver Len Brown
2006-10-14 8:05 ` Len Brown
2006-10-14 8:05 ` [PATCH 14/28] ACPI: EC: export ec_transaction() for msi-laptop driver Len Brown
2006-10-14 8:05 ` Len Brown
2006-10-14 8:05 ` [PATCH 15/28] MSI S270 Laptop support: backlight, wlan, bluetooth states Len Brown
2006-10-14 8:05 ` Len Brown
2006-10-14 8:05 ` [PATCH 18/28] ACPI: ibm_acpi: delete obsolete documentation Len Brown
2006-10-14 8:05 ` Len Brown
2006-10-14 8:06 ` [PATCH 19/28] ACPI: fix potential OOPS in power driver with CONFIG_ACPI_DEBUG Len Brown
2006-10-14 8:06 ` Len Brown
2006-10-14 8:06 ` [PATCH 20/28] ACPI: acpi_pci_link_set() can allocate with either GFP_ATOMIC or GFP_KERNEL Len Brown
2006-10-14 8:06 ` Len Brown
2006-10-14 8:06 ` [PATCH 21/28] ACPI: update comments in motherboard.c Len Brown
2006-10-14 8:06 ` Len Brown
2007-01-07 4:56 ` Bjorn Helgaas
2006-10-14 8:06 ` [PATCH 22/28] ACPI: fix section for CPU init functions Len Brown
2006-10-14 8:06 ` Len Brown
2006-10-14 8:06 ` [PATCH 23/28] ACPI: fix printk format warnings Len Brown
2006-10-14 8:06 ` Len Brown
2006-10-14 8:06 ` [PATCH 24/28] ACPI: SCI interrupt source override Len Brown
2006-10-14 8:06 ` Len Brown
2006-10-14 8:06 ` [PATCH 25/28] ACPI: asus_acpi: fix proc files parsing Len Brown
2006-10-14 8:06 ` Len Brown
2006-10-14 8:06 ` [PATCH 26/28] ACPI: asus_acpi: don't printk on writing garbage to proc files Len Brown
2006-10-14 8:06 ` Len Brown
2006-10-14 8:06 ` [PATCH 27/28] ACPICA: Fix incorrect handling of PCI Express Root Bridge _HID Len Brown
2006-10-14 8:06 ` Len Brown
2006-10-14 8:06 ` [PATCH 28/28] ACPI: check battery status on resume for un/plug events during sleep Len Brown
2006-10-14 8:06 ` Len Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1160813174246-git-send-email-len.brown@intel.com \
--to=len.brown@intel.com \
--cc=Lebedev@vger.kernel.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=vladimir.p.lebedev@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.