From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Christoph Lameter <clameter@sgi.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
ppc-dev <linuxppc-dev@ozlabs.org>,
ak@suse.de, LKML <linux-kernel@vger.kernel.org>,
linux-mm@kvack.org, paulus@samba.org
Subject: Re: [PATCH 2/3] Create compat_sys_migrate_pages
Date: Mon, 30 Oct 2006 16:29:09 +1100 [thread overview]
Message-ID: <1162186149.25682.171.camel@localhost.localdomain> (raw)
In-Reply-To: <Pine.LNX.4.64.0610270622480.7342@schroedinger.engr.sgi.com>
On Fri, 2006-10-27 at 06:24 -0700, Christoph Lameter wrote:
> On Fri, 27 Oct 2006, Stephen Rothwell wrote:
>
> > No they aren't because they have compat routines that convert the bitmaps
> > before calling the "normal" syscall. They, importantly, only use
> > compat_alloc_user_space once each.
>
> Ah...
>
> > > Fixing get_nodes() to do the proper thing would fix all of these
> > > without having to touch sys_migrate_pages or creating a compat_ function
> > > (which usually is placed in kernel/compat.c)
> >
> > You need the compat_ version of the syscalls to know if you were called
> > from a 32bit application in order to know if you may need to fixup the
> > bitmaps that are passed from/to user mode.
>
> The compat functions should be placed in kernel/compat.c next to
> compat_sys_move_pages.
I disagree.. it's really annoying when they are away from their
respective "non-compat" function, especially when they are more than
just wrappers copying/converting arguments...
Now, if only we had done a sane ABI in the first place...
Ben.
WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Christoph Lameter <clameter@sgi.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
LKML <linux-kernel@vger.kernel.org>,
ppc-dev <linuxppc-dev@ozlabs.org>,
paulus@samba.org, ak@suse.de, linux-mm@kvack.org
Subject: Re: [PATCH 2/3] Create compat_sys_migrate_pages
Date: Mon, 30 Oct 2006 16:29:09 +1100 [thread overview]
Message-ID: <1162186149.25682.171.camel@localhost.localdomain> (raw)
In-Reply-To: <Pine.LNX.4.64.0610270622480.7342@schroedinger.engr.sgi.com>
On Fri, 2006-10-27 at 06:24 -0700, Christoph Lameter wrote:
> On Fri, 27 Oct 2006, Stephen Rothwell wrote:
>
> > No they aren't because they have compat routines that convert the bitmaps
> > before calling the "normal" syscall. They, importantly, only use
> > compat_alloc_user_space once each.
>
> Ah...
>
> > > Fixing get_nodes() to do the proper thing would fix all of these
> > > without having to touch sys_migrate_pages or creating a compat_ function
> > > (which usually is placed in kernel/compat.c)
> >
> > You need the compat_ version of the syscalls to know if you were called
> > from a 32bit application in order to know if you may need to fixup the
> > bitmaps that are passed from/to user mode.
>
> The compat functions should be placed in kernel/compat.c next to
> compat_sys_move_pages.
I disagree.. it's really annoying when they are away from their
respective "non-compat" function, especially when they are more than
just wrappers copying/converting arguments...
Now, if only we had done a sane ABI in the first place...
Ben.
WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Christoph Lameter <clameter@sgi.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
LKML <linux-kernel@vger.kernel.org>,
ppc-dev <linuxppc-dev@ozlabs.org>,
paulus@samba.org, ak@suse.de, linux-mm@kvack.org
Subject: Re: [PATCH 2/3] Create compat_sys_migrate_pages
Date: Mon, 30 Oct 2006 16:29:09 +1100 [thread overview]
Message-ID: <1162186149.25682.171.camel@localhost.localdomain> (raw)
In-Reply-To: <Pine.LNX.4.64.0610270622480.7342@schroedinger.engr.sgi.com>
On Fri, 2006-10-27 at 06:24 -0700, Christoph Lameter wrote:
> On Fri, 27 Oct 2006, Stephen Rothwell wrote:
>
> > No they aren't because they have compat routines that convert the bitmaps
> > before calling the "normal" syscall. They, importantly, only use
> > compat_alloc_user_space once each.
>
> Ah...
>
> > > Fixing get_nodes() to do the proper thing would fix all of these
> > > without having to touch sys_migrate_pages or creating a compat_ function
> > > (which usually is placed in kernel/compat.c)
> >
> > You need the compat_ version of the syscalls to know if you were called
> > from a 32bit application in order to know if you may need to fixup the
> > bitmaps that are passed from/to user mode.
>
> The compat functions should be placed in kernel/compat.c next to
> compat_sys_move_pages.
I disagree.. it's really annoying when they are away from their
respective "non-compat" function, especially when they are more than
just wrappers copying/converting arguments...
Now, if only we had done a sane ABI in the first place...
Ben.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2006-10-30 5:29 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-26 3:26 [PATCH 1/3] Constify compat_get_bitmap argument Stephen Rothwell
2006-10-26 3:26 ` Stephen Rothwell
2006-10-26 3:33 ` [PATCH 2/3] Create compat_sys_migrate_pages Stephen Rothwell
2006-10-26 3:33 ` Stephen Rothwell
2006-10-26 3:34 ` [PATCH 3/3] [POWERPC] Wire up sys_migrate_pages Stephen Rothwell
2006-10-26 3:34 ` Stephen Rothwell
2006-10-26 3:57 ` [PATCH 2/3] Create compat_sys_migrate_pages Stephen Rothwell
2006-10-26 3:57 ` Stephen Rothwell
2006-10-26 23:04 ` Arnd Bergmann
2006-10-26 23:04 ` Arnd Bergmann
2006-10-26 23:04 ` Arnd Bergmann
2006-10-26 19:00 ` Christoph Lameter
2006-10-26 19:00 ` Christoph Lameter
2006-10-26 19:00 ` Christoph Lameter
2006-10-27 0:28 ` Stephen Rothwell
2006-10-27 0:28 ` Stephen Rothwell
2006-10-27 13:24 ` Christoph Lameter
2006-10-27 13:24 ` Christoph Lameter
2006-10-27 13:24 ` Christoph Lameter
2006-10-30 5:29 ` Benjamin Herrenschmidt [this message]
2006-10-30 5:29 ` Benjamin Herrenschmidt
2006-10-30 5:29 ` Benjamin Herrenschmidt
2006-10-26 23:03 ` Arnd Bergmann
2006-10-26 23:03 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1162186149.25682.171.camel@localhost.localdomain \
--to=benh@kernel.crashing.org \
--cc=ak@suse.de \
--cc=clameter@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.