* [PATCH] lockdep: print current locks on in_atomic warnings
@ 2006-11-05 20:36 Peter Zijlstra
2006-11-06 7:21 ` Ingo Molnar
0 siblings, 1 reply; 2+ messages in thread
From: Peter Zijlstra @ 2006-11-05 20:36 UTC (permalink / raw)
To: linux-kernel, Andrew Morton; +Cc: Ingo Molnar, arjan
Add debug_show_held_locks(current) to __might_sleep() and
schedule(); this makes finding the offending lock leak easier.
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
---
kernel/sched.c | 2 ++
1 file changed, 2 insertions(+)
Index: linux-2.6-twins/kernel/sched.c
===================================================================
--- linux-2.6-twins.orig/kernel/sched.c 2006-11-05 21:04:13.000000000 +0100
+++ linux-2.6-twins/kernel/sched.c 2006-11-05 21:11:39.000000000 +0100
@@ -3333,6 +3333,7 @@ asmlinkage void __sched schedule(void)
printk(KERN_ERR "BUG: scheduling while atomic: "
"%s/0x%08x/%d\n",
current->comm, preempt_count(), current->pid);
+ debug_show_held_locks(current);
dump_stack();
}
profile_hit(SCHED_PROFILING, __builtin_return_address(0));
@@ -6867,6 +6868,7 @@ void __might_sleep(char *file, int line)
" context at %s:%d\n", file, line);
printk("in_atomic():%d, irqs_disabled():%d\n",
in_atomic(), irqs_disabled());
+ debug_show_held_locks(current);
dump_stack();
}
#endif
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] lockdep: print current locks on in_atomic warnings
2006-11-05 20:36 [PATCH] lockdep: print current locks on in_atomic warnings Peter Zijlstra
@ 2006-11-06 7:21 ` Ingo Molnar
0 siblings, 0 replies; 2+ messages in thread
From: Ingo Molnar @ 2006-11-06 7:21 UTC (permalink / raw)
To: Peter Zijlstra; +Cc: linux-kernel, Andrew Morton, arjan
* Peter Zijlstra <a.p.zijlstra@chello.nl> wrote:
> Add debug_show_held_locks(current) to __might_sleep() and schedule();
> this makes finding the offending lock leak easier.
>
> Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
good idea.
Acked-by: Ingo Molnar <mingo@elte.hu>
Ingo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-11-06 7:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-11-05 20:36 [PATCH] lockdep: print current locks on in_atomic warnings Peter Zijlstra
2006-11-06 7:21 ` Ingo Molnar
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.