From: Ian Kent <raven@themaw.net>
To: Jeff Moyer <jmoyer@redhat.com>
Cc: autofs mailing list <autofs@linux.kernel.org>
Subject: Re: [autofs4 patch] fix e2fsck error checking
Date: Thu, 09 Nov 2006 11:26:44 +0800 [thread overview]
Message-ID: <1163042804.4475.3.camel@localhost> (raw)
In-Reply-To: <x49irhpnw8z.fsf@segfault.boston.devel.redhat.com>
On Wed, 2006-11-08 at 22:18 -0500, Jeff Moyer wrote:
> Hi, Ian, list,
>
> The patch is pretty self-explanatory. Comments are welcome, as always.
> I sent this a while back, too. I have not re-tested it since then.
>
> -Jeff
>
>
> diff --git a/modules/mount_ext2.c b/modules/mount_ext2.c
> index b2efb96..a7f008f 100644
> --- a/modules/mount_ext2.c
> +++ b/modules/mount_ext2.c
> @@ -99,7 +99,13 @@ #endif
> err = spawnl(LOG_DEBUG, fsck_prog, fsck_prog, "-p", what, NULL);
> }
>
> - if (err & ~6) {
> + /*
> + * spawnl returns the error code, left shifted by 8 bits. We are
I thought I checked this and concluded it wasn't actually the case.
I'll check it again.
> + * interested in the following error bits from the fsck program:
> + * 2 - File system errors corrected, system should be rebooted
> + * 4 - File system errors left uncorrected
> + */
> + if ((err >> 8) & 6) {
> error(MODPREFIX "%s: filesystem needs repair, won't mount",
> what);
> return 1;
prev parent reply other threads:[~2006-11-09 3:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-09 3:18 [autofs4 patch] fix e2fsck error checking Jeff Moyer
2006-11-09 3:26 ` Ian Kent [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1163042804.4475.3.camel@localhost \
--to=raven@themaw.net \
--cc=autofs@linux.kernel.org \
--cc=jmoyer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.