All of lore.kernel.org
 help / color / mirror / Atom feed
* [autofs4 patch] fix e2fsck error checking
@ 2006-11-09  3:18 Jeff Moyer
  2006-11-09  3:26 ` Ian Kent
  0 siblings, 1 reply; 2+ messages in thread
From: Jeff Moyer @ 2006-11-09  3:18 UTC (permalink / raw)
  To: Ian Kent, autofs mailing list

Hi, Ian, list,

The patch is pretty self-explanatory.  Comments are welcome, as always.
I sent this a while back, too.  I have not re-tested it since then.

-Jeff


diff --git a/modules/mount_ext2.c b/modules/mount_ext2.c
index b2efb96..a7f008f 100644
--- a/modules/mount_ext2.c
+++ b/modules/mount_ext2.c
@@ -99,7 +99,13 @@ #endif
 		err = spawnl(LOG_DEBUG, fsck_prog, fsck_prog, "-p", what, NULL);
 	}
 
-	if (err & ~6) {
+	/*
+	 * spawnl returns the error code, left shifted by 8 bits.  We are
+	 * interested in the following error bits from the fsck program:
+	 *    2 - File system errors corrected, system should be rebooted
+	 *    4 - File system errors left uncorrected
+	 */
+	if ((err >> 8) & 6) {
 		error(MODPREFIX "%s: filesystem needs repair, won't mount",
 		      what);
 		return 1;

^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2006-11-09  3:26 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-11-09  3:18 [autofs4 patch] fix e2fsck error checking Jeff Moyer
2006-11-09  3:26 ` Ian Kent

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.