From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Ian Romanick <idr@us.ibm.com>
Cc: linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org,
paulus@samba.org, anton@samba.org, airlied@gmail.com,
David Miller <davem@davemloft.net>
Subject: Re: [PATCH/RFC] powerpc: Fix mmap of PCI resource with hack for X
Date: Tue, 14 Nov 2006 14:02:51 +1100 [thread overview]
Message-ID: <1163473371.5940.84.camel@localhost.localdomain> (raw)
In-Reply-To: <455926C0.9080906@us.ibm.com>
> > So the gist of your change is that X isn't obtaining BAR values
> > in the correct context on powerpc, and so you're going to hack up
> > the "devices" files output to "help" X out.
> >
> > This doesn't sound sane to me.
>
> It doesn't sound terribly sane to me. What's wrong with just opening
> /sys/bus/pci/devices/*/resource[0-5]? It seems like that solves all the
> problems.
We have to, that's how we get current X to work. Of course it will be
much better once X uses sysfs, no question about that.
Ben.
WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Ian Romanick <idr@us.ibm.com>
Cc: David Miller <davem@davemloft.net>,
linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org,
anton@samba.org, airlied@gmail.com, paulus@samba.org
Subject: Re: [PATCH/RFC] powerpc: Fix mmap of PCI resource with hack for X
Date: Tue, 14 Nov 2006 14:02:51 +1100 [thread overview]
Message-ID: <1163473371.5940.84.camel@localhost.localdomain> (raw)
In-Reply-To: <455926C0.9080906@us.ibm.com>
> > So the gist of your change is that X isn't obtaining BAR values
> > in the correct context on powerpc, and so you're going to hack up
> > the "devices" files output to "help" X out.
> >
> > This doesn't sound sane to me.
>
> It doesn't sound terribly sane to me. What's wrong with just opening
> /sys/bus/pci/devices/*/resource[0-5]? It seems like that solves all the
> problems.
We have to, that's how we get current X to work. Of course it will be
much better once X uses sysfs, no question about that.
Ben.
next prev parent reply other threads:[~2006-11-14 3:03 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-13 8:16 [PATCH/RFC] powerpc: Fix mmap of PCI resource with hack for X Benjamin Herrenschmidt
2006-11-13 8:16 ` Benjamin Herrenschmidt
2006-11-14 0:31 ` David Miller
2006-11-14 0:31 ` David Miller
2006-11-14 1:59 ` Benjamin Herrenschmidt
2006-11-14 1:59 ` Benjamin Herrenschmidt
2006-11-14 5:07 ` David Miller
2006-11-14 5:07 ` David Miller
2006-11-14 5:16 ` Benjamin Herrenschmidt
2006-11-14 5:16 ` Benjamin Herrenschmidt
2006-11-14 2:15 ` Ian Romanick
2006-11-14 2:15 ` Ian Romanick
2006-11-14 3:02 ` Benjamin Herrenschmidt [this message]
2006-11-14 3:02 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1163473371.5940.84.camel@localhost.localdomain \
--to=benh@kernel.crashing.org \
--cc=airlied@gmail.com \
--cc=anton@samba.org \
--cc=davem@davemloft.net \
--cc=idr@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.