[PATCH] [LIBXEN] Fix returned type in vtpm_get_backend() function call

[PATCH] [LIBXEN] Fix returned type in vtpm_get_backend() function call

[Stefan Berger]

[-- Attachment #1: Type: text/plain, Size: 108 bytes --]

Return a string from vtpm_get_backend() function call.

Signed-off-by: Stefan Berger <stefanb@us.ibm.com>



[-- Attachment #2: libxen-vtpm-fix.diff --]
[-- Type: text/x-patch, Size: 1037 bytes --]

Index: root/xen-unstable.hg/tools/libxen/include/xen_vtpm.h
===================================================================
--- root.orig/xen-unstable.hg/tools/libxen/include/xen_vtpm.h
+++ root/xen-unstable.hg/tools/libxen/include/xen_vtpm.h
@@ -196,7 +196,7 @@ xen_vtpm_get_vm(xen_session *session, xe
  * Get the backend field of the given VTPM.
  */
 extern bool
-xen_vtpm_get_backend(xen_session *session, xen_vm *result, xen_vtpm vtpm);
+xen_vtpm_get_backend(xen_session *session, char **result, xen_vtpm vtpm);
 
 
 /**
Index: root/xen-unstable.hg/tools/libxen/src/xen_vtpm.c
===================================================================
--- root.orig/xen-unstable.hg/tools/libxen/src/xen_vtpm.c
+++ root/xen-unstable.hg/tools/libxen/src/xen_vtpm.c
@@ -170,7 +170,7 @@ xen_vtpm_get_vm(xen_session *session, xe
 
 
 bool
-xen_vtpm_get_backend(xen_session *session, xen_vm *result, xen_vtpm vtpm)
+xen_vtpm_get_backend(xen_session *session, char **result, xen_vtpm vtpm)
 {
     abstract_value param_values[] =
         {

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Re: [PATCH] [LIBXEN] Fix returned type in vtpm_get_backend() function call

[Ewan Mellor]

On Tue, Nov 14, 2006 at 03:00:04PM -0500, Stefan Berger wrote:

> Return a string from vtpm_get_backend() function call.

I thought this field was meant to be a reference to the VM that represented
the backend.  Is that not the case?

Ewan.

Re: [PATCH] [LIBXEN] Fix returned type in vtpm_get_backend() function call

[Stefan Berger]

[-- Attachment #1.1: Type: text/plain, Size: 756 bytes --]

xen-devel-bounces@lists.xensource.com wrote on 11/14/2006 03:08:05 PM:

> On Tue, Nov 14, 2006 at 03:00:04PM -0500, Stefan Berger wrote:
> 
> > Return a string from vtpm_get_backend() function call.
> 
> I thought this field was meant to be a reference to the VM that 
represented
> the backend.  Is that not the case?

When creating the vTPM I am passing in the backend paramter as the name of 
the VM rather than its reference (uuid). So I wanted to change this to be 
symmetric. Should the backend parameter rather be the reference to the VM 
and translated to the name internally?

  Stefan

> 
> Ewan.
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel

[-- Attachment #1.2: Type: text/html, Size: 1005 bytes --]

[-- Attachment #2: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel