All of lore.kernel.org
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org,
	dwalker@mvista.com
Subject: Re: [PATCH] 2.6.18-rt7: PowerPC: fix breakage in threaded fasteoi type IRQ handlers
Date: Tue, 21 Nov 2006 07:09:45 +1100	[thread overview]
Message-ID: <1164053385.8073.24.camel@localhost.localdomain> (raw)
In-Reply-To: <20061120165621.GA1504@elte.hu>

On Mon, 2006-11-20 at 17:56 +0100, Ingo Molnar wrote:
> * Sergei Shtylyov <sshtylyov@ru.mvista.com> wrote:
> 
> > >on PPC64, 'get the vector' initiates an ACK as well - is that done 
> > >before handle_irq() is done?
> > 
> >    Exactly. How else do_IRQ() would know the vector?
> 
> the reason i'm asking is that in this case masking is a bit late at this 
> point and there's a chance for a repeat interrupt.

What do you mean by a bit late ?

You can't mask before you know what interrupt occured so you don't
really have a choice there :-) I'm pretty sure that mask + eoi is what
Apple does on Darwin too though.

Cheers,
Ben.

WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: Sergei Shtylyov <sshtylyov@ru.mvista.com>,
	linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org,
	dwalker@mvista.com
Subject: Re: [PATCH] 2.6.18-rt7: PowerPC: fix breakage in threaded fasteoi type IRQ handlers
Date: Tue, 21 Nov 2006 07:09:45 +1100	[thread overview]
Message-ID: <1164053385.8073.24.camel@localhost.localdomain> (raw)
In-Reply-To: <20061120165621.GA1504@elte.hu>

On Mon, 2006-11-20 at 17:56 +0100, Ingo Molnar wrote:
> * Sergei Shtylyov <sshtylyov@ru.mvista.com> wrote:
> 
> > >on PPC64, 'get the vector' initiates an ACK as well - is that done 
> > >before handle_irq() is done?
> > 
> >    Exactly. How else do_IRQ() would know the vector?
> 
> the reason i'm asking is that in this case masking is a bit late at this 
> point and there's a chance for a repeat interrupt.

What do you mean by a bit late ?

You can't mask before you know what interrupt occured so you don't
really have a choice there :-) I'm pretty sure that mask + eoi is what
Apple does on Darwin too though.

Cheers,
Ben.



  parent reply	other threads:[~2006-11-20 20:09 UTC|newest]

Thread overview: 86+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-19 19:43 [PATCH] 2.6.18-rt7: PowerPC: fix breakage in threaded fasteoi type IRQ handlers Sergei Shtylyov
2006-11-19 19:43 ` Sergei Shtylyov
2006-11-19 20:00 ` Benjamin Herrenschmidt
2006-11-19 20:00   ` Benjamin Herrenschmidt
2006-11-19 20:04   ` Benjamin Herrenschmidt
2006-11-19 20:04     ` Benjamin Herrenschmidt
2006-11-19 20:11     ` Sergei Shtylyov
2006-11-19 20:11       ` Sergei Shtylyov
2006-11-19 20:06   ` Ingo Molnar
2006-11-19 20:06     ` Ingo Molnar
2006-11-19 20:19     ` Benjamin Herrenschmidt
2006-11-19 20:19       ` Benjamin Herrenschmidt
2006-11-19 20:23       ` Ingo Molnar
2006-11-19 20:23         ` Ingo Molnar
2006-11-19 20:31         ` Sergei Shtylyov
2006-11-19 20:31           ` Sergei Shtylyov
2006-11-19 20:36           ` Benjamin Herrenschmidt
2006-11-19 20:36             ` Benjamin Herrenschmidt
2006-11-19 20:42             ` Sergei Shtylyov
2006-11-19 20:42               ` Sergei Shtylyov
2006-11-19 20:45               ` Benjamin Herrenschmidt
2006-11-19 20:45                 ` Benjamin Herrenschmidt
2006-11-19 20:49         ` Benjamin Herrenschmidt
2006-11-19 20:49           ` Benjamin Herrenschmidt
2006-11-20  1:16         ` Benjamin Herrenschmidt
2006-11-20  1:16           ` Benjamin Herrenschmidt
2006-11-20 10:01           ` Ingo Molnar
2006-11-20 10:01             ` Ingo Molnar
2006-11-20 15:29             ` Sergei Shtylyov
2006-11-20 15:29               ` Sergei Shtylyov
2006-11-20 16:56               ` Ingo Molnar
2006-11-20 16:56                 ` Ingo Molnar
2006-11-20 17:03                 ` Sergei Shtylyov
2006-11-20 17:03                   ` Sergei Shtylyov
2006-11-20 17:26                   ` Ingo Molnar
2006-11-20 17:26                     ` Ingo Molnar
2006-11-20 17:55                     ` Ingo Molnar
2006-11-20 17:55                       ` Ingo Molnar
2006-11-20 18:20                       ` Daniel Walker
2006-11-20 18:20                         ` Daniel Walker
2006-11-20 18:29                         ` Ingo Molnar
2006-11-20 18:29                           ` Ingo Molnar
2006-11-20 18:30                       ` Sergei Shtylyov
2006-11-20 18:30                         ` Sergei Shtylyov
2006-11-20 19:10                         ` Ingo Molnar
2006-11-20 19:10                           ` Ingo Molnar
2006-11-20 19:11                           ` Ingo Molnar
2006-11-20 19:11                             ` Ingo Molnar
2006-11-20 19:18                             ` Sergei Shtylyov
2006-11-20 19:18                               ` Sergei Shtylyov
2006-11-20 19:24                               ` Sergei Shtylyov
2006-11-20 19:24                                 ` Sergei Shtylyov
2006-11-20 19:23                                 ` Ingo Molnar
2006-11-20 20:11                       ` Benjamin Herrenschmidt
2006-11-20 20:11                         ` Benjamin Herrenschmidt
2006-11-20 20:09                 ` Benjamin Herrenschmidt [this message]
2006-11-20 20:09                   ` Benjamin Herrenschmidt
2006-11-20 16:25             ` Daniel Walker
2006-11-20 16:25               ` Daniel Walker
2006-11-20 16:42               ` Ingo Molnar
2006-11-20 17:01                 ` Daniel Walker
2006-11-20 20:07             ` Benjamin Herrenschmidt
2006-11-20 20:07               ` Benjamin Herrenschmidt
2006-11-19 20:26       ` Sergei Shtylyov
2006-11-19 20:26         ` Sergei Shtylyov
2006-11-19 20:32         ` Benjamin Herrenschmidt
2006-11-19 20:32           ` Benjamin Herrenschmidt
2006-11-19 20:40           ` Sergei Shtylyov
2006-11-19 20:40             ` Sergei Shtylyov
2006-11-19 20:41             ` Benjamin Herrenschmidt
2006-11-19 20:41               ` Benjamin Herrenschmidt
2006-11-19 20:52               ` Sergei Shtylyov
2006-11-19 20:52                 ` Sergei Shtylyov
2006-11-19 21:08                 ` Benjamin Herrenschmidt
2006-11-19 21:08                   ` Benjamin Herrenschmidt
2006-11-20 15:46                   ` Sergei Shtylyov
2006-11-20 15:46                     ` Sergei Shtylyov
2006-11-19 20:44             ` Sergei Shtylyov
2006-11-19 20:48               ` Benjamin Herrenschmidt
2007-05-17 13:20 ` [PATCH 2.6.21-rt2] PowerPC: revert fix for threaded fasteoi " Sergei Shtylyov
2007-05-17 13:20   ` Sergei Shtylyov
2007-07-12 16:47   ` Sergei Shtylyov
2007-07-12 16:52     ` Thomas Gleixner
2007-07-12 16:52       ` Thomas Gleixner
2007-07-13 17:19       ` Sergei Shtylyov
2007-07-13 17:19         ` Sergei Shtylyov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1164053385.8073.24.camel@localhost.localdomain \
    --to=benh@kernel.crashing.org \
    --cc=dwalker@mvista.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.