All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steven Whitehouse <swhiteho@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] Re: [GFS2] Fix Kconfig wrt CRC32 [8/9]
Date: Wed, 29 Nov 2006 09:57:43 +0000	[thread overview]
Message-ID: <1164794263.3752.41.camel@quoit.chygwyn.com> (raw)
In-Reply-To: <456C80FE.7090902@oracle.com>

Hi,

On Tue, 2006-11-28 at 10:33 -0800, Randy Dunlap wrote:
> Steven Whitehouse wrote:
[bits snipped to cut down size of reply]
> > You'll need the patch:
> > http://www.kernel.org/git/?p=linux/kernel/git/steve/gfs2-2.6-nmw.git;a=commitdiff;h=4a28fda50d864ede7d2724723949407e0e4043b8
> > as well. I'm also slightly surprised that you managed to get the errors
> > that you did, since most of those symbols appear to be networking
> > related and the DLM depends on INET which is clearly not set since NET
> > is not set.
> 
> Thanks, I'll apply that patch also and test again.
> 
> Part of the problem (IMO) is that kconfig s/w doesn't follow dependency
> chains when applying "select"s.
> 
Ah, light begins to dawn :-) Sorry for being a bit slow on the uptake...
I think I see what the problem might be now. I've attached a patch as a
possible solution, let me know if you agree. Its against my -nmw tree,
so for the current upstream it would be the same except for not needing
the "if DLM_SCTP" on the end of the select line,

Steve.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: kconfig.diff
Type: text/x-patch
Size: 722 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/cluster-devel/attachments/20061129/1f5a9341/attachment.bin>

WARNING: multiple messages have this Message-ID (diff)
From: Steven Whitehouse <swhiteho@redhat.com>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: "Patrick Caulfield" <pcaulfie@redhat.com>,
	linux-kernel@vger.kernel.org, cluster-devel@redhat.com,
	"Toralf Förster" <toralf.foerster@gmx.de>
Subject: Re: [GFS2] Fix Kconfig wrt CRC32 [8/9]
Date: Wed, 29 Nov 2006 09:57:43 +0000	[thread overview]
Message-ID: <1164794263.3752.41.camel@quoit.chygwyn.com> (raw)
In-Reply-To: <456C80FE.7090902@oracle.com>

[-- Attachment #1: Type: text/plain, Size: 1037 bytes --]

Hi,

On Tue, 2006-11-28 at 10:33 -0800, Randy Dunlap wrote:
> Steven Whitehouse wrote:
[bits snipped to cut down size of reply]
> > You'll need the patch:
> > http://www.kernel.org/git/?p=linux/kernel/git/steve/gfs2-2.6-nmw.git;a=commitdiff;h=4a28fda50d864ede7d2724723949407e0e4043b8
> > as well. I'm also slightly surprised that you managed to get the errors
> > that you did, since most of those symbols appear to be networking
> > related and the DLM depends on INET which is clearly not set since NET
> > is not set.
> 
> Thanks, I'll apply that patch also and test again.
> 
> Part of the problem (IMO) is that kconfig s/w doesn't follow dependency
> chains when applying "select"s.
> 
Ah, light begins to dawn :-) Sorry for being a bit slow on the uptake...
I think I see what the problem might be now. I've attached a patch as a
possible solution, let me know if you agree. Its against my -nmw tree,
so for the current upstream it would be the same except for not needing
the "if DLM_SCTP" on the end of the select line,

Steve.


[-- Attachment #2: kconfig.diff --]
[-- Type: text/x-patch, Size: 722 bytes --]

diff --git a/fs/dlm/Kconfig b/fs/dlm/Kconfig
index b5654a2..a1d083d 100644
--- a/fs/dlm/Kconfig
+++ b/fs/dlm/Kconfig
@@ -1,5 +1,5 @@
 menu "Distributed Lock Manager"
-	depends on EXPERIMENTAL && INET
+	depends on EXPERIMENTAL && NET && INET
 
 config DLM
 	tristate "Distributed Lock Manager (DLM)"
diff --git a/fs/gfs2/Kconfig b/fs/gfs2/Kconfig
index c0791cb..6a2ffa2 100644
--- a/fs/gfs2/Kconfig
+++ b/fs/gfs2/Kconfig
@@ -34,7 +34,9 @@ config GFS2_FS_LOCKING_NOLOCK
 
 config GFS2_FS_LOCKING_DLM
 	tristate "GFS2 DLM locking module"
-	depends on GFS2_FS
+	depends on GFS2_FS && NET && INET && (IPV6 || IPV6=n)
+	select IP_SCTP if DLM_SCTP
+	select CONFIGFS_FS
 	select DLM
 	help
 	Multiple node locking module for GFS2

  reply	other threads:[~2006-11-29  9:57 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-24  9:34 [Cluster-devel] [GFS2] Fix Kconfig wrt CRC32 [8/9] Steven Whitehouse
2006-11-24  9:34 ` Steven Whitehouse
2006-11-25  5:43 ` [Cluster-devel] " Randy Dunlap
2006-11-25  5:43   ` Randy Dunlap
2006-11-27 13:24   ` [Cluster-devel] " Steven Whitehouse
2006-11-27 13:24     ` Steven Whitehouse
2006-11-27 16:38     ` [Cluster-devel] " Randy Dunlap
2006-11-27 16:38       ` Randy Dunlap
2006-11-28 18:02       ` [Cluster-devel] " Steven Whitehouse
2006-11-28 18:02         ` Steven Whitehouse
2006-11-28 18:33         ` [Cluster-devel] " Randy Dunlap
2006-11-28 18:33           ` Randy Dunlap
2006-11-29  9:57           ` Steven Whitehouse [this message]
2006-11-29  9:57             ` Steven Whitehouse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1164794263.3752.41.camel@quoit.chygwyn.com \
    --to=swhiteho@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.