From: jamal <hadi@cyberus.ca>
To: Thomas Graf <tgraf@suug.ch>
Cc: David Miller <davem@davemloft.net>, netdev@vger.kernel.org
Subject: Re: [G[PATCH 1/2][ENETLINK] max cmd boundary chec
Date: Fri, 01 Dec 2006 09:30:27 -0500 [thread overview]
Message-ID: <1164983427.3562.36.camel@localhost> (raw)
In-Reply-To: <20061201124903.GE8693@postel.suug.ch>
Shall i assume that the patch showed up fine i.e no crap like mime?
I still didnt get an echo back, did it make the list?
On Fri, 2006-01-12 at 13:49 +0100, Thomas Graf wrote:
> I can't see why this should be required. genl_register_ops()
> enforces a unique command id
> and genl_ops->cmd is u8 so there is no way to register more than
> 256 commands anyway.
By mistake during the tutorial, i had the id at something like 321.
It registered fine but then listing the command showed it with a
different id than what i thought it should be. I think it chops off
all the bystes other than the LS one - which is not a good error
check.
The compiler will whine actually. If you ignore it (perhaps not seeing
the warning in a mass compile) it registers just fine.
cheers,
jamal
next prev parent reply other threads:[~2006-12-01 14:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-01 11:30 [G[PATCH 1/2][ENETLINK] max cmd boundary chec jamal
2006-12-01 12:49 ` Thomas Graf
2006-12-01 14:30 ` jamal [this message]
2006-12-01 14:40 ` Thomas Graf
2006-12-01 14:52 ` jamal
2006-12-01 15:16 ` Thomas Graf
2006-12-01 15:54 ` jamal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1164983427.3562.36.camel@localhost \
--to=hadi@cyberus.ca \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.