From: jamal <hadi@cyberus.ca>
To: Thomas Graf <tgraf@suug.ch>
Cc: David Miller <davem@davemloft.net>, netdev@vger.kernel.org
Subject: Re: [G[PATCH 1/2][ENETLINK] max cmd boundary chec
Date: Fri, 01 Dec 2006 09:52:38 -0500 [thread overview]
Message-ID: <1164984758.3562.57.camel@localhost> (raw)
In-Reply-To: <20061201144058.GG8693@postel.suug.ch>
On Fri, 2006-01-12 at 15:40 +0100, Thomas Graf wrote:
> There is no way to fix this in the interface. If you do u8 op = 312
> and ignore the compiler warning which states that the value has been
> truncated it can't be helped, the interface will see op = 56
Indeed I think this is what i saw.
312 == 0x138
This will be chopped to 0x38 == decimal 56
> and register it normally.
> It is logically impossible to have more than 256
> entries on the cmd list,
> the boundry check you're adding is completely
> useless.
You cannot have more than 256 commands because 0x138 and 0x38 are
treated as the same command. So does 0x238, 0x1138...
It is useless/unneeded if the register ops will always see the chopped
value. Is this so?
cheers,
jamal
next prev parent reply other threads:[~2006-12-01 14:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-01 11:30 [G[PATCH 1/2][ENETLINK] max cmd boundary chec jamal
2006-12-01 12:49 ` Thomas Graf
2006-12-01 14:30 ` jamal
2006-12-01 14:40 ` Thomas Graf
2006-12-01 14:52 ` jamal [this message]
2006-12-01 15:16 ` Thomas Graf
2006-12-01 15:54 ` jamal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1164984758.3562.57.camel@localhost \
--to=hadi@cyberus.ca \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.