From: David Howells <dhowells@redhat.com>
To: chenxiaosong.chenxiaosong@linux.dev
Cc: dhowells@redhat.com, smfrench@gmail.com, linkinjeon@kernel.org,
pc@manguebit.org, ronniesahlberg@gmail.com,
sprasad@microsoft.com, tom@talpey.com, bharathsm@microsoft.com,
senozhatsky@chromium.org, linux-cifs@vger.kernel.org,
ChenXiaoSong <chenxiaosong@kylinos.cn>
Subject: Re: [PATCH v5 5/5] smb/client: introduce KUnit test to check search result of smb2_error_map_table
Date: Wed, 24 Dec 2025 08:22:10 +0000 [thread overview]
Message-ID: <1168035.1766564530@warthog.procyon.org.uk> (raw)
In-Reply-To: <20251224023145.608165-6-chenxiaosong.chenxiaosong@linux.dev>
chenxiaosong.chenxiaosong@linux.dev wrote:
> +
> +#if IS_ENABLED(CONFIG_SMB_KUNIT_TESTS)
> +#include "smb2maperror_test.c"
> +#endif /* CONFIG_SMB_KUNIT_TESTS */
This feels weird, but I think I can see what you're doing. I guess it's not a
kunit test in loadable module form?
> + for (i = 0; i < err_map_num; i++) {
ARRAY_SIZE(smb2_error_map_table).
David
next prev parent reply other threads:[~2025-12-24 8:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-24 2:31 [PATCH v5 0/5] smb: improve search speed of SMB2 maperror chenxiaosong.chenxiaosong
2025-12-24 2:31 ` [PATCH v5 1/5] cifs: Label SMB2 statuses with errors chenxiaosong.chenxiaosong
2025-12-24 2:31 ` [PATCH v5 2/5] cifs: Autogenerate SMB2 error mapping table chenxiaosong.chenxiaosong
2025-12-24 2:31 ` [PATCH v5 3/5] smb/client: check whether smb2_error_map_table is sorted in ascending order chenxiaosong.chenxiaosong
2025-12-24 8:10 ` David Howells
2025-12-24 2:31 ` [PATCH v5 4/5] smb/client: use bsearch() to find target in smb2_error_map_table chenxiaosong.chenxiaosong
2025-12-24 8:17 ` David Howells
2025-12-24 2:31 ` [PATCH v5 5/5] smb/client: introduce KUnit test to check search result of smb2_error_map_table chenxiaosong.chenxiaosong
2025-12-24 8:22 ` David Howells [this message]
2025-12-24 8:54 ` ChenXiaoSong
2025-12-24 15:08 ` ChenXiaoSong
[not found] ` <CAH2r5mu604z2DSdfYYaCoRJ16AdCdUdmNUDYEAU4Z5mXttEFSA@mail.gmail.com>
2025-12-24 15:29 ` ChenXiaoSong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1168035.1766564530@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=bharathsm@microsoft.com \
--cc=chenxiaosong.chenxiaosong@linux.dev \
--cc=chenxiaosong@kylinos.cn \
--cc=linkinjeon@kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=pc@manguebit.org \
--cc=ronniesahlberg@gmail.com \
--cc=senozhatsky@chromium.org \
--cc=smfrench@gmail.com \
--cc=sprasad@microsoft.com \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.