From: chenxiaosong.chenxiaosong@linux.dev
To: smfrench@gmail.com, linkinjeon@kernel.org, pc@manguebit.org,
ronniesahlberg@gmail.com, sprasad@microsoft.com, tom@talpey.com,
bharathsm@microsoft.com, senozhatsky@chromium.org,
dhowells@redhat.com
Cc: linux-cifs@vger.kernel.org, ChenXiaoSong <chenxiaosong@kylinos.cn>
Subject: [PATCH v5 5/5] smb/client: introduce KUnit test to check search result of smb2_error_map_table
Date: Wed, 24 Dec 2025 10:31:44 +0800 [thread overview]
Message-ID: <20251224023145.608165-6-chenxiaosong.chenxiaosong@linux.dev> (raw)
In-Reply-To: <20251224023145.608165-1-chenxiaosong.chenxiaosong@linux.dev>
From: ChenXiaoSong <chenxiaosong@kylinos.cn>
The KUnit test are executed when cifs.ko is loaded.
Just like `fs/ext4/mballoc.c` includes `fs/ext4/mballoc-test.c`.
`smb2maperror.c` also includes `smb2maperror_test.c`, allowing KUnit
tests to access any functions and variables in `smb2maperror.c`.
The maperror_test_check_search() checks whether all elements can be
correctly found in the array.
Signed-off-by: ChenXiaoSong <chenxiaosong@kylinos.cn>
---
fs/smb/Kconfig | 17 +++++++++++
fs/smb/client/smb2maperror.c | 4 +++
fs/smb/client/smb2maperror_test.c | 48 +++++++++++++++++++++++++++++++
3 files changed, 69 insertions(+)
create mode 100644 fs/smb/client/smb2maperror_test.c
diff --git a/fs/smb/Kconfig b/fs/smb/Kconfig
index ef425789fa6a..85f7ad5fbc5e 100644
--- a/fs/smb/Kconfig
+++ b/fs/smb/Kconfig
@@ -9,3 +9,20 @@ config SMBFS
tristate
default y if CIFS=y || SMB_SERVER=y
default m if CIFS=m || SMB_SERVER=m
+
+config SMB_KUNIT_TESTS
+ tristate "KUnit tests for SMB" if !KUNIT_ALL_TESTS
+ depends on SMBFS && KUNIT
+ default KUNIT_ALL_TESTS
+ help
+ This builds the SMB KUnit tests.
+
+ KUnit tests run during boot and output the results to the debug log
+ in TAP format (https://testanything.org/). Only useful for kernel devs
+ running KUnit test harness and are not for inclusion into a production
+ build.
+
+ For more information on KUnit and unit tests in general please refer
+ to the KUnit documentation in Documentation/dev-tools/kunit/.
+
+ If unsure, say N.
diff --git a/fs/smb/client/smb2maperror.c b/fs/smb/client/smb2maperror.c
index e47564cc3a04..e71ee23400e8 100644
--- a/fs/smb/client/smb2maperror.c
+++ b/fs/smb/client/smb2maperror.c
@@ -114,3 +114,7 @@ int smb2_init_maperror(void)
return 0;
}
+
+#if IS_ENABLED(CONFIG_SMB_KUNIT_TESTS)
+#include "smb2maperror_test.c"
+#endif /* CONFIG_SMB_KUNIT_TESTS */
diff --git a/fs/smb/client/smb2maperror_test.c b/fs/smb/client/smb2maperror_test.c
new file mode 100644
index 000000000000..bb2ae4f32611
--- /dev/null
+++ b/fs/smb/client/smb2maperror_test.c
@@ -0,0 +1,48 @@
+// SPDX-License-Identifier: LGPL-2.1
+/*
+ *
+ * KUnit tests of SMB2 maperror
+ *
+ * Copyright (C) 2025 KylinSoft Co., Ltd. All rights reserved.
+ * Author(s): ChenXiaoSong <chenxiaosong@kylinos.cn>
+ *
+ */
+
+#include <kunit/test.h>
+
+static void
+test_cmp_map(struct kunit *test, struct status_to_posix_error *expect)
+{
+ struct status_to_posix_error *result;
+
+ result = smb2_get_err_map(expect->smb2_status);
+ KUNIT_EXPECT_PTR_NE(test, NULL, result);
+ KUNIT_EXPECT_EQ(test, expect->smb2_status, result->smb2_status);
+ KUNIT_EXPECT_EQ(test, expect->posix_error, result->posix_error);
+ KUNIT_EXPECT_STREQ(test, expect->status_string, result->status_string);
+}
+
+static void maperror_test_check_search(struct kunit *test)
+{
+ unsigned int i;
+ struct status_to_posix_error expect;
+
+ for (i = 0; i < err_map_num; i++) {
+ expect = smb2_error_map_table[i];
+ test_cmp_map(test, &expect);
+ }
+}
+
+static struct kunit_case maperror_test_cases[] = {
+ KUNIT_CASE(maperror_test_check_search),
+ {}
+};
+
+static struct kunit_suite maperror_suite = {
+ .name = "smb2_maperror",
+ .test_cases = maperror_test_cases,
+};
+
+kunit_test_suite(maperror_suite);
+
+MODULE_LICENSE("GPL");
--
2.43.0
next prev parent reply other threads:[~2025-12-24 2:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-24 2:31 [PATCH v5 0/5] smb: improve search speed of SMB2 maperror chenxiaosong.chenxiaosong
2025-12-24 2:31 ` [PATCH v5 1/5] cifs: Label SMB2 statuses with errors chenxiaosong.chenxiaosong
2025-12-24 2:31 ` [PATCH v5 2/5] cifs: Autogenerate SMB2 error mapping table chenxiaosong.chenxiaosong
2025-12-24 2:31 ` [PATCH v5 3/5] smb/client: check whether smb2_error_map_table is sorted in ascending order chenxiaosong.chenxiaosong
2025-12-24 8:10 ` David Howells
2025-12-24 2:31 ` [PATCH v5 4/5] smb/client: use bsearch() to find target in smb2_error_map_table chenxiaosong.chenxiaosong
2025-12-24 8:17 ` David Howells
2025-12-24 2:31 ` chenxiaosong.chenxiaosong [this message]
2025-12-24 8:22 ` [PATCH v5 5/5] smb/client: introduce KUnit test to check search result of smb2_error_map_table David Howells
2025-12-24 8:54 ` ChenXiaoSong
2025-12-24 15:08 ` ChenXiaoSong
[not found] ` <CAH2r5mu604z2DSdfYYaCoRJ16AdCdUdmNUDYEAU4Z5mXttEFSA@mail.gmail.com>
2025-12-24 15:29 ` ChenXiaoSong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251224023145.608165-6-chenxiaosong.chenxiaosong@linux.dev \
--to=chenxiaosong.chenxiaosong@linux.dev \
--cc=bharathsm@microsoft.com \
--cc=chenxiaosong@kylinos.cn \
--cc=dhowells@redhat.com \
--cc=linkinjeon@kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=pc@manguebit.org \
--cc=ronniesahlberg@gmail.com \
--cc=senozhatsky@chromium.org \
--cc=smfrench@gmail.com \
--cc=sprasad@microsoft.com \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.