From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Nick Piggin <npiggin@suse.de>
Cc: Linux Memory Management <linux-mm@kvack.org>,
Linux Kernel <linux-kernel@vger.kernel.org>,
Linux Filesystems <linux-fsdevel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>
Subject: Re: [patch 6/10] mm: be sure to trim blocks
Date: Tue, 16 Jan 2007 20:14:16 +0100 [thread overview]
Message-ID: <1168974857.5975.36.camel@lappy> (raw)
In-Reply-To: <1168968985.5975.30.camel@lappy>
On Tue, 2007-01-16 at 18:36 +0100, Peter Zijlstra wrote:
> buf, bytes);
> > @@ -1935,10 +1922,9 @@ generic_file_buffered_write(struct kiocb
> > cur_iov, iov_offset, bytes);
> > flush_dcache_page(page);
> > status = a_ops->commit_write(file, page, offset, offset+bytes);
> > - if (status == AOP_TRUNCATED_PAGE) {
> > - page_cache_release(page);
> > - continue;
> > - }
> > + if (unlikely(status))
> > + goto fs_write_aop_error;
> > +
>
> I don't think this is correct, see how status >= 0 is used a few lines
> downwards. Perhaps something along the lines of an
> is_positive_aop_return() to test on?
Hmm, if commit_write() will never return non error positive values then
this and 8/10 look sane.
WARNING: multiple messages have this Message-ID (diff)
From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Nick Piggin <npiggin@suse.de>
Cc: Linux Memory Management <linux-mm@kvack.org>,
Linux Kernel <linux-kernel@vger.kernel.org>,
Linux Filesystems <linux-fsdevel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>
Subject: Re: [patch 6/10] mm: be sure to trim blocks
Date: Tue, 16 Jan 2007 20:14:16 +0100 [thread overview]
Message-ID: <1168974857.5975.36.camel@lappy> (raw)
In-Reply-To: <1168968985.5975.30.camel@lappy>
On Tue, 2007-01-16 at 18:36 +0100, Peter Zijlstra wrote:
> buf, bytes);
> > @@ -1935,10 +1922,9 @@ generic_file_buffered_write(struct kiocb
> > cur_iov, iov_offset, bytes);
> > flush_dcache_page(page);
> > status = a_ops->commit_write(file, page, offset, offset+bytes);
> > - if (status == AOP_TRUNCATED_PAGE) {
> > - page_cache_release(page);
> > - continue;
> > - }
> > + if (unlikely(status))
> > + goto fs_write_aop_error;
> > +
>
> I don't think this is correct, see how status >= 0 is used a few lines
> downwards. Perhaps something along the lines of an
> is_positive_aop_return() to test on?
Hmm, if commit_write() will never return non error positive values then
this and 8/10 look sane.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2007-01-16 19:14 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-13 3:24 [patch 0/10] buffered write deadlock fix Nick Piggin
2007-01-13 3:24 ` Nick Piggin
2007-01-13 3:24 ` [patch 1/10] fs: libfs buffered write leak fix Nick Piggin
2007-01-13 3:24 ` Nick Piggin
2007-01-13 3:24 ` [patch 2/10] mm: revert "generic_file_buffered_write(): handle zero length iovec segments" Nick Piggin
2007-01-13 3:24 ` Nick Piggin, Andrew Morton
2007-01-13 3:24 ` [patch 3/10] mm: revert "generic_file_buffered_write(): deadlock on vectored write" Nick Piggin
2007-01-13 3:24 ` Nick Piggin, Andrew Morton
2007-01-13 3:24 ` [patch 4/10] mm: generic_file_buffered_write cleanup Nick Piggin
2007-01-13 3:24 ` Nick Piggin, Andrew Morton
2007-01-13 3:25 ` [patch 5/10] mm: debug write deadlocks Nick Piggin
2007-01-13 3:25 ` Nick Piggin
2007-01-13 3:25 ` [patch 6/10] mm: be sure to trim blocks Nick Piggin
2007-01-13 3:25 ` Nick Piggin
2007-01-14 14:25 ` Dmitriy Monakhov
2007-01-14 14:25 ` Dmitriy Monakhov
2007-01-20 3:50 ` Nick Piggin
2007-01-20 3:50 ` Nick Piggin
2007-01-16 17:36 ` Peter Zijlstra
2007-01-16 17:36 ` Peter Zijlstra
2007-01-16 19:14 ` Peter Zijlstra [this message]
2007-01-16 19:14 ` Peter Zijlstra
2007-01-20 3:52 ` Nick Piggin
2007-01-20 3:52 ` Nick Piggin
2007-01-13 3:25 ` [patch 7/10] mm: cleanup pagecache insertion operations Nick Piggin
2007-01-13 3:25 ` Nick Piggin
2007-01-13 3:25 ` [patch 8/10] mm: generic_file_buffered_write cleanup more Nick Piggin
2007-01-13 3:25 ` Nick Piggin
2007-01-13 3:25 ` [patch 9/10] mm: generic_file_buffered_write iovec cleanup Nick Piggin
2007-01-13 3:25 ` Nick Piggin
2007-01-13 3:25 ` [patch 10/10] mm: fix pagecache write deadlocks Nick Piggin
2007-01-13 3:25 ` Nick Piggin
2007-01-14 3:59 ` Nick Piggin
2007-01-14 3:59 ` Nick Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1168974857.5975.36.camel@lappy \
--to=a.p.zijlstra@chello.nl \
--cc=akpm@osdl.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=npiggin@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.