All of lore.kernel.org
 help / color / mirror / Atom feed
* I2C Warning on a 405GPr based board with actual 2.6.20-rc5 Kernel
@ 2007-01-17 15:10 Heiko Schocher
  0 siblings, 0 replies; only message in thread
From: Heiko Schocher @ 2007-01-17 15:10 UTC (permalink / raw)
  To: linuxppc-embedded

Hello,

I have a 405Gpr based Board and use the I2C Bus. Today I tried the Linux
Kernel version 2.6.20-rc5, and get the following Warning:

i2c /dev entries driver
IBM IIC driver v2.1
**WARNING** I2C adapter driver [IBM IIC] forgot to specify physical
device; fix it!
ibm-iic0: using standard (100 kHz) mode

Hmm.. I solved it with the following patch, but I don t know if this is
the right way.

diff --git a/drivers/i2c/busses/i2c-ibm_iic.c
b/drivers/i2c/busses/i2c-ibm_iic.c
index 1898e99..140d7fe 100644
--- a/drivers/i2c/busses/i2c-ibm_iic.c
+++ b/drivers/i2c/busses/i2c-ibm_iic.c
@@ -35,6 +35,7 @@
 #include <linux/slab.h>
 #include <linux/init.h>
 #include <linux/interrupt.h>
+#include <linux/platform_device.h>
 #include <asm/irq.h>
 #include <asm/io.h>
 #include <linux/i2c.h>
@@ -737,6 +738,9 @@ static int __devinit iic_probe(struct ocp_device
*ocp){
 	adap->timeout = 1;
 	adap->retries = 1;
 
+	if (adap->dev.parent == NULL) {
+		adap->dev.parent = &platform_bus;
+	}
 	if ((ret = i2c_add_adapter(adap)) != 0){
 		printk(KERN_CRIT "ibm-iic%d: failed to register i2c adapter\n",
 			dev->idx);

thanks
Heiko

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2007-01-17 15:27 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-01-17 15:10 I2C Warning on a 405GPr based board with actual 2.6.20-rc5 Kernel Heiko Schocher

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.