From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
Cc: Andrew Morton <akpm@osdl.org>,
linuxppc-dev@ozlabs.org, paulus@samba.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Missing include in include/asm-powerpc/prom.h
Date: Tue, 06 Feb 2007 07:14:29 +1100 [thread overview]
Message-ID: <1170706469.2620.124.camel@localhost.localdomain> (raw)
In-Reply-To: <20070205142905.GA31392@Krystal>
On Mon, 2007-02-05 at 09:29 -0500, Mathieu Desnoyers wrote:
> Missing include in include/asm-powerpc/prom.h
>
> include/asm-powerpc/prom.h needs to include asm/irq.h because it uses
> irq_of_parse_and_map and NO_IRQ. It applies on 2.6.20.
I'd rather not do that.... better to move of_irq_to_resource() to
prom_parse.c
Ben
WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
Cc: linux-kernel@vger.kernel.org, Andrew Morton <akpm@osdl.org>,
paulus@samba.org, linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] Missing include in include/asm-powerpc/prom.h
Date: Tue, 06 Feb 2007 07:14:29 +1100 [thread overview]
Message-ID: <1170706469.2620.124.camel@localhost.localdomain> (raw)
In-Reply-To: <20070205142905.GA31392@Krystal>
On Mon, 2007-02-05 at 09:29 -0500, Mathieu Desnoyers wrote:
> Missing include in include/asm-powerpc/prom.h
>
> include/asm-powerpc/prom.h needs to include asm/irq.h because it uses
> irq_of_parse_and_map and NO_IRQ. It applies on 2.6.20.
I'd rather not do that.... better to move of_irq_to_resource() to
prom_parse.c
Ben
next prev parent reply other threads:[~2007-02-05 20:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-05 14:29 [PATCH] Missing include in include/asm-powerpc/prom.h Mathieu Desnoyers
2007-02-05 20:14 ` Benjamin Herrenschmidt [this message]
2007-02-05 20:14 ` Benjamin Herrenschmidt
2007-02-05 20:56 ` Mathieu Desnoyers
2007-02-05 20:56 ` Mathieu Desnoyers
2007-02-06 0:36 ` Paul Mackerras
2007-02-06 0:36 ` Paul Mackerras
2007-02-06 1:03 ` [PATCH] Powerpc move of_irq_to_resource from prom.h to prom_parse.c Mathieu Desnoyers
2007-02-06 1:03 ` Mathieu Desnoyers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1170706469.2620.124.camel@localhost.localdomain \
--to=benh@kernel.crashing.org \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mathieu.desnoyers@polymtl.ca \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.