From: Thomas Gleixner <tglx@linutronix.de>
To: Thomas Koeller <thomas.koeller@baslerweb.com>
Cc: linux-mtd@lists.infradead.org, linux-mips@linux-mips.org
Subject: Re: [PATCH] eXcite nand flash driver
Date: Sun, 11 Feb 2007 16:44:12 +0100 [thread overview]
Message-ID: <1171208652.3661.2.camel@chaos> (raw)
In-Reply-To: <200702101122.05049.thomas.koeller@baslerweb.com>
On Sat, 2007-02-10 at 11:22 +0100, Thomas Koeller wrote:
> > So I expect an OOPS happens on a regular base.
> I guess it is the 'static void __iomem *tgt = NULL' part that worries
> you? Think about it, that value is never used.
True.
> However, I admit it is somewhat unclean, and therefore I am changing
> it. Updated patch follows.
Yes, it is confusing and looks horrible.
tglx
WARNING: multiple messages have this Message-ID (diff)
From: Thomas Gleixner <tglx@linutronix.de>
To: Thomas Koeller <thomas.koeller@baslerweb.com>
Cc: linux-mips@linux-mips.org, linux-mtd@lists.infradead.org
Subject: Re: [PATCH] eXcite nand flash driver
Date: Sun, 11 Feb 2007 16:44:12 +0100 [thread overview]
Message-ID: <1171208652.3661.2.camel@chaos> (raw)
In-Reply-To: <200702101122.05049.thomas.koeller@baslerweb.com>
On Sat, 2007-02-10 at 11:22 +0100, Thomas Koeller wrote:
> > So I expect an OOPS happens on a regular base.
> I guess it is the 'static void __iomem *tgt = NULL' part that worries
> you? Think about it, that value is never used.
True.
> However, I admit it is somewhat unclean, and therefore I am changing
> it. Updated patch follows.
Yes, it is confusing and looks horrible.
tglx
next prev parent reply other threads:[~2007-02-11 15:44 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-08 0:57 [PATCH] eXcite nand flash driver Thomas Koeller
2007-02-08 8:20 ` Ulrich Eckhardt
2007-02-08 10:20 ` Thomas Koeller
2007-02-08 13:50 ` Josh Boyer
2007-02-08 13:50 ` Josh Boyer
2007-02-08 13:55 ` Artem Bityutskiy
2007-02-08 13:55 ` Artem Bityutskiy
2007-02-08 15:48 ` Thomas Gleixner
2007-02-08 15:48 ` Thomas Gleixner
2007-02-10 10:22 ` Thomas Koeller
2007-02-10 10:22 ` Thomas Koeller
2007-02-11 15:44 ` Thomas Gleixner [this message]
2007-02-11 15:44 ` Thomas Gleixner
-- strict thread matches above, loose matches on Subject: below --
2007-02-10 10:21 Thomas Koeller
2007-02-11 15:50 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1171208652.3661.2.camel@chaos \
--to=tglx@linutronix.de \
--cc=linux-mips@linux-mips.org \
--cc=linux-mtd@lists.infradead.org \
--cc=thomas.koeller@baslerweb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.