Re: [PATCH 02/10] powerpc: Add device tree fixups for the EFIKA

[Benjamin Herrenschmidt <benh@kernel.crashing.org>]

On Mon, 2007-02-12 at 17:06 -0600, Kumar Gala wrote:
> On Feb 12, 2007, at 4:13 PM, Sylvain Munaut wrote:
> 
> > We make the efika device tree compliant with the defined bindings
> > (at least compliant enough). This is mostly done by mangling
> > the device_type and compatible properties, but also adding
> > some missing bits.
> >
> > Signed-off-by: Sylvain Munaut <tnt@246tNt.com>
> > Acked-by: Grant Likely <grant.likely@secretlab.ca>
> > ---
> >  arch/powerpc/kernel/prom_init.c |   81 ++++++++++++++++++++++++++++ 
> > +++++++++++
> >  1 files changed, 81 insertions(+), 0 deletions(-)
> >
> > diff --git a/arch/powerpc/kernel/prom_init.c b/arch/powerpc/kernel/ 
> > prom_init.c
> > index 520ef42..4fb5938 100644
> > --- a/arch/powerpc/kernel/prom_init.c
> > +++ b/arch/powerpc/kernel/prom_init.c
> > @@ -2117,11 +2117,92 @@ #else
> >  #define fixup_device_tree_pmac()
> >  #endif
> >
> > +#ifdef CONFIG_PPC_EFIKA
> >
> 
> can't this EFIKA fixup live in efika board code (platforms/52xx/efika*)

Nah, those fixups belong in prom_init which itself may endup being split
in the boot wrappers on day ...

Ben.