From: Sylvain Munaut <tnt@246tNt.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Linux PPC Dev ML <linuxppc-dev@ozlabs.org>,
Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH 08/10] macintosh: Use the new of_device common uevent handler
Date: Tue, 27 Mar 2007 09:11:12 +0200 [thread overview]
Message-ID: <4608C390.5080205@246tNt.com> (raw)
In-Reply-To: <1174977009.14065.0.camel@localhost.localdomain>
Benjamin Herrenschmidt wrote:
> On Mon, 2007-02-12 at 23:13 +0100, Sylvain Munaut wrote:
>
>> The generation of the uevent is now common to all bus using
>> of_device.
>>
>
> I haven't managed to figure out why so far (a quick inspection of the
> code didn't show anything obvious) but with your patch, the snd-aoa
> driver fails to auto-load at boot... might be the modalias being broken,
> dunno.
>
>
Hi Ben,
Thanks for testing. That issue looks weird.
I had a look at sound/aoa/soundbus/i2sbus/i2sbus-core.c , which is the
only part of aoa with of_device_id and I see that it uses the
MODULE_ALIAS directly :
MODULE_ALIAS("of:Ni2sTi2sC");
instead of using
MODULE_DEVICE_TABLE(of, i2sbus_match);
and letting modpost do the job. Because that module alias is not the one
that's gonna be generated by modpost.
But that doesn't explain why it worked before and not now ...
Sylvain
next prev parent reply other threads:[~2007-03-27 7:11 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-12 22:13 [PATCH 00/10] Mainly 52xx patches for 2.6.21 (but not only) Sylvain Munaut
2007-02-12 22:13 ` [PATCH 01/10] powerpc/serial: Dispose irq mapping when done in mpc52xx_serial.c Sylvain Munaut
2007-02-12 22:13 ` [PATCH 02/10] powerpc: Add device tree fixups for the EFIKA Sylvain Munaut
2007-02-12 22:13 ` [PATCH 03/10] powerpc: Restore 'proper' link order in platform Sylvain Munaut
2007-02-12 22:13 ` [PATCH 04/10] powerpc: Use common 52xx of_platform probe code for EFIKA Sylvain Munaut
2007-02-12 22:13 ` [PATCH 05/10] powerpc: Fix unbalanced of_node_{get, put} in efika-setup.c Sylvain Munaut
2007-02-12 22:13 ` [PATCH 06/10] powerpc: Small cleanup of EFIKA platform Sylvain Munaut
2007-02-12 22:13 ` [PATCH 07/10] powerpc: Add a unified uevent handler for bus based on of_device Sylvain Munaut
2007-02-12 22:13 ` [PATCH 08/10] macintosh: Use the new of_device common uevent handler Sylvain Munaut
2007-02-12 22:13 ` [PATCH 09/10] powerpc: Add uevent handler for of_platform_bus Sylvain Munaut
2007-02-12 22:13 ` [PATCH 10/10] powerpc: Add uevent handler for ibmebus Sylvain Munaut
2007-03-29 14:46 ` Olaf Hering
2007-03-30 11:27 ` Hoang-Nam Nguyen
2007-03-30 11:45 ` Sylvain Munaut
2007-03-27 6:30 ` [PATCH 08/10] macintosh: Use the new of_device common uevent handler Benjamin Herrenschmidt
2007-03-27 7:11 ` Sylvain Munaut [this message]
2007-03-28 10:29 ` Johannes Berg
2007-03-28 10:58 ` Sylvain Munaut
2007-03-28 11:10 ` Johannes Berg
2007-02-12 23:06 ` [PATCH 02/10] powerpc: Add device tree fixups for the EFIKA Kumar Gala
2007-02-12 23:11 ` Sylvain Munaut
2007-02-12 23:18 ` Benjamin Herrenschmidt
2007-02-12 23:12 ` Benjamin Herrenschmidt
2007-02-12 23:25 ` Sylvain Munaut
2007-02-13 0:20 ` Benjamin Herrenschmidt
2007-02-16 16:44 ` Segher Boessenkool
2007-02-12 23:10 ` [PATCH 01/10] powerpc/serial: Dispose irq mapping when done in mpc52xx_serial.c Benjamin Herrenschmidt
2007-02-15 22:18 ` [PATCH] " Sylvain Munaut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4608C390.5080205@246tNt.com \
--to=tnt@246tnt.com \
--cc=benh@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.