* Re: [Xen-staging] [xen-unstable] Add iso9660 support to libfsimage.
[not found] <200702211446.l1LEkLls014186@latara.uk.xensource.com>
@ 2007-02-21 18:34 ` Alex Williamson
2007-02-21 18:47 ` John Levon
0 siblings, 1 reply; 5+ messages in thread
From: Alex Williamson @ 2007-02-21 18:34 UTC (permalink / raw)
To: xen-devel; +Cc: john.levon
On Wed, 2007-02-21 at 14:46 +0000, Xen staging patchbot-unstable wrote:
> # HG changeset patch
> # User john.levon@xxx
> # Date 1172012044 28800
> # Node ID fe3e024e38f8323c311fbd61710eff3c4b92f514
> # Parent bca284f67702cf46502809f29eb634e2ab6d294f
> Add iso9660 support to libfsimage.
There seems to be some sign-age problems introduced here. I'm
surprised the staging tests didn't hit them too. On ia64 it fails to
build:
gcc -DPIC -O2 -fomit-frame-pointer -DNDEBUG -std=gnu99 -Wall -Wstrict-prototypes -Wno-unused-value -Wdeclaration-after-statement -D__XEN_TOOLS__ -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -I../../../tools/libfsimage/common/ -Werror -Wp,-MD,.fsys_iso9660.opic.d -fPIC -c -o fsys_iso9660.opic fsys_iso9660.c
cc1: warnings being treated as errors
fsys_iso9660.c: In function 'iso9660_dir':
fsys_iso9660.c:187: warning: pointer targets in initialization differ in signedness
fsys_iso9660.c:212: warning: pointer targets in assignment differ in signedness
fsys_iso9660.c:240: warning: pointer targets in assignment differ in signedness
fsys_iso9660.c:341: warning: pointer targets in assignment differ in signedness
fsys_iso9660.c:343: warning: pointer targets in assignment differ in signedness
fsys_iso9660.c:345: warning: pointer targets in passing argument 5 of 'iso9660_devread' differ in signedness
make[4]: *** [fsys_iso9660.opic] Error 1
make[4]: Leaving directory `/root/xen-unstable-build/tmp-xen-unstable.hg/tools/libfsimage/iso9660'
make[3]: *** [install] Error 2
make[3]: Leaving directory `/root/xen-unstable-build/tmp-xen-unstable.hg/tools/libfsimage'
make[2]: *** [install] Error 2
make[2]: Leaving directory `/root/xen-unstable-build/tmp-xen-unstable.hg/tools'
make[1]: *** [install-tools] Error 2
make[1]: Leaving directory `/root/xen-unstable-build/tmp-xen-unstable.hg'
make: *** [world] Error 2
Thanks,
Alex
--
Alex Williamson HP Open Source & Linux Org.
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [Xen-staging] [xen-unstable] Add iso9660 support to libfsimage.
2007-02-21 18:34 ` [Xen-staging] [xen-unstable] Add iso9660 support to libfsimage Alex Williamson
@ 2007-02-21 18:47 ` John Levon
2007-02-21 18:42 ` Alex Williamson
0 siblings, 1 reply; 5+ messages in thread
From: John Levon @ 2007-02-21 18:47 UTC (permalink / raw)
To: Alex Williamson; +Cc: xen-devel
On Wed, Feb 21, 2007 at 11:34:39AM -0700, Alex Williamson wrote:
> > # HG changeset patch
> > # User john.levon@xxx
> > # Date 1172012044 28800
> > # Node ID fe3e024e38f8323c311fbd61710eff3c4b92f514
> > # Parent bca284f67702cf46502809f29eb634e2ab6d294f
> > Add iso9660 support to libfsimage.
>
> There seems to be some sign-age problems introduced here. I'm
> surprised the staging tests didn't hit them too. On ia64 it fails to
> build:
I suppose you're using a later gcc than I am (or grub is!). It compiles cleanly
with gcc 3.4.3.
regards
john
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Xen-staging] [xen-unstable] Add iso9660 support to libfsimage.
2007-02-21 18:47 ` John Levon
@ 2007-02-21 18:42 ` Alex Williamson
2007-02-21 18:49 ` Keir Fraser
0 siblings, 1 reply; 5+ messages in thread
From: Alex Williamson @ 2007-02-21 18:42 UTC (permalink / raw)
To: John Levon; +Cc: xen-devel
On Wed, 2007-02-21 at 18:47 +0000, John Levon wrote:
> On Wed, Feb 21, 2007 at 11:34:39AM -0700, Alex Williamson wrote:
>
> > > # HG changeset patch
> > > # User john.levon@xxx
> > > # Date 1172012044 28800
> > > # Node ID fe3e024e38f8323c311fbd61710eff3c4b92f514
> > > # Parent bca284f67702cf46502809f29eb634e2ab6d294f
> > > Add iso9660 support to libfsimage.
> >
> > There seems to be some sign-age problems introduced here. I'm
> > surprised the staging tests didn't hit them too. On ia64 it fails to
> > build:
>
> I suppose you're using a later gcc than I am (or grub is!). It compiles cleanly
> with gcc 3.4.3.
Yep, 4.1.2. Thanks,
Alex
--
Alex Williamson HP Open Source & Linux Org.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Re: [Xen-staging] [xen-unstable] Add iso9660 support to libfsimage.
2007-02-21 18:42 ` Alex Williamson
@ 2007-02-21 18:49 ` Keir Fraser
2007-02-21 18:52 ` Alex Williamson
0 siblings, 1 reply; 5+ messages in thread
From: Keir Fraser @ 2007-02-21 18:49 UTC (permalink / raw)
To: Alex Williamson, John Levon; +Cc: xen-devel
On 21/2/07 18:42, "Alex Williamson" <alex.williamson@hp.com> wrote:
>> I suppose you're using a later gcc than I am (or grub is!). It compiles
>> cleanly
>> with gcc 3.4.3.
>
> Yep, 4.1.2. Thanks,
I can repro and will fix.
-- Keir
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Re: [Xen-staging] [xen-unstable] Add iso9660 support to libfsimage.
2007-02-21 18:49 ` Keir Fraser
@ 2007-02-21 18:52 ` Alex Williamson
0 siblings, 0 replies; 5+ messages in thread
From: Alex Williamson @ 2007-02-21 18:52 UTC (permalink / raw)
To: Keir Fraser; +Cc: xen-devel, John Levon
On Wed, 2007-02-21 at 18:49 +0000, Keir Fraser wrote:
>
>
> On 21/2/07 18:42, "Alex Williamson" <alex.williamson@hp.com> wrote:
>
> >> I suppose you're using a later gcc than I am (or grub is!). It compiles
> >> cleanly
> >> with gcc 3.4.3.
> >
> > Yep, 4.1.2. Thanks,
>
> I can repro and will fix.
Thanks Keir!
--
Alex Williamson HP Open Source & Linux Org.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2007-02-21 18:52 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <200702211446.l1LEkLls014186@latara.uk.xensource.com>
2007-02-21 18:34 ` [Xen-staging] [xen-unstable] Add iso9660 support to libfsimage Alex Williamson
2007-02-21 18:47 ` John Levon
2007-02-21 18:42 ` Alex Williamson
2007-02-21 18:49 ` Keir Fraser
2007-02-21 18:52 ` Alex Williamson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.