* s390 allmodconfig
@ 2007-03-02 8:18 Andrew Morton
2007-03-02 8:25 ` Andrew Morton
0 siblings, 1 reply; 14+ messages in thread
From: Andrew Morton @ 2007-03-02 8:18 UTC (permalink / raw)
To: Marcel Holtmann, John W. Linville, Michael Buesch, Richard Purdie; +Cc: netdev
Not sure who to blame for all of this...
net/bluetooth/hidp/Kconfig:4:warning: 'select' used by config symbol 'BT_HIDP' refer to undefined symbol 'HID'
net/mac80211/Kconfig:17:warning: 'select' used by config symbol 'MAC80211_LEDS' refer to undefined symbol 'NEW_LEDS'
net/mac80211/Kconfig:18:warning: 'select' used by config symbol 'MAC80211_LEDS' refer to undefined symbol 'LEDS_TRIGGERS'
drivers/net/Kconfig:1435:warning: 'select' used by config symbol 'B44' refer to undefined symbol 'SSB'
drivers/net/wireless/bcm43xx/Kconfig:5:warning: 'select' used by config symbol 'BCM43XX' refer to undefined symbol 'HW_RANDOM'
drivers/net/wireless/mac80211/bcm43xx/Kconfig:13:warning: 'select' used by config symbol 'BCM43XX_MAC80211_PCI' refer to undefined symbol 'SSB_PCIHOST'
drivers/net/wireless/mac80211/bcm43xx/Kconfig:14:warning: 'select' used by config symbol 'BCM43XX_MAC80211_PCI' refer to undefined symbol 'SSB_DRIVER_PCICORE'
drivers/net/wireless/mac80211/bcm43xx/Kconfig:27:warning: 'select' used by config symbol 'BCM43XX_MAC80211_PCMCIA' refer to undefined symbol 'SSB_PCMCIAHOST'
drivers/net/wireless/mac80211/bcm43xx/Kconfig:5:warning: 'select' used by config symbol 'BCM43XX_MAC80211' refer to undefined symbol 'SSB'
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: s390 allmodconfig
2007-03-02 8:18 s390 allmodconfig Andrew Morton
@ 2007-03-02 8:25 ` Andrew Morton
2007-03-02 10:32 ` Richard Purdie
2007-03-02 10:38 ` Johannes Berg
0 siblings, 2 replies; 14+ messages in thread
From: Andrew Morton @ 2007-03-02 8:25 UTC (permalink / raw)
To: Marcel Holtmann, John W. Linville, Michael Buesch, Richard Purdie,
netdev
net/mac80211/ieee80211_led.c: In function 'ieee80211_led_init':
net/mac80211/ieee80211_led.c:38: error: invalid application of 'sizeof' to incomplete type 'struct led_trigger'
net/mac80211/ieee80211_led.c:43: error: dereferencing pointer to incomplete type
net/mac80211/ieee80211_led.c:44: warning: implicit declaration of function 'led_trigger_register'
net/mac80211/ieee80211_led.c:49: error: invalid application of 'sizeof' to incomplete type 'struct led_trigger'
net/mac80211/ieee80211_led.c:54: error: dereferencing pointer to incomplete type
net/mac80211/ieee80211_led.c: In function 'ieee80211_led_exit':
net/mac80211/ieee80211_led.c:64: warning: implicit declaration of function 'led_trigger_unregister'
akpm2:/usr/src/25> grep LED .config
CONFIG_NF_CONNTRACK_ENABLED=m
CONFIG_MAC80211_LEDS=y
Probably related to the Kconfig problems.
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: s390 allmodconfig
2007-03-02 8:25 ` Andrew Morton
@ 2007-03-02 10:32 ` Richard Purdie
2007-03-02 11:01 ` Andrew Morton
2007-03-02 10:38 ` Johannes Berg
1 sibling, 1 reply; 14+ messages in thread
From: Richard Purdie @ 2007-03-02 10:32 UTC (permalink / raw)
To: Andrew Morton; +Cc: Marcel Holtmann, John W. Linville, Michael Buesch, netdev
On Fri, 2007-03-02 at 00:25 -0800, Andrew Morton wrote:
> net/mac80211/ieee80211_led.c: In function 'ieee80211_led_init':
> net/mac80211/ieee80211_led.c:38: error: invalid application of 'sizeof' to incomplete type 'struct led_trigger'
> net/mac80211/ieee80211_led.c:43: error: dereferencing pointer to incomplete type
> net/mac80211/ieee80211_led.c:44: warning: implicit declaration of function 'led_trigger_register'
> net/mac80211/ieee80211_led.c:49: error: invalid application of 'sizeof' to incomplete type 'struct led_trigger'
> net/mac80211/ieee80211_led.c:54: error: dereferencing pointer to incomplete type
> net/mac80211/ieee80211_led.c: In function 'ieee80211_led_exit':
> net/mac80211/ieee80211_led.c:64: warning: implicit declaration of function 'led_trigger_unregister'
>
> akpm2:/usr/src/25> grep LED .config
> CONFIG_NF_CONNTRACK_ENABLED=m
> CONFIG_MAC80211_LEDS=y
>
> Probably related to the Kconfig problems.
Almost certainly. Someone is building some LED trigger/driver without
the LED core enabled which is what that Kconfig warning was about.
Nobody's ever mentioned this driver to me...
Richard
(LED Maintainer)
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: s390 allmodconfig
2007-03-02 8:25 ` Andrew Morton
2007-03-02 10:32 ` Richard Purdie
@ 2007-03-02 10:38 ` Johannes Berg
2007-03-02 11:06 ` Andrew Morton
1 sibling, 1 reply; 14+ messages in thread
From: Johannes Berg @ 2007-03-02 10:38 UTC (permalink / raw)
To: Andrew Morton
Cc: Marcel Holtmann, John W. Linville, Michael Buesch, Richard Purdie,
netdev
On Fri, 2007-03-02 at 00:25 -0800, Andrew Morton wrote:
> Probably related to the Kconfig problems.
Yeah, it is. s390 is funny, it doesn't include drivers/Kconfig, I don't
think anybody of us would have suspected that.
There doesn't seem to be a reason why it shouldn't have drivers/leds
though. drivers/ssb I don't know about, does s390 have pci or pcmcia?
And the bluetooth stuff is also plain weird, I suppose s390 really
should include drivers/hid/Kconfig :)
Same with drivers/char that includes hw_random.
Is there any reason it isn't including drivers/Kconfig?
I can offer below patch to fix the LED trigger problem, it's probably
cleaner to depend on LEDS_TRIGGERS rather than selecting it and
NEW_LEDS.
johannes
--- wireless-dev.orig/net/mac80211/Kconfig 2007-03-02 11:18:45.464333268 +0100
+++ wireless-dev/net/mac80211/Kconfig 2007-03-02 11:33:24.534333268 +0100
@@ -13,9 +13,7 @@ config MAC80211
config MAC80211_LEDS
bool "Enable LED triggers"
- depends on MAC80211
- select NEW_LEDS
- select LEDS_TRIGGERS
+ depends on MAC80211 && LEDS_TRIGGERS
---help---
This option enables a few LED triggers for different
packet receive/transmit events.
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: s390 allmodconfig
2007-03-02 10:32 ` Richard Purdie
@ 2007-03-02 11:01 ` Andrew Morton
0 siblings, 0 replies; 14+ messages in thread
From: Andrew Morton @ 2007-03-02 11:01 UTC (permalink / raw)
To: Richard Purdie; +Cc: Marcel Holtmann, John W. Linville, Michael Buesch, netdev
On Fri, 02 Mar 2007 10:32:32 +0000 Richard Purdie <rpurdie@rpsys.net> wrote:
> On Fri, 2007-03-02 at 00:25 -0800, Andrew Morton wrote:
> > net/mac80211/ieee80211_led.c: In function 'ieee80211_led_init':
> > net/mac80211/ieee80211_led.c:38: error: invalid application of 'sizeof' to incomplete type 'struct led_trigger'
> > net/mac80211/ieee80211_led.c:43: error: dereferencing pointer to incomplete type
> > net/mac80211/ieee80211_led.c:44: warning: implicit declaration of function 'led_trigger_register'
> > net/mac80211/ieee80211_led.c:49: error: invalid application of 'sizeof' to incomplete type 'struct led_trigger'
> > net/mac80211/ieee80211_led.c:54: error: dereferencing pointer to incomplete type
> > net/mac80211/ieee80211_led.c: In function 'ieee80211_led_exit':
> > net/mac80211/ieee80211_led.c:64: warning: implicit declaration of function 'led_trigger_unregister'
> >
> > akpm2:/usr/src/25> grep LED .config
> > CONFIG_NF_CONNTRACK_ENABLED=m
> > CONFIG_MAC80211_LEDS=y
> >
> > Probably related to the Kconfig problems.
>
> Almost certainly. Someone is building some LED trigger/driver without
> the LED core enabled which is what that Kconfig warning was about.
>
> Nobody's ever mentioned this driver to me...
>
It's a mountain of new wireless code in the just-released 2.6.21-rc2-mm1.
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: s390 allmodconfig
2007-03-02 10:38 ` Johannes Berg
@ 2007-03-02 11:06 ` Andrew Morton
2007-03-02 11:11 ` Johannes Berg
0 siblings, 1 reply; 14+ messages in thread
From: Andrew Morton @ 2007-03-02 11:06 UTC (permalink / raw)
To: Johannes Berg, Martin Schwidefsky
Cc: Marcel Holtmann, John W. Linville, Michael Buesch, Richard Purdie,
netdev
On Fri, 02 Mar 2007 11:38:24 +0100 Johannes Berg <johannes@sipsolutions.net> wrote:
> On Fri, 2007-03-02 at 00:25 -0800, Andrew Morton wrote:
>
> > Probably related to the Kconfig problems.
>
> Yeah, it is. s390 is funny, it doesn't include drivers/Kconfig, I don't
> think anybody of us would have suspected that.
>
> There doesn't seem to be a reason why it shouldn't have drivers/leds
> though. drivers/ssb I don't know about, does s390 have pci or pcmcia?
No, s390 doesn't have PCI.
> And the bluetooth stuff is also plain weird, I suppose s390 really
> should include drivers/hid/Kconfig :)
>
> Same with drivers/char that includes hw_random.
>
> Is there any reason it isn't including drivers/Kconfig?
>
s390 is weird ;) There's no way it'll support any of the hardware which you're
working on (until they release the s390 laptop). So all we really want to
do here is to avoid breaking s390 allmodconfig.
> I can offer below patch to fix the LED trigger problem, it's probably
> cleaner to depend on LEDS_TRIGGERS rather than selecting it and
> NEW_LEDS.
>
> johannes
>
> --- wireless-dev.orig/net/mac80211/Kconfig 2007-03-02 11:18:45.464333268 +0100
> +++ wireless-dev/net/mac80211/Kconfig 2007-03-02 11:33:24.534333268 +0100
> @@ -13,9 +13,7 @@ config MAC80211
>
> config MAC80211_LEDS
> bool "Enable LED triggers"
> - depends on MAC80211
> - select NEW_LEDS
> - select LEDS_TRIGGERS
> + depends on MAC80211 && LEDS_TRIGGERS
> ---help---
> This option enables a few LED triggers for different
> packet receive/transmit events.
OK, I'll try that, thanks.
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: s390 allmodconfig
2007-03-02 11:06 ` Andrew Morton
@ 2007-03-02 11:11 ` Johannes Berg
2007-03-02 11:20 ` Andrew Morton
2007-03-02 17:48 ` Martin Schwidefsky
0 siblings, 2 replies; 14+ messages in thread
From: Johannes Berg @ 2007-03-02 11:11 UTC (permalink / raw)
To: Andrew Morton
Cc: Martin Schwidefsky, Marcel Holtmann, John W. Linville,
Michael Buesch, Richard Purdie, netdev
[-- Attachment #1: Type: text/plain, Size: 729 bytes --]
On Fri, 2007-03-02 at 03:06 -0800, Andrew Morton wrote:
> No, s390 doesn't have PCI.
Ok.
> s390 is weird ;) There's no way it'll support any of the hardware which you're
> working on (until they release the s390 laptop). So all we really want to
> do here is to avoid breaking s390 allmodconfig.
Alright. I think we'll probably have to make bcm43xx and b44 depend on
SSB instead of selecting it like the LED trigger stuff below.
But I don't see why s390 can't include hw random, led trigger or even
hid, those are all software features afaict.
> OK, I'll try that, thanks.
Not that it'll actually help get the compile through... bcm43xx will
drop fail and bluetooth probably as well.
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 190 bytes --]
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: s390 allmodconfig
2007-03-02 11:11 ` Johannes Berg
@ 2007-03-02 11:20 ` Andrew Morton
2007-03-02 17:48 ` Martin Schwidefsky
1 sibling, 0 replies; 14+ messages in thread
From: Andrew Morton @ 2007-03-02 11:20 UTC (permalink / raw)
To: Johannes Berg
Cc: Martin Schwidefsky, Marcel Holtmann, John W. Linville,
Michael Buesch, Richard Purdie, netdev
On Fri, 02 Mar 2007 12:11:48 +0100 Johannes Berg <johannes@sipsolutions.net> wrote:
> On Fri, 2007-03-02 at 03:06 -0800, Andrew Morton wrote:
>
> > No, s390 doesn't have PCI.
>
> Ok.
>
> > s390 is weird ;) There's no way it'll support any of the hardware which you're
> > working on (until they release the s390 laptop). So all we really want to
> > do here is to avoid breaking s390 allmodconfig.
>
> Alright. I think we'll probably have to make bcm43xx and b44 depend on
> SSB instead of selecting it like the LED trigger stuff below.
>
> But I don't see why s390 can't include hw random, led trigger or even
> hid, those are all software features afaict.
>
>
> > OK, I'll try that, thanks.
>
> Not that it'll actually help get the compile through... bcm43xx will
> drop fail and bluetooth probably as well.
>
OK, thanks.
fwiw, http://userweb.kernel.org/~akpm/cross-compilers/ has an s390
cross-compiler binary.
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: s390 allmodconfig
2007-03-02 11:11 ` Johannes Berg
2007-03-02 11:20 ` Andrew Morton
@ 2007-03-02 17:48 ` Martin Schwidefsky
1 sibling, 0 replies; 14+ messages in thread
From: Martin Schwidefsky @ 2007-03-02 17:48 UTC (permalink / raw)
To: Johannes Berg
Cc: Andrew Morton, Marcel Holtmann, John W. Linville, Michael Buesch,
Richard Purdie, netdev
On Fri, 2007-03-02 at 12:11 +0100, Johannes Berg wrote:
> On Fri, 2007-03-02 at 03:06 -0800, Andrew Morton wrote:
> > s390 is weird ;) There's no way it'll support any of the hardware which you're
> > working on (until they release the s390 laptop). So all we really want to
> > do here is to avoid breaking s390 allmodconfig.
Well, I would not say "weird" but different. None of the usual device
attachments is present on a s390. That includes memory mapped i/o (!).
> Alright. I think we'll probably have to make bcm43xx and b44 depend on
> SSB instead of selecting it like the LED trigger stuff below.
>
> But I don't see why s390 can't include hw random, led trigger or even
> hid, those are all software features afaict.
True. I'm still sitting on a couple of patches that make s390 use the
standard drivers/Kconfig. The downside of these patches is that I have
to add a lot of "depends on !S390" all over the place.
> > OK, I'll try that, thanks.
>
> Not that it'll actually help get the compile through... bcm43xx will
> drop fail and bluetooth probably as well.
No bcm43xx, no bluetooth on s390..
--
blue skies,
Martin.
Martin Schwidefsky
Linux for zSeries Development & Services
IBM Deutschland Entwicklung GmbH
"Reality continues to ruin my life." - Calvin.
^ permalink raw reply [flat|nested] 14+ messages in thread
* s390 allmodconfig
@ 2008-08-29 7:52 Andrew Morton
[not found] ` <20080829005217.509a6c23.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
0 siblings, 1 reply; 14+ messages in thread
From: Andrew Morton @ 2008-08-29 7:52 UTC (permalink / raw)
To: i2c-GZX6beZjE8VD60Wz+7aTrA; +Cc: Martin Schwidefsky, Heiko Carstens
drivers/i2c/busses/i2c-ocores.c: In function 'oc_setreg':
drivers/i2c/busses/i2c-ocores.c:68: error: implicit declaration of function 'iowrite8'
drivers/i2c/busses/i2c-ocores.c: In function 'oc_getreg':
drivers/i2c/busses/i2c-ocores.c:73: error: implicit declaration of function 'ioread8'
drivers/i2c/busses/i2c-ocores.c: In function 'ocores_i2c_probe':
drivers/i2c/busses/i2c-ocores.c:243: error: implicit declaration of function 'ioremap'
drivers/i2c/busses/i2c-ocores.c:243: warning: assignment makes pointer from integer without a cast
drivers/i2c/busses/i2c-ocores.c:279: error: implicit declaration of function 'iounmap'
Some missing Kconfig dependency. s390 can't do IO :)
_______________________________________________
i2c mailing list
i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org
http://lists.lm-sensors.org/mailman/listinfo/i2c
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: s390 allmodconfig
[not found] ` <20080829005217.509a6c23.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
@ 2008-08-29 8:45 ` Jean Delvare
[not found] ` <20080829104533.0e65f43a-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
0 siblings, 1 reply; 14+ messages in thread
From: Jean Delvare @ 2008-08-29 8:45 UTC (permalink / raw)
To: Andrew Morton
Cc: Martin Schwidefsky, Heiko-cy1Wll9GaHOsTnJN9+BGXg, Carstens,
i2c-GZX6beZjE8VD60Wz+7aTrA
Hi Andrew,
On Fri, 29 Aug 2008 00:52:17 -0700, Andrew Morton wrote:
> drivers/i2c/busses/i2c-ocores.c: In function 'oc_setreg':
> drivers/i2c/busses/i2c-ocores.c:68: error: implicit declaration of function 'iowrite8'
> drivers/i2c/busses/i2c-ocores.c: In function 'oc_getreg':
> drivers/i2c/busses/i2c-ocores.c:73: error: implicit declaration of function 'ioread8'
> drivers/i2c/busses/i2c-ocores.c: In function 'ocores_i2c_probe':
> drivers/i2c/busses/i2c-ocores.c:243: error: implicit declaration of function 'ioremap'
> drivers/i2c/busses/i2c-ocores.c:243: warning: assignment makes pointer from integer without a cast
> drivers/i2c/busses/i2c-ocores.c:279: error: implicit declaration of function 'iounmap'
>
> Some missing Kconfig dependency. s390 can't do IO :)
Where is this failure happening? In Linus' tree, I2C depends on
HAS_IOMEM (which s390 doesn't have), and I2C_OCORES depends on I2C. So
I fail to see how a make allmodconfig can select I2C_OCORES on s390.
Can you share the .config file?
--
Jean Delvare
_______________________________________________
i2c mailing list
i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org
http://lists.lm-sensors.org/mailman/listinfo/i2c
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: s390 allmodconfig
[not found] ` <20080829104533.0e65f43a-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
@ 2008-08-29 9:04 ` Andrew Morton
[not found] ` <20080829020409.2880013b.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
0 siblings, 1 reply; 14+ messages in thread
From: Andrew Morton @ 2008-08-29 9:04 UTC (permalink / raw)
To: Jean Delvare
Cc: Martin Schwidefsky, Heiko-cy1Wll9GaHOsTnJN9+BGXg, Carstens,
i2c-GZX6beZjE8VD60Wz+7aTrA
On Fri, 29 Aug 2008 10:45:33 +0200 Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org> wrote:
> Hi Andrew,
>
> On Fri, 29 Aug 2008 00:52:17 -0700, Andrew Morton wrote:
> > drivers/i2c/busses/i2c-ocores.c: In function 'oc_setreg':
> > drivers/i2c/busses/i2c-ocores.c:68: error: implicit declaration of function 'iowrite8'
> > drivers/i2c/busses/i2c-ocores.c: In function 'oc_getreg':
> > drivers/i2c/busses/i2c-ocores.c:73: error: implicit declaration of function 'ioread8'
> > drivers/i2c/busses/i2c-ocores.c: In function 'ocores_i2c_probe':
> > drivers/i2c/busses/i2c-ocores.c:243: error: implicit declaration of function 'ioremap'
> > drivers/i2c/busses/i2c-ocores.c:243: warning: assignment makes pointer from integer without a cast
> > drivers/i2c/busses/i2c-ocores.c:279: error: implicit declaration of function 'iounmap'
> >
> > Some missing Kconfig dependency. s390 can't do IO :)
>
> Where is this failure happening? In Linus' tree, I2C depends on
> HAS_IOMEM (which s390 doesn't have), and I2C_OCORES depends on I2C. So
> I fail to see how a make allmodconfig can select I2C_OCORES on s390.
> Can you share the .config file?
>
<bisects>
It's
power-support-for-texas-instruments-bq27x00-battery-managers.patch,
which does
--- a/drivers/power/Kconfig~power-support-for-texas-instruments-bq27x00-battery-managers
+++ a/drivers/power/Kconfig
@@ -62,4 +62,17 @@ config BATTERY_PALMTX
help
Say Y to enable support for the battery in Palm T|X.
+config BATTERY_BQ27x00
+ tristate "BQ27x00 battery driver"
+ help
+ Say Y here to enable support for batteries with BQ27000 or
+ BQ27200 chip.
+
+config BATTERY_BQ27200
+ bool "BQ27200 battery driver"
+ depends on BATTERY_BQ27x00
+ select I2C
+ help
+ Say Y here to enable support for batteries with BQ27200(I2C) chip.
+
which enables I2C stuff in s390 allmodconfig. Should it be `depends on'?
_______________________________________________
i2c mailing list
i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org
http://lists.lm-sensors.org/mailman/listinfo/i2c
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: s390 allmodconfig
[not found] ` <20080829020409.2880013b.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
@ 2008-08-29 9:09 ` Rodolfo Giometti
2008-08-29 10:47 ` Jean Delvare
0 siblings, 1 reply; 14+ messages in thread
From: Rodolfo Giometti @ 2008-08-29 9:09 UTC (permalink / raw)
To: Andrew Morton
Cc: Martin Schwidefsky, Heiko Carstens, i2c-GZX6beZjE8VD60Wz+7aTrA
[-- Attachment #1.1: Type: text/plain, Size: 2469 bytes --]
On Fri, Aug 29, 2008 at 02:04:09AM -0700, Andrew Morton wrote:
> On Fri, 29 Aug 2008 10:45:33 +0200 Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org> wrote:
>
> > Hi Andrew,
> >
> > On Fri, 29 Aug 2008 00:52:17 -0700, Andrew Morton wrote:
> > > drivers/i2c/busses/i2c-ocores.c: In function 'oc_setreg':
> > > drivers/i2c/busses/i2c-ocores.c:68: error: implicit declaration of function 'iowrite8'
> > > drivers/i2c/busses/i2c-ocores.c: In function 'oc_getreg':
> > > drivers/i2c/busses/i2c-ocores.c:73: error: implicit declaration of function 'ioread8'
> > > drivers/i2c/busses/i2c-ocores.c: In function 'ocores_i2c_probe':
> > > drivers/i2c/busses/i2c-ocores.c:243: error: implicit declaration of function 'ioremap'
> > > drivers/i2c/busses/i2c-ocores.c:243: warning: assignment makes pointer from integer without a cast
> > > drivers/i2c/busses/i2c-ocores.c:279: error: implicit declaration of function 'iounmap'
> > >
> > > Some missing Kconfig dependency. s390 can't do IO :)
> >
> > Where is this failure happening? In Linus' tree, I2C depends on
> > HAS_IOMEM (which s390 doesn't have), and I2C_OCORES depends on I2C. So
> > I fail to see how a make allmodconfig can select I2C_OCORES on s390.
> > Can you share the .config file?
> >
>
> <bisects>
>
> It's
> power-support-for-texas-instruments-bq27x00-battery-managers.patch,
> which does
>
> --- a/drivers/power/Kconfig~power-support-for-texas-instruments-bq27x00-battery-managers
> +++ a/drivers/power/Kconfig
> @@ -62,4 +62,17 @@ config BATTERY_PALMTX
> help
> Say Y to enable support for the battery in Palm T|X.
>
> +config BATTERY_BQ27x00
> + tristate "BQ27x00 battery driver"
> + help
> + Say Y here to enable support for batteries with BQ27000 or
> + BQ27200 chip.
> +
> +config BATTERY_BQ27200
> + bool "BQ27200 battery driver"
> + depends on BATTERY_BQ27x00
> + select I2C
> + help
> + Say Y here to enable support for batteries with BQ27200(I2C) chip.
> +
>
>
> which enables I2C stuff in s390 allmodconfig. Should it be `depends on'?
Yes.
depends on I2C && BATTERY_BQ27x00
Ciao,
Rodolfo
--
GNU/Linux Solutions e-mail: giometti-AVVDYK/kqiJWk0Htik3J/w@public.gmane.org
Linux Device Driver giometti-k2GhghHVRtY@public.gmane.org
Embedded Systems phone: +39 349 2432127
UNIX programming skype: rodolfo.giometti
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
[-- Attachment #2: Type: text/plain, Size: 157 bytes --]
_______________________________________________
i2c mailing list
i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org
http://lists.lm-sensors.org/mailman/listinfo/i2c
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: s390 allmodconfig
2008-08-29 9:09 ` Rodolfo Giometti
@ 2008-08-29 10:47 ` Jean Delvare
0 siblings, 0 replies; 14+ messages in thread
From: Jean Delvare @ 2008-08-29 10:47 UTC (permalink / raw)
To: Rodolfo Giometti
Cc: Schwidefsky, Heiko Carstens, i2c-GZX6beZjE8VD60Wz+7aTrA,
Martin-cy1Wll9GaHOsTnJN9+BGXg
On Fri, 29 Aug 2008 11:09:18 +0200, Rodolfo Giometti wrote:
> On Fri, Aug 29, 2008 at 02:04:09AM -0700, Andrew Morton wrote:
> > On Fri, 29 Aug 2008 10:45:33 +0200 Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org> wrote:
> >
> > > Hi Andrew,
> > >
> > > On Fri, 29 Aug 2008 00:52:17 -0700, Andrew Morton wrote:
> > > > drivers/i2c/busses/i2c-ocores.c: In function 'oc_setreg':
> > > > drivers/i2c/busses/i2c-ocores.c:68: error: implicit declaration of function 'iowrite8'
> > > > drivers/i2c/busses/i2c-ocores.c: In function 'oc_getreg':
> > > > drivers/i2c/busses/i2c-ocores.c:73: error: implicit declaration of function 'ioread8'
> > > > drivers/i2c/busses/i2c-ocores.c: In function 'ocores_i2c_probe':
> > > > drivers/i2c/busses/i2c-ocores.c:243: error: implicit declaration of function 'ioremap'
> > > > drivers/i2c/busses/i2c-ocores.c:243: warning: assignment makes pointer from integer without a cast
> > > > drivers/i2c/busses/i2c-ocores.c:279: error: implicit declaration of function 'iounmap'
> > > >
> > > > Some missing Kconfig dependency. s390 can't do IO :)
> > >
> > > Where is this failure happening? In Linus' tree, I2C depends on
> > > HAS_IOMEM (which s390 doesn't have), and I2C_OCORES depends on I2C. So
> > > I fail to see how a make allmodconfig can select I2C_OCORES on s390.
> > > Can you share the .config file?
> > >
> >
> > <bisects>
> >
> > It's
> > power-support-for-texas-instruments-bq27x00-battery-managers.patch,
> > which does
> >
> > --- a/drivers/power/Kconfig~power-support-for-texas-instruments-bq27x00-battery-managers
> > +++ a/drivers/power/Kconfig
> > @@ -62,4 +62,17 @@ config BATTERY_PALMTX
> > help
> > Say Y to enable support for the battery in Palm T|X.
> >
> > +config BATTERY_BQ27x00
> > + tristate "BQ27x00 battery driver"
> > + help
> > + Say Y here to enable support for batteries with BQ27000 or
> > + BQ27200 chip.
> > +
> > +config BATTERY_BQ27200
> > + bool "BQ27200 battery driver"
> > + depends on BATTERY_BQ27x00
> > + select I2C
> > + help
> > + Say Y here to enable support for batteries with BQ27200(I2C) chip.
> > +
> >
> >
> > which enables I2C stuff in s390 allmodconfig. Should it be `depends on'?
>
> Yes.
>
> depends on I2C && BATTERY_BQ27x00
>
Yes please. Ideally nothing but arch files should ever select I2C.
--
Jean Delvare
_______________________________________________
i2c mailing list
i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org
http://lists.lm-sensors.org/mailman/listinfo/i2c
^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2008-08-29 10:47 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-03-02 8:18 s390 allmodconfig Andrew Morton
2007-03-02 8:25 ` Andrew Morton
2007-03-02 10:32 ` Richard Purdie
2007-03-02 11:01 ` Andrew Morton
2007-03-02 10:38 ` Johannes Berg
2007-03-02 11:06 ` Andrew Morton
2007-03-02 11:11 ` Johannes Berg
2007-03-02 11:20 ` Andrew Morton
2007-03-02 17:48 ` Martin Schwidefsky
-- strict thread matches above, loose matches on Subject: below --
2008-08-29 7:52 Andrew Morton
[not found] ` <20080829005217.509a6c23.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2008-08-29 8:45 ` Jean Delvare
[not found] ` <20080829104533.0e65f43a-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2008-08-29 9:04 ` Andrew Morton
[not found] ` <20080829020409.2880013b.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2008-08-29 9:09 ` Rodolfo Giometti
2008-08-29 10:47 ` Jean Delvare
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.