From: Len Brown <len.brown@intel.com>
To: linux-acpi@vger.kernel.org
Cc: Kristen Accardi <kristen.c.accardi@intel.com>,
Len Brown <len.brown@intel.com>
Subject: [PATCH 16/20] libata-acpi: allow _GTF on SATA, but disable on PATA for now
Date: Fri, 9 Mar 2007 22:49:34 -0500 [thread overview]
Message-ID: <11734985912054-git-send-email-len.brown@intel.com> (raw)
Message-ID: <df33c77e3981e71afc8727ee5c432ba1a1bba68c.1173498420.git.len.brown@intel.com> (raw)
In-Reply-To: <11734985901640-git-send-email-len.brown@intel.com>
In-Reply-To: <7292576043666ff39946dee14641fe719ba8c7e8.1173498420.git.len.brown@intel.com>
From: Kristen Accardi <kristen.c.accardi@intel.com>
The ACPI specification states, and BIOS implementations depend on,
_STM being called before _GTF.
SATA does this, but PATA does not. So for now, simply
prevent execution of _GTF on PATA devices. Longer term we
should implement ACPI support for PATA devices in libata.
Signed-off-by: Kristen Accardi <kristen.c.accardi@intel.com>
Signed-off-by: Len Brown <len.brown@intel.com>
---
drivers/ata/libata-acpi.c | 7 +++++++
1 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/drivers/ata/libata-acpi.c b/drivers/ata/libata-acpi.c
index d14a48e..89aaf74 100644
--- a/drivers/ata/libata-acpi.c
+++ b/drivers/ata/libata-acpi.c
@@ -561,6 +561,13 @@ int ata_acpi_exec_tfs(struct ata_port *ap)
if (noacpi)
return 0;
+ /*
+ * TBD - implement PATA support. For now,
+ * we should not run GTF on PATA devices since some
+ * PATA require execution of GTM/STM before GTF.
+ */
+ if (!(ap->cbl == ATA_CBL_SATA))
+ return 0;
for (ix = 0; ix < ATA_MAX_DEVICES; ix++) {
if (!ata_dev_enabled(&ap->device[ix]))
--
1.5.0.3.310.g05ef5
next prev parent reply other threads:[~2007-03-10 3:49 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-10 3:49 ACPI patches for release to 2.6.21-rc Len Brown
2007-03-10 3:49 ` [PATCH 01/20] ACPI: fix S3 fan resume issue Len Brown
2007-03-10 3:49 ` Len Brown
2007-03-10 3:49 ` [PATCH 02/20] ACPI: ibm-acpi: fix initial status of backlight device Len Brown
2007-03-10 3:49 ` Len Brown
2007-03-10 3:49 ` [PATCH 03/20] ACPI: ibm-acpi: make ibm-acpi bay support optional Len Brown
2007-03-10 3:49 ` Len Brown
2007-03-10 3:49 ` [PATCH 04/20] ACPI: Altix: cannot register acpi bus driver before bus scan Len Brown
2007-03-10 3:49 ` Len Brown
2007-03-10 3:49 ` [PATCH 05/20] ACPI: Altix: reinitialize acpi tables Len Brown
2007-03-10 3:49 ` Len Brown
2007-03-10 3:49 ` [PATCH 06/20] ACPICA: Fix ACPI Global Lock re-entrancy Len Brown
2007-03-10 3:49 ` Len Brown
2007-03-10 3:49 ` [PATCH 07/20] sony-laptop: fix uninitialised variable Len Brown
2007-03-10 3:49 ` Len Brown
2007-03-10 3:49 ` [PATCH 08/20] ACPI: Add kernel-parameters hint that acpi=off doesn't work on IA64 Len Brown
2007-03-10 3:49 ` Len Brown
2007-03-10 3:49 ` [PATCH 09/20] ACPI: ThinkPad Z60m: usb mouse stops working after suspend to RAM Len Brown
2007-03-10 3:49 ` Len Brown
2007-03-10 3:49 ` [PATCH 10/20] ACPI: ec: fix race in status register access Len Brown
2007-03-10 3:49 ` Len Brown
2007-03-10 7:29 ` Alexey Starikovskiy
2007-03-10 7:34 ` Len Brown
2007-03-10 3:49 ` [PATCH 11/20] ACPI: fix Thinkpad 600/600E/600X interrupts Len Brown
2007-03-10 3:49 ` Len Brown
2007-03-10 3:49 ` [PATCH 12/20] ACPI: fix boot hang w/o "noapic" on MSI MS-6390-L Len Brown
2007-03-10 3:49 ` Len Brown
2007-03-10 3:49 ` [PATCH 13/20] ACPI: ibm-acpi: improve backlight power handling Len Brown
2007-03-10 3:49 ` Len Brown
2007-03-10 3:49 ` [PATCH 14/20] ACPI: fix parallel port IRQ after resume from S3 Len Brown
2007-03-10 3:49 ` Len Brown
2007-03-10 3:49 ` [PATCH 15/20] ACPI: repair nvidia early quirk breakage on x86_64 Len Brown
2007-03-10 3:49 ` Len Brown
2007-03-10 3:49 ` Len Brown [this message]
2007-03-10 3:49 ` [PATCH 16/20] libata-acpi: allow _GTF on SATA, but disable on PATA for now Len Brown
[not found] ` <117349 85922550-git-send-email-len.brown@intel.com>
2007-03-10 3:49 ` [PATCH 17/20] asus-laptop: make code static Len Brown
2007-03-10 3:49 ` Len Brown
2007-03-10 3:49 ` [PATCH 19/20] ACPI: video: Fix spelling and grammar mistakes Len Brown
2007-03-10 3:49 ` Len Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11734985912054-git-send-email-len.brown@intel.com \
--to=len.brown@intel.com \
--cc=kristen.c.accardi@intel.com \
--cc=linux-acpi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.