From: James Bowes <jbowes@dangerouslyinc.com>
To: git@vger.kernel.org
Subject: [PATCH 2/2] Make gc a builtin.
Date: Sun, 11 Mar 2007 18:06:58 -0400 [thread overview]
Message-ID: <1173650820969-git-send-email-jbowes@dangerouslyinc.com> (raw)
In-Reply-To: <11736508181273-git-send-email-jbowes@dangerouslyinc.com>
Signed-off-by: James Bowes <jbowes@dangerouslyinc.com>
---
Makefile | 3 +-
builtin-gc.c | 81 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
builtin.h | 1 +
git-gc.sh | 37 --------------------------
git.c | 1 +
5 files changed, 85 insertions(+), 38 deletions(-)
create mode 100644 builtin-gc.c
delete mode 100755 git-gc.sh
diff --git a/Makefile b/Makefile
index f0fc2f8..fb17cfb 100644
--- a/Makefile
+++ b/Makefile
@@ -177,7 +177,7 @@ BASIC_LDFLAGS =
SCRIPT_SH = \
git-bisect.sh git-checkout.sh \
git-clean.sh git-clone.sh git-commit.sh \
- git-fetch.sh git-gc.sh \
+ git-fetch.sh \
git-ls-remote.sh \
git-merge-one-file.sh git-parse-remote.sh \
git-pull.sh git-rebase.sh \
@@ -297,6 +297,7 @@ BUILTIN_OBJS = \
builtin-fmt-merge-msg.o \
builtin-for-each-ref.o \
builtin-fsck.o \
+ builtin-gc.o \
builtin-grep.o \
builtin-init-db.o \
builtin-log.o \
diff --git a/builtin-gc.c b/builtin-gc.c
new file mode 100644
index 0000000..7a9332b
--- /dev/null
+++ b/builtin-gc.c
@@ -0,0 +1,81 @@
+/*
+ * git gc builtin command
+ *
+ * Cleanup unreachable files and optimize the repository.
+ *
+ * Copyright (c) 2007 James Bowes
+ *
+ * Based on git-gc.sh, which is
+ *
+ * Copyright (c) 2006 Shawn O. Pearce
+ */
+
+#include "cache.h"
+#include "run-command.h"
+
+static const char builtin_gc_usage[] = "git-gc [--prune]";
+
+static int pack_refs;
+
+static int gc_config(const char *var, const char *value)
+{
+ if (!strcmp(var, "gc.packrefs"))
+ if (strlen(value) == 0 || !strcmp(value, "notbare"))
+ pack_refs = !is_bare_repository();
+ else
+ pack_refs = git_config_bool(var, value);
+ else
+ return git_default_config(var, value);
+ return 0;
+}
+
+static void run_command_or_die(const char *cmd, ...)
+{
+ int err;
+ va_list params;
+
+ va_start(params, cmd);
+ err = run_command_va(cmd, params);
+ va_end(params);
+
+ switch (err) {
+ case 0:
+ return;
+ case -ERR_RUN_COMMAND_FORK:
+ die("unable to fork for %s", cmd);
+ case -ERR_RUN_COMMAND_EXEC:
+ die("unable to exec %s", cmd);
+ default:
+ die("%s died with strange error", cmd);
+ }
+}
+
+int cmd_gc(int argc, const char **argv, const char *prefix)
+{
+ int i;
+ int prune = 0;
+
+ git_config(gc_config);
+
+ for (i = 1; i < argc; i++) {
+ const char *arg = argv[i];
+ if (!strcmp(arg, "--prune")) {
+ prune = 1;
+ continue;
+ }
+ /* perhaps other parameters later... */
+ break;
+ }
+ if (i != argc)
+ usage(builtin_gc_usage);
+
+ if (pack_refs)
+ run_command_or_die("git-pack-refs", "--prune", NULL);
+ run_command_or_die("git-reflog", "expire", "--all", NULL);
+ run_command_or_die("git-repack", "-a", "-d", "-l", NULL);
+ if (prune)
+ run_command_or_die("git-prune", NULL);
+ run_command_or_die("git-rerere", "gc", NULL);
+
+ return 0;
+}
diff --git a/builtin.h b/builtin.h
index 1cb64b7..af203e9 100644
--- a/builtin.h
+++ b/builtin.h
@@ -37,6 +37,7 @@ extern int cmd_fmt_merge_msg(int argc, const char **argv, const char *prefix);
extern int cmd_for_each_ref(int argc, const char **argv, const char *prefix);
extern int cmd_format_patch(int argc, const char **argv, const char *prefix);
extern int cmd_fsck(int argc, const char **argv, const char *prefix);
+extern int cmd_gc(int argc, const char **argv, const char *prefix);
extern int cmd_get_tar_commit_id(int argc, const char **argv, const char *prefix);
extern int cmd_grep(int argc, const char **argv, const char *prefix);
extern int cmd_help(int argc, const char **argv, const char *prefix);
diff --git a/git-gc.sh b/git-gc.sh
deleted file mode 100755
index 436d7ca..0000000
--- a/git-gc.sh
+++ /dev/null
@@ -1,37 +0,0 @@
-#!/bin/sh
-#
-# Copyright (c) 2006, Shawn O. Pearce
-#
-# Cleanup unreachable files and optimize the repository.
-
-USAGE='[--prune]'
-SUBDIRECTORY_OK=Yes
-. git-sh-setup
-
-no_prune=:
-while case $# in 0) break ;; esac
-do
- case "$1" in
- --prune)
- no_prune=
- ;;
- --)
- usage
- ;;
- esac
- shift
-done
-
-case "$(git config --get gc.packrefs)" in
-notbare|"")
- test $(is_bare_repository) = true || pack_refs=true;;
-*)
- pack_refs=$(git config --bool --get gc.packrefs)
-esac
-
-test "true" != "$pack_refs" ||
-git-pack-refs --prune &&
-git-reflog expire --all &&
-git-repack -a -d -l &&
-$no_prune git-prune &&
-git-rerere gc || exit
diff --git a/git.c b/git.c
index dde4d07..ed1c65e 100644
--- a/git.c
+++ b/git.c
@@ -249,6 +249,7 @@ static void handle_internal_command(int argc, const char **argv, char **envp)
{ "format-patch", cmd_format_patch, RUN_SETUP },
{ "fsck", cmd_fsck, RUN_SETUP },
{ "fsck-objects", cmd_fsck, RUN_SETUP },
+ { "gc", cmd_gc, RUN_SETUP },
{ "get-tar-commit-id", cmd_get_tar_commit_id },
{ "grep", cmd_grep, RUN_SETUP | USE_PAGER },
{ "help", cmd_help },
--
1.5.0.2
next prev parent reply other threads:[~2007-03-11 22:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-11 22:06 [PATCH 0/2] Make gc a builtin James Bowes
2007-03-11 22:06 ` [PATCH 1/2] run-command: Make run_command_va_opt public and add run_command_va James Bowes
2007-03-11 22:06 ` James Bowes [this message]
2007-03-11 22:48 ` [PATCH 2/2] Make gc a builtin Johannes Schindelin
2007-03-12 2:11 ` Junio C Hamano
2007-03-12 2:51 ` [PATCH] " James Bowes
2007-03-12 14:43 ` Shawn O. Pearce
2007-03-12 3:07 ` [PATCH 2/2] " Johannes Schindelin
2007-03-12 2:57 ` [PATCH 0/2] " Theodore Tso
2007-03-12 11:23 ` Johannes Schindelin
2007-03-12 13:36 ` Theodore Tso
2007-03-12 19:14 ` Linus Torvalds
2007-03-13 0:48 ` Jakub Narebski
2007-03-13 1:20 ` Linus Torvalds
2007-03-12 14:29 ` Shawn O. Pearce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1173650820969-git-send-email-jbowes@dangerouslyinc.com \
--to=jbowes@dangerouslyinc.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.