All of lore.kernel.org
 help / color / mirror / Atom feed
From: Theodore Tso <tytso@mit.edu>
To: James Bowes <jbowes@dangerouslyinc.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 0/2] Make gc a builtin.
Date: Sun, 11 Mar 2007 22:57:36 -0400	[thread overview]
Message-ID: <20070312025736.GA28505@thunk.org> (raw)
In-Reply-To: <11736508181273-git-send-email-jbowes@dangerouslyinc.com>

On Sun, Mar 11, 2007 at 06:06:56PM -0400, James Bowes wrote:
> The following two patches make git-gc a builtin command.

What's the advantage in making git-gc a builtin command?  It's not
like it's going to help performance a whole lot (especially since
you're just forking separate processes to run git-prune,
git-pack-refs, et.al.), and as a shell script it's a lot easier to
explain to people what git-gc is actually doing, so there is
pedagogical value to keeping it as a shell script.

Regards,

						- Ted

  parent reply	other threads:[~2007-03-12  4:53 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-11 22:06 [PATCH 0/2] Make gc a builtin James Bowes
2007-03-11 22:06 ` [PATCH 1/2] run-command: Make run_command_va_opt public and add run_command_va James Bowes
2007-03-11 22:06 ` [PATCH 2/2] Make gc a builtin James Bowes
2007-03-11 22:48   ` Johannes Schindelin
2007-03-12  2:11     ` Junio C Hamano
2007-03-12  2:51       ` [PATCH] " James Bowes
2007-03-12 14:43         ` Shawn O. Pearce
2007-03-12  3:07       ` [PATCH 2/2] " Johannes Schindelin
2007-03-12  2:57 ` Theodore Tso [this message]
2007-03-12 11:23   ` [PATCH 0/2] " Johannes Schindelin
2007-03-12 13:36     ` Theodore Tso
2007-03-12 19:14       ` Linus Torvalds
2007-03-13  0:48         ` Jakub Narebski
2007-03-13  1:20           ` Linus Torvalds
2007-03-12 14:29     ` Shawn O. Pearce

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070312025736.GA28505@thunk.org \
    --to=tytso@mit.edu \
    --cc=git@vger.kernel.org \
    --cc=jbowes@dangerouslyinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.