From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Cc: bzolnier@gmail.com, linux-kernel@vger.kernel.org,
linuxppc-dev@ozlabs.org, Al Viro <viro@ftp.linux.org.uk>,
torvalds@linux-foundation.org
Subject: Re: [PATCH] BLK_DEV_IDE_CELLEB dependency fix
Date: Thu, 15 Mar 2007 18:31:56 +0100 [thread overview]
Message-ID: <1173979916.6861.18.camel@localhost.localdomain> (raw)
In-Reply-To: <45F9588C.7020108@ru.mvista.com>
On Thu, 2007-03-15 at 17:30 +0300, Sergei Shtylyov wrote:
> Hello.
>
> Akira Iguchi wrote:
>
> > It's bool and it depends on BLK_DEV_IDE
> > => should depend on BLK_DEV_IDE=y
>
> Hm, why I'm seeing module_init() in the driver? :-)
>
> > And move it to "if BLK_DEV_IDEDMA_PCI" block because it depends on
> > BLK_DEV_IDEDMA_PCI.
>
> IMHO, that driver shouldn't be in drivers/ide/ppc/ then... Why it got
> there (the same question about PowerMac driver)?
Not sure... some reorg changes ide-pmac.c into ppc/pmac.c or such, I
don't remember who did it tho.
Ben.
WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Cc: Akira Iguchi <akira2.iguchi@toshiba.co.jp>,
linuxppc-dev@ozlabs.org, torvalds@linux-foundation.org,
linux-kernel@vger.kernel.org, bzolnier@gmail.com,
Al Viro <viro@ftp.linux.org.uk>
Subject: Re: [PATCH] BLK_DEV_IDE_CELLEB dependency fix
Date: Thu, 15 Mar 2007 18:31:56 +0100 [thread overview]
Message-ID: <1173979916.6861.18.camel@localhost.localdomain> (raw)
In-Reply-To: <45F9588C.7020108@ru.mvista.com>
On Thu, 2007-03-15 at 17:30 +0300, Sergei Shtylyov wrote:
> Hello.
>
> Akira Iguchi wrote:
>
> > It's bool and it depends on BLK_DEV_IDE
> > => should depend on BLK_DEV_IDE=y
>
> Hm, why I'm seeing module_init() in the driver? :-)
>
> > And move it to "if BLK_DEV_IDEDMA_PCI" block because it depends on
> > BLK_DEV_IDEDMA_PCI.
>
> IMHO, that driver shouldn't be in drivers/ide/ppc/ then... Why it got
> there (the same question about PowerMac driver)?
Not sure... some reorg changes ide-pmac.c into ppc/pmac.c or such, I
don't remember who did it tho.
Ben.
next prev parent reply other threads:[~2007-03-15 17:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-15 6:30 [PATCH] BLK_DEV_IDE_CELLEB dependency fix Akira Iguchi
2007-03-15 14:30 ` Sergei Shtylyov
2007-03-15 14:30 ` Sergei Shtylyov
2007-03-15 17:31 ` Benjamin Herrenschmidt [this message]
2007-03-15 17:31 ` Benjamin Herrenschmidt
-- strict thread matches above, loose matches on Subject: below --
2007-03-15 6:30 Akira Iguchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1173979916.6861.18.camel@localhost.localdomain \
--to=benh@kernel.crashing.org \
--cc=bzolnier@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=sshtylyov@ru.mvista.com \
--cc=torvalds@linux-foundation.org \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.