From: "Wu, Bryan" <bryan.wu@analog.com>
To: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
Cc: Andrew Morton <akpm@linux-foundation.org>,
uclinux-dist-devel@blackfin.uclinux.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] blackfin: balance parenthesis in macros
Date: Fri, 16 Mar 2007 12:02:27 +0800 [thread overview]
Message-ID: <1174017747.20198.2.camel@roc-desktop> (raw)
In-Reply-To: <200703152312.21981.m.kozlowski@tuxland.pl>
On Thu, 2007-03-15 at 18:12 -0400, Mariusz Kozlowski wrote:
> Hello,
>
> This patch (against 2.6.21-rc3-mm1) balances parenthesis in blackfin
> header files.
>
> Signed-off-by: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
>
> include/asm-blackfin/mach-bf535/bf535.h | 4 ++--
> include/asm-blackfin/scatterlist.h | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff -u linux-2.6.21-rc3-mm1-a/include/asm-blackfin/mach-bf535/bf535.h linux-2.6.21-rc3-mm1-b/include/asm-blackfin/mach-bf535/bf535.h
> --- linux-2.6.21-rc3-mm1-a/include/asm-blackfin/mach-bf535/bf535.h 2007-03-15 22:25:34.000000000 +0100
> +++ linux-2.6.21-rc3-mm1-b/include/asm-blackfin/mach-bf535/bf535.h 2007-03-15 22:33:09.000000000 +0100
> @@ -224,7 +224,7 @@
> #define UART0_LSR_TEMT 0x40 /* TSR and UARTx_thr both empty */
>
> #define UART0_MSR_ADDR 0xffc0180c /* UART 0 Modem status register 16 bit */
> -#define UART0_MSR HALFWORD_REF(UART0_MSR_ADDR
> +#define UART0_MSR HALFWORD_REF(UART0_MSR_ADDR)
> #define UART0_SCR_ADDR 0xffc0180e /* UART 0 Scratch register 16 bit */
> #define UART0_SCR HALFWORD_REF(UART0_SCR_ADDR)
> #define UART0_IRCR_ADDR 0xffc01810 /* UART 0 IrDA Control register 16 bit */
> @@ -331,7 +331,7 @@
> #define UART1_LSR_TEMT 0x40 /* TSR and UARTx_thr both empty */
>
> #define UART1_MSR_ADDR 0xffc01c0c /* UART 1 Modem status register 16 bit */
> -#define UART1_MSR HALFWORD_REF(UART1_MSR_ADDR
> +#define UART1_MSR HALFWORD_REF(UART1_MSR_ADDR)
> #define UART1_SCR_ADDR 0xffc01c0e /* UART 1 Scratch register 16 bit */
> #define UART1_SCR HALFWORD_REF(UART1_SCR_ADDR)
>
> diff -upr linux-2.6.21-rc3-mm1-a/include/asm-blackfin/scatterlist.h linux-2.6.21-rc3-mm1-b/include/asm-blackfin/scatterlist.h
> --- linux-2.6.21-rc3-mm1-a/include/asm-blackfin/scatterlist.h 2007-03-15 22:25:34.000000000 +0100
> +++ linux-2.6.21-rc3-mm1-b/include/asm-blackfin/scatterlist.h 2007-03-15 22:30:18.000000000 +0100
> @@ -17,7 +17,7 @@ struct scatterlist {
> * returns, or alternatively stop on the first sg_dma_len(sg) which
> * is 0.
> */
> -#define sg_address(sg) (page_address((sg)->page) + (sg)->offset
> +#define sg_address(sg) (page_address((sg)->page) + (sg)->offset)
> #define sg_dma_address(sg) ((sg)->dma_address)
> #define sg_dma_len(sg) ((sg)->length)
>
>
>
> Regards,
>
> Mariusz Kozlowski
Thank you Mariusz,
Mike applied your patch to our SVN repo. I will send out blackfin-arch
update patch including your contribution later.
Your review is very helpful for our development.
Best regards,
-Bryan Wu
prev parent reply other threads:[~2007-03-16 4:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-15 22:12 [PATCH] blackfin: balance parenthesis in macros Mariusz Kozlowski
2007-03-15 22:26 ` Mike Frysinger
2007-03-16 4:02 ` Wu, Bryan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1174017747.20198.2.camel@roc-desktop \
--to=bryan.wu@analog.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.kozlowski@tuxland.pl \
--cc=uclinux-dist-devel@blackfin.uclinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.