* [PATCH] blackfin: balance parenthesis in macros
@ 2007-03-15 22:12 Mariusz Kozlowski
2007-03-15 22:26 ` Mike Frysinger
2007-03-16 4:02 ` Wu, Bryan
0 siblings, 2 replies; 3+ messages in thread
From: Mariusz Kozlowski @ 2007-03-15 22:12 UTC (permalink / raw)
To: Andrew Morton; +Cc: uclinux-dist-devel, linux-kernel
Hello,
This patch (against 2.6.21-rc3-mm1) balances parenthesis in blackfin
header files.
Signed-off-by: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
include/asm-blackfin/mach-bf535/bf535.h | 4 ++--
include/asm-blackfin/scatterlist.h | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff -u linux-2.6.21-rc3-mm1-a/include/asm-blackfin/mach-bf535/bf535.h linux-2.6.21-rc3-mm1-b/include/asm-blackfin/mach-bf535/bf535.h
--- linux-2.6.21-rc3-mm1-a/include/asm-blackfin/mach-bf535/bf535.h 2007-03-15 22:25:34.000000000 +0100
+++ linux-2.6.21-rc3-mm1-b/include/asm-blackfin/mach-bf535/bf535.h 2007-03-15 22:33:09.000000000 +0100
@@ -224,7 +224,7 @@
#define UART0_LSR_TEMT 0x40 /* TSR and UARTx_thr both empty */
#define UART0_MSR_ADDR 0xffc0180c /* UART 0 Modem status register 16 bit */
-#define UART0_MSR HALFWORD_REF(UART0_MSR_ADDR
+#define UART0_MSR HALFWORD_REF(UART0_MSR_ADDR)
#define UART0_SCR_ADDR 0xffc0180e /* UART 0 Scratch register 16 bit */
#define UART0_SCR HALFWORD_REF(UART0_SCR_ADDR)
#define UART0_IRCR_ADDR 0xffc01810 /* UART 0 IrDA Control register 16 bit */
@@ -331,7 +331,7 @@
#define UART1_LSR_TEMT 0x40 /* TSR and UARTx_thr both empty */
#define UART1_MSR_ADDR 0xffc01c0c /* UART 1 Modem status register 16 bit */
-#define UART1_MSR HALFWORD_REF(UART1_MSR_ADDR
+#define UART1_MSR HALFWORD_REF(UART1_MSR_ADDR)
#define UART1_SCR_ADDR 0xffc01c0e /* UART 1 Scratch register 16 bit */
#define UART1_SCR HALFWORD_REF(UART1_SCR_ADDR)
diff -upr linux-2.6.21-rc3-mm1-a/include/asm-blackfin/scatterlist.h linux-2.6.21-rc3-mm1-b/include/asm-blackfin/scatterlist.h
--- linux-2.6.21-rc3-mm1-a/include/asm-blackfin/scatterlist.h 2007-03-15 22:25:34.000000000 +0100
+++ linux-2.6.21-rc3-mm1-b/include/asm-blackfin/scatterlist.h 2007-03-15 22:30:18.000000000 +0100
@@ -17,7 +17,7 @@ struct scatterlist {
* returns, or alternatively stop on the first sg_dma_len(sg) which
* is 0.
*/
-#define sg_address(sg) (page_address((sg)->page) + (sg)->offset
+#define sg_address(sg) (page_address((sg)->page) + (sg)->offset)
#define sg_dma_address(sg) ((sg)->dma_address)
#define sg_dma_len(sg) ((sg)->length)
Regards,
Mariusz Kozlowski
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] blackfin: balance parenthesis in macros
2007-03-15 22:12 [PATCH] blackfin: balance parenthesis in macros Mariusz Kozlowski
@ 2007-03-15 22:26 ` Mike Frysinger
2007-03-16 4:02 ` Wu, Bryan
1 sibling, 0 replies; 3+ messages in thread
From: Mike Frysinger @ 2007-03-15 22:26 UTC (permalink / raw)
To: Mariusz Kozlowski; +Cc: Andrew Morton, uclinux-dist-devel, linux-kernel
On 3/15/07, Mariusz Kozlowski <m.kozlowski@tuxland.pl> wrote:
> This patch (against 2.6.21-rc3-mm1) balances parenthesis in blackfin
> header files.
>
> Signed-off-by: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
thanks, added to our repo
-mike
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] blackfin: balance parenthesis in macros
2007-03-15 22:12 [PATCH] blackfin: balance parenthesis in macros Mariusz Kozlowski
2007-03-15 22:26 ` Mike Frysinger
@ 2007-03-16 4:02 ` Wu, Bryan
1 sibling, 0 replies; 3+ messages in thread
From: Wu, Bryan @ 2007-03-16 4:02 UTC (permalink / raw)
To: Mariusz Kozlowski; +Cc: Andrew Morton, uclinux-dist-devel, linux-kernel
On Thu, 2007-03-15 at 18:12 -0400, Mariusz Kozlowski wrote:
> Hello,
>
> This patch (against 2.6.21-rc3-mm1) balances parenthesis in blackfin
> header files.
>
> Signed-off-by: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
>
> include/asm-blackfin/mach-bf535/bf535.h | 4 ++--
> include/asm-blackfin/scatterlist.h | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff -u linux-2.6.21-rc3-mm1-a/include/asm-blackfin/mach-bf535/bf535.h linux-2.6.21-rc3-mm1-b/include/asm-blackfin/mach-bf535/bf535.h
> --- linux-2.6.21-rc3-mm1-a/include/asm-blackfin/mach-bf535/bf535.h 2007-03-15 22:25:34.000000000 +0100
> +++ linux-2.6.21-rc3-mm1-b/include/asm-blackfin/mach-bf535/bf535.h 2007-03-15 22:33:09.000000000 +0100
> @@ -224,7 +224,7 @@
> #define UART0_LSR_TEMT 0x40 /* TSR and UARTx_thr both empty */
>
> #define UART0_MSR_ADDR 0xffc0180c /* UART 0 Modem status register 16 bit */
> -#define UART0_MSR HALFWORD_REF(UART0_MSR_ADDR
> +#define UART0_MSR HALFWORD_REF(UART0_MSR_ADDR)
> #define UART0_SCR_ADDR 0xffc0180e /* UART 0 Scratch register 16 bit */
> #define UART0_SCR HALFWORD_REF(UART0_SCR_ADDR)
> #define UART0_IRCR_ADDR 0xffc01810 /* UART 0 IrDA Control register 16 bit */
> @@ -331,7 +331,7 @@
> #define UART1_LSR_TEMT 0x40 /* TSR and UARTx_thr both empty */
>
> #define UART1_MSR_ADDR 0xffc01c0c /* UART 1 Modem status register 16 bit */
> -#define UART1_MSR HALFWORD_REF(UART1_MSR_ADDR
> +#define UART1_MSR HALFWORD_REF(UART1_MSR_ADDR)
> #define UART1_SCR_ADDR 0xffc01c0e /* UART 1 Scratch register 16 bit */
> #define UART1_SCR HALFWORD_REF(UART1_SCR_ADDR)
>
> diff -upr linux-2.6.21-rc3-mm1-a/include/asm-blackfin/scatterlist.h linux-2.6.21-rc3-mm1-b/include/asm-blackfin/scatterlist.h
> --- linux-2.6.21-rc3-mm1-a/include/asm-blackfin/scatterlist.h 2007-03-15 22:25:34.000000000 +0100
> +++ linux-2.6.21-rc3-mm1-b/include/asm-blackfin/scatterlist.h 2007-03-15 22:30:18.000000000 +0100
> @@ -17,7 +17,7 @@ struct scatterlist {
> * returns, or alternatively stop on the first sg_dma_len(sg) which
> * is 0.
> */
> -#define sg_address(sg) (page_address((sg)->page) + (sg)->offset
> +#define sg_address(sg) (page_address((sg)->page) + (sg)->offset)
> #define sg_dma_address(sg) ((sg)->dma_address)
> #define sg_dma_len(sg) ((sg)->length)
>
>
>
> Regards,
>
> Mariusz Kozlowski
Thank you Mariusz,
Mike applied your patch to our SVN repo. I will send out blackfin-arch
update patch including your contribution later.
Your review is very helpful for our development.
Best regards,
-Bryan Wu
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-03-16 4:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-03-15 22:12 [PATCH] blackfin: balance parenthesis in macros Mariusz Kozlowski
2007-03-15 22:26 ` Mike Frysinger
2007-03-16 4:02 ` Wu, Bryan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.