From: Hollis Blanchard <hollis@penguinppc.org>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: I write a patch for Japanese NEC i386 old computers.
Date: Sat, 24 Mar 2007 11:25:45 -0500 [thread overview]
Message-ID: <1174753545.602.26.camel@diesel> (raw)
In-Reply-To: <000001c76e2c$a9b694c0$030010ac@temjin>
On Sun, 2007-03-25 at 00:53 +0900, 小関 一志 wrote:
> Hello, all.
>
> I write a patch for GRUB 1.95. this is able to run GRUB2 under NEC PC-9800
> series. (NEC PC-9800 is Japanese i386 computer, but its hardware design is different
> with PC.)
>
> Attach file: grub-1.95-nec98.diff.gz (113Kbytes)
Thanks for your hard work!
You seem to have copied many files from i386/pc to i386/nec. A better
approach would be to share them directly, for example by moving them to
the i386 directory.
Could you separate your changes to common code (e.g. the code movement
above, get_diskinfo, etc) and post those patches separately? That way we
don't have a 650KB (!!!) patch to review.
The code movement patch should just be a list of
old location -> new location
(that way it doesn't take up much space at all :) .
-Hollis
next prev parent reply other threads:[~2007-03-24 16:27 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-24 15:53 I write a patch for Japanese NEC i386 old computers 小関 一志
2007-03-24 16:25 ` Hollis Blanchard [this message]
2007-03-24 19:01 ` Hitoshi Ozeki
2007-03-24 23:00 ` Yoshinori K. Okuji
2007-03-25 3:14 ` Hitoshi Ozeki
2007-03-26 4:24 ` Hitoshi Ozeki
2007-03-28 18:49 ` Yoshinori K. Okuji
-- strict thread matches above, loose matches on Subject: below --
2007-03-25 6:33 Ernest Sales
2007-03-28 15:27 ` Hitoshi Ozeki
2007-03-28 19:25 ` Yoshinori K. Okuji
2007-04-10 18:56 ` Hitoshi Ozeki
2007-04-13 10:57 ` Hitoshi Ozeki
2007-04-13 11:12 ` Vesa Jääskeläinen
[not found] <460a9fb4.7dc3c2f3.286c.ffffde40SMTPIN_ADDED@mx.google.com>
2007-03-29 6:39 ` Ernest Sales
2007-04-07 13:09 ` Yoshinori K. Okuji
2007-04-10 13:25 ` Hitoshi Ozeki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1174753545.602.26.camel@diesel \
--to=hollis@penguinppc.org \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.