[Bluez-devel] RemoteNameRequested signal during discovery patch

[Bluez-devel] RemoteNameRequested signal during discovery patch

[Frederic Danis]

[-- Attachment #1: Type: text/plain, Size: 537 bytes --]

Hello,

I wrote a little patch to add a DBus signal when a remote name is asked 
by the service daemon during discovery, so discovery applications can 
display this information to user.

Regards

Fred

-- 
-----------------------------------------------
It is not by improving the oil lamp that one invents the electric bulb!
-----------------------------------------------
Danis Frederic                   Access Company
Software engineer
Mail : mailto:frederic.danis@access-company.com
-----------------------------------------------


[-- Attachment #2: hcid_name_requested_signal.patch --]
[-- Type: text/plain, Size: 2735 bytes --]

? hcid/.deps
? hcid/.libs
? hcid/Makefile
? hcid/Makefile.in
? hcid/hcid
? hcid/lexer.c
? hcid/parser.c
? hcid/parser.h
Index: hcid/dbus-api.txt
===================================================================
RCS file: /cvsroot/bluez/utils/hcid/dbus-api.txt,v
retrieving revision 1.108
diff -u -r1.108 dbus-api.txt
--- hcid/dbus-api.txt	6 Mar 2007 13:37:39 -0000	1.108
+++ hcid/dbus-api.txt	9 Mar 2007 11:14:46 -0000
@@ -1021,6 +1021,11 @@
 			This signal will be sent every time the service daemon
 			tries to resolve a remote and this fails.
 
+		void RemoteNameRequested(string address)
+
+			This signal will be sent every time the service daemon
+			tries to resolve a remote name during discovery.
+
 		void RemoteAliasChanged(string address, string alias)
 
 			After changing an alias with SetRemoteAlias this
Index: hcid/dbus-hci.c
===================================================================
RCS file: /cvsroot/bluez/utils/hcid/dbus-hci.c,v
retrieving revision 1.16
diff -u -r1.16 dbus-hci.c
--- hcid/dbus-hci.c	26 Feb 2007 14:13:50 -0000	1.16
+++ hcid/dbus-hci.c	9 Mar 2007 11:14:47 -0000
@@ -1005,7 +1005,7 @@
 
 	/* send at least one request or return failed if the list is empty */
 	do {
-		DBusMessage *failed_signal = NULL;
+		DBusMessage *signal = NULL;
 		struct remote_dev_info *dev = l->data;
 		char *peer_addr;
 		bdaddr_t tmp;
@@ -1023,7 +1023,7 @@
 		if (hci_send_req(dd, &rq, 500) < 0) {
 			error("Unable to send the HCI remote name request: %s (%d)",
 						strerror(errno), errno);
-			failed_signal = dev_signal_factory(adapter->dev_id,
+			signal = dev_signal_factory(adapter->dev_id,
 						"RemoteNameFailed",
 						DBUS_TYPE_STRING, &peer_addr,
 						DBUS_TYPE_INVALID);
@@ -1032,21 +1032,30 @@
 		if (rp.status) {
 			error("Remote name request failed with status 0x%02x",
 					rp.status);
-			failed_signal = dev_signal_factory(adapter->dev_id,
+			signal = dev_signal_factory(adapter->dev_id,
 						"RemoteNameFailed",
 						DBUS_TYPE_STRING, &peer_addr,
 						DBUS_TYPE_INVALID);
 		}
 
-		free(peer_addr);
-
-		if (!failed_signal) {
+		if (!signal) {
 			req_sent = 1;
-			break;
+			/* if we are in discovery, inform application of getting name */
+			if (adapter->discov_type & (STD_INQUIRY | PERIODIC_INQUIRY)) {
+				signal = dev_signal_factory(adapter->dev_id,
+							"RemoteNameRequested",
+							DBUS_TYPE_STRING, &peer_addr,
+							DBUS_TYPE_INVALID);
+			} else {
+				free(peer_addr);
+				break;
+			}
 		}
 
-		send_message_and_unref(connection, failed_signal);
-		failed_signal = NULL;
+		free(peer_addr);
+
+		send_message_and_unref(connection, signal);
+		signal = NULL;
 
 		/* if failed, request the next element */
 		/* remove the element from the list */

[-- Attachment #3: Type: text/plain, Size: 345 bytes --]

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV

[-- Attachment #4: Type: text/plain, Size: 164 bytes --]

_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel

Re: [Bluez-devel] RemoteNameRequested signal during discovery patch

[Frederic Danis]

[-- Attachment #1: Type: text/plain, Size: 318 bytes --]

Hello,

A new version of the patch.
Are you okay with it ?

Thanks

Fred

Frederic Danis a écrit :
> Hello,
> 
> I wrote a little patch to add a DBus signal when a remote name is asked 
> by the service daemon during discovery, so discovery applications can 
> display this information to user.
> 
> Regards
> 
> Fred

[-- Attachment #2: hcid_name_requested_signal.patch --]
[-- Type: text/plain, Size: 2677 bytes --]

? .deps
? .libs
? Makefile
? Makefile.in
? hcid
? lexer.c
? parser.c
? parser.h
Index: dbus-api.txt
===================================================================
RCS file: /cvsroot/bluez/utils/hcid/dbus-api.txt,v
retrieving revision 1.110
diff -a -u -r1.110 dbus-api.txt
--- dbus-api.txt	22 Mar 2007 01:56:44 -0000	1.110
+++ dbus-api.txt	30 Mar 2007 16:02:35 -0000
@@ -1030,6 +1030,11 @@
 			This signal will be sent every time the service daemon
 			tries to resolve a remote and this fails.
 
+		void RemoteNameRequested(string address)
+
+			This signal will be sent every time the service daemon
+			tries to resolve a remote name during discovery.
+
 		void RemoteAliasChanged(string address, string alias)
 
 			After changing an alias with SetRemoteAlias this
Index: dbus-hci.c
===================================================================
RCS file: /cvsroot/bluez/utils/hcid/dbus-hci.c,v
retrieving revision 1.16
diff -a -u -r1.16 dbus-hci.c
--- dbus-hci.c	26 Feb 2007 14:13:50 -0000	1.16
+++ dbus-hci.c	30 Mar 2007 16:02:36 -0000
@@ -1005,7 +1005,7 @@
 
 	/* send at least one request or return failed if the list is empty */
 	do {
-		DBusMessage *failed_signal = NULL;
+		DBusMessage *signal = NULL;
 		struct remote_dev_info *dev = l->data;
 		char *peer_addr;
 		bdaddr_t tmp;
@@ -1023,7 +1023,7 @@
 		if (hci_send_req(dd, &rq, 500) < 0) {
 			error("Unable to send the HCI remote name request: %s (%d)",
 						strerror(errno), errno);
-			failed_signal = dev_signal_factory(adapter->dev_id,
+			signal = dev_signal_factory(adapter->dev_id,
 						"RemoteNameFailed",
 						DBUS_TYPE_STRING, &peer_addr,
 						DBUS_TYPE_INVALID);
@@ -1032,21 +1032,32 @@
 		if (rp.status) {
 			error("Remote name request failed with status 0x%02x",
 					rp.status);
-			failed_signal = dev_signal_factory(adapter->dev_id,
+			signal = dev_signal_factory(adapter->dev_id,
 						"RemoteNameFailed",
 						DBUS_TYPE_STRING, &peer_addr,
 						DBUS_TYPE_INVALID);
 		}
 
+		if (!signal) {
+			req_sent = 1;
+			/* if we are in discovery, inform application of getting name */
+			if (adapter->discov_type & (STD_INQUIRY | PERIODIC_INQUIRY)) {
+				signal = dev_signal_factory(adapter->dev_id,
+							"RemoteNameRequested",
+							DBUS_TYPE_STRING, &peer_addr,
+							DBUS_TYPE_INVALID);
+			}
+		}
+
 		free(peer_addr);
 
-		if (!failed_signal) {
-			req_sent = 1;
-			break;
+		if (signal) {
+			send_message_and_unref(connection, signal);
+			signal = NULL;
 		}
 
-		send_message_and_unref(connection, failed_signal);
-		failed_signal = NULL;
+		if (req_sent)
+			break;
 
 		/* if failed, request the next element */
 		/* remove the element from the list */

[-- Attachment #3: Type: text/plain, Size: 345 bytes --]

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV

[-- Attachment #4: Type: text/plain, Size: 164 bytes --]

_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel

Re: [Bluez-devel] RemoteNameRequested signal during discovery patch

[Marcel Holtmann]

Hi Frederic,

> A new version of the patch.
> Are you okay with it ?

the patch looks okay to me. However I prefer if Claudio or Johan can
have an additional look.

My question is why this signal is actually needed. Please elaborate on
the use cases of this signal.

Regards

Marcel



-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel

Re: [Bluez-devel] RemoteNameRequested signal during discovery patch

[Frederic Danis]

Hello Marcel,

This allows discovery applications to inform user when a device name is bei=
ng retrieved (changing icon or displaying something like "getting name ..."=
 in front =

of the remote device icon). This offers a better user experience because us=
er is informed of discovery process.

Regards

Fred

Marcel Holtmann a =E9crit :
> Hi Frederic,
> =

>> A new version of the patch.
>> Are you okay with it ?
> =

> the patch looks okay to me. However I prefer if Claudio or Johan can
> have an additional look.
> =

> My question is why this signal is actually needed. Please elaborate on
> the use cases of this signal.
> =

> Regards
> =

> Marcel
> =

> =

> =

> -------------------------------------------------------------------------
> Take Surveys. Earn Cash. Influence the Future of IT
> Join SourceForge.net's Techsay panel and you'll get the chance to share y=
our
> opinions on IT & business topics through brief surveys-and earn cash
> http://www.techsay.com/default.php?page=3Djoin.php&p=3Dsourceforge&CID=3D=
DEVDEV
> _______________________________________________
> Bluez-devel mailing list
> Bluez-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/bluez-devel

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=3Djoin.php&p=3Dsourceforge&CID=3DDE=
VDEV
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel

Re: [Bluez-devel] RemoteNameRequested signal during discovery patch

[Johan Hedberg]

Hi,

On Fri, Mar 30, 2007, Marcel Holtmann wrote:
> > A new version of the patch.
> > Are you okay with it ?
> 
> the patch looks okay to me. However I prefer if Claudio or Johan can
> have an additional look.

Looks good to me.

Johan

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel

Re: [Bluez-devel] RemoteNameRequested signal during discovery patch

[Marcel Holtmann]

Hi Johan,

> > > A new version of the patch.
> > > Are you okay with it ?
> > 
> > the patch looks okay to me. However I prefer if Claudio or Johan can
> > have an additional look.
> 
> Looks good to me.

feel free to commit it to the CVS then.

Regards

Marcel



-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel

Re: [Bluez-devel] RemoteNameRequested signal during discovery patch

[Frederic Danis]

Hi Johan,

I can not submit this patch into cvs (no access other than anonymous).
Can you do it please ?

Thanks

Fred

Marcel Holtmann a =E9crit :
> Hi Johan,
> =

>>>> A new version of the patch.
>>>> Are you okay with it ?
>>> the patch looks okay to me. However I prefer if Claudio or Johan can
>>> have an additional look.
>> Looks good to me.
> =

> feel free to commit it to the CVS then.
> =

> Regards
> =

> Marcel
> =

> =

> =

> -------------------------------------------------------------------------
> Take Surveys. Earn Cash. Influence the Future of IT
> Join SourceForge.net's Techsay panel and you'll get the chance to share y=
our
> opinions on IT & business topics through brief surveys-and earn cash
> http://www.techsay.com/default.php?page=3Djoin.php&p=3Dsourceforge&CID=3D=
DEVDEV
> _______________________________________________
> Bluez-devel mailing list
> Bluez-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/bluez-devel

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel

Re: [Bluez-devel] RemoteNameRequested signal during discovery patch

[Marcel Holtmann]

Hi Frederic,

> I can not submit this patch into cvs (no access other than anonymous).
> Can you do it please ?

your patch has been committed to the CVS now. Thanks.

Regards

Marcel



-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel