Re: [PATCH 1/5 v2] adb: replace sleep notifier with class suspend/resume hooks

[Johannes Berg <johannes@sipsolutions.net>]

[-- Attachment #1: Type: text/plain, Size: 1131 bytes --]

On Wed, 2007-04-04 at 09:03 -0400, David Woodhouse wrote:

> I didn't have this set of patches applied. I have these:

Ok.

> Subject: [PATCH 1/3] rework pm_ops pm_disk_mode, kill misuse
> Subject: [PATCH 2/3] power management: remove firmware disk mode
> Subject: [PATCH 3/3] power management: implement pm_ops.valid for everybody
> 
> Subject: [PATCH 1/5] powerpc: generic time suspend/resume code
> Subject: [PATCH 2/5] powerpc: fix suspend states again

Is that the version you have in the fedora CVS? Because that one seems
to be an older one that has a bug with set_context.

> Subject: [PATCH 3/5] powermac: disallow pmu sleep notifiers from aborting
> Subject: [PATCH 4/5 v2] powermac: proper sleep management
> 
> It does re-probe ADB on resume, and it finds the keyboard every time
> (thankfully). 

Interesting.

> It just doesn't find the mouse more than about 1 in 10
> times. Could it just be a timing thing? Resume seems to be a lot faster
> with the patches applied.

I have to admit that I have no idea, I don't have a machine with ADB in
it. I'll poke at the code a bit.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 190 bytes --]