Re: [PATCH 1/5 v2] adb: replace sleep notifier with class suspend/resume hooks

[David Woodhouse <dwmw2@infradead.org>]

On Wed, 2007-04-04 at 19:07 +0200, Johannes Berg wrote:
> Is that the version you have in the fedora CVS? Because that one seems
> to be an older one that has a bug with set_context.

Yes. I've updated the patch in CVS; thanks for pointing it out.

> > Subject: [PATCH 3/5] powermac: disallow pmu sleep notifiers from aborting
> > Subject: [PATCH 4/5 v2] powermac: proper sleep management
> > 
> > It does re-probe ADB on resume, and it finds the keyboard every time
> > (thankfully). 
> 
> Interesting.
> 
> > It just doesn't find the mouse more than about 1 in 10
> > times. Could it just be a timing thing? Resume seems to be a lot faster
> > with the patches applied.
> 
> I have to admit that I have no idea, I don't have a machine with ADB in
> it. I'll poke at the code a bit.

Not sure if the subsequent patch was expected to change anything or not,
but it doesn't...

 $ dmesg | grep -i adb
PM: Adding info for platform:adb.0
adb: starting probe task...
adb devices: [2]: 2 c4 [3]: 3 1 [7]: 7 1f
ADB keyboard at 2, handler 1
Detected ADB keyboard, type ISO, swapping keys.
input: ADB keyboard as /class/input/input1
input: ADB Powerbook buttons as /class/input/input2
ADB mouse at 3, handler set to 4 (trackpad)
input: ADB mouse as /class/input/input3
adb: finished probe task...
adb adb.0: suspend
adb adb.0: LATE suspend
adb adb.0: EARLY resume
adb adb.0: resuming
adb: starting probe task...
adb devices: [2]: 2 c4 [7]: 7 1f
ADB keyboard at 2, handler 1
adb: finished probe task...

-- 
dwmw2